[DRE-maint] Bug#890395: uglifyjs: Please update the package to new version v3.3.10

[Jonas Smedegaard]

Hi Hideki,

Quoting Hideki Yamane (2019-01-04 01:26:34)
> On Wed, 14 Feb 2018 21:04:35 +0100 Jonas Smedegaard <jonas at jones.dk> 
> wrote:
> > Uglifyjs 3.3.10 is now released to experimental.  Since it is a 
> > major new release - SemVer-versioned, which implies 
> > backwards-incompatible changes - so the package need to be tested 
> > against its reverse dependencies before it can enter unstable.
> > 
> > Help is much appreciated doing that compatibility testing!
> > 
> > If it turns out too many reverse dependencies cannot use UglifyJS 3 
> > (and cannot easily be patched to do so), the package could be 
> > released as separate uglifyjs3 source+binary package.
> > 
> > I might also choose to go down that route if too long time passes 
> > without anyone (myself included) finds time to do the needed testing 
> > of all reverse dependencies...
> 
> $ apt-rdepends -r node-uglify
> 
> node-uglify
>   Reverse Depends: emscripten (1.22.1-1)
>   Reverse Depends: lava-dev (2018.11-1)
>   Reverse Depends: node-grunt-contrib-uglify (>= 2.0.0+dfsg-1)
>   Reverse Depends: node-uglifyjs-webpack-plugin (>= 0.4.6-4)
> 
> ------------------------------------------------------------
> emscripten
> ------------------------------------------------------------
>  It contains uglify itself in its source, and its version is 1.0.7...
>  https://github.com/kripken/emscripten
> 
> ------------------------------------------------------------
> lava-dev
> ------------------------------------------------------------
>  Not sure, I cannot find any version comments in its source
> 
> ------------------------------------------------------------
> node-grunt-contrib-uglify
> ------------------------------------------------------------
> >>2017-05-12   v3.0.0   Update uglify-js to v3.0.4.
> 
>  Upstream supports uglify-js3 since v3.0.0, so should be updated.
> 
> ------------------------------------------------------------
> node-uglifyjs-webpack-plugin
> ------------------------------------------------------------
>  Upstream supports uglify-js3 in newer releases
>  https://github.com/webpack-contrib/uglifyjs-webpack-plugin/commit/dc9d038
> 
>  It should be updated.
> 
> 
> $ apt-rdepends -r libjs-uglify
> 
> libjs-uglify
>   Reverse Depends: ruby-uglifier (2.7.2+dfsg-2)
> 
> ------------------------------------------------------------
> ruby-uglifier
> ------------------------------------------------------------
> 
> > 4.0.0 (2 December 2017)
> > update UglifyJS to 3.2.0
> 
>  uglifier upstream (https://github.com/lautis/uglifier/) has released 4.1.20,
>  so should be updated to up to 4.0.0 at least.
> 
> 
>  We should update node-grunt-contrib-uglify, node-uglifyjs-webpack-plugin
>  and ruby-uglifier in experimental to fix uglifyjs's RCbug.

Thanks for your investigation.

If I understand your notes correctly, then you did not, however, test if 
those packages actually builds (and the resulting packages work) with 
the package in experimental.

Also, I believe we must also care for packages build-depending on 
node-uglify:

jonas at auryn:~$ build-rdeps node-uglify
Reverse Build-depends in main:
------------------------------

almond
angular.js
asciimathtml
autosize.js
backbone
bignumber.js
c3
class.js
coffeescript
d3
d3-format
d3-tip.js
diff-match-patch
elycharts.js
emscripten
eonasdan-bootstrap-datetimepicker
es-module-loader-0.17.js
explorercanvas
flightgear-phi
flot
freeipa
gettext.js
gitgraph.js
highlight.js
html2canvas
icingaweb2
impress.js
isso
janus
jekyll
jquery
jquery-areyousure
jquery-at.js
jquery-caret.js
jquery-coolfieldset
jquery-geo
jquery-goodies
jquery-i18n.js
jquery-lazyload
jquery-minicolors
jquery-reflection
jquery-simpletreemenu
jquery-tablesorter
jquery-throttle-debounce
jquery-typeahead.js
jquery-ui-touch-punch.js
jquery-watermark
jqueryui
json-editor.js
json-js
jsrender
jssip
jstimezonedetect.js
jsxgraph
jupyter-notebook
knowl.js
languages4translatewiki
lava
leaflet
leaflet-geometryutil
leaflet-markercluster
lemonldap-ng
less.js
libjs-autolink
libjs-chosen
libjs-cssrelpreload
libjs-dropzone
libjs-fetch
libjs-img.srcset
libjs-jquery-backstretch
libjs-jquery-center
libjs-jquery-jstree
libjs-jquery-markitup
libjs-jquery-scrollto
libjs-jquery-timeago
libjs-jsxc
libjs-term.js
lintian
mgrs
mirror.js
modernizr
modestmaps-js
moment-timezone.js
mustache.js
node-async
node-autolinker
node-axios
node-babel
node-base64-js
node-bluebird
node-bootstrap-tour
node-bowser
node-browser-pack
node-chai
node-chart.js
node-d3-axis
node-d3-brush
node-d3-chord
node-d3-collection
node-d3-color
node-d3-dispatch
node-d3-drag
node-d3-dsv
node-d3-ease
node-d3-force
node-d3-geo
node-d3-hierarchy
node-d3-interpolate
node-d3-path
node-d3-polygon
node-d3-quadtree
node-d3-queue
node-d3-random
node-d3-request
node-d3-scale
node-d3-selection
node-d3-shape
node-d3-time
node-d3-time-format
node-d3-timer
node-d3-transition
node-d3-voronoi
node-d3-zoom
node-debug
node-deep-eql
node-es5-shim
node-es6-promise
node-es6-shim
node-eventemitter2
node-events
node-expect.js
node-filesize
node-fuzzaldrin-plus
node-handlebars
node-hooker
node-html5shiv
node-htmlparser
node-husl
node-ipaddr.js
node-is-typedarray
node-iscroll
node-jquery
node-jquery-textcomplete
node-jquery.waitforimages
node-js-beautify
node-js-cookie
node-jschardet
node-jsonselect
node-katex
node-knockout-sortable
node-knockout-transformations
node-lightgallery
node-lodash
node-lunr
node-marked
node-matrix-js-sdk
node-merge
node-mocha
node-moment
node-opentip
node-pinkyswear
node-prop-types
node-q
node-react-audio-player
node-rollup-plugin-alias
node-rx
node-sdp-transform
node-shiny-server-client
node-sink-test
node-sprintf-js
node-timeago.js
node-turbolinks
node-tweetnacl
node-typedarray-to-buffer
node-umd
node-url-parse
node-util
node-uuid
node-vue-resource
node-webpack
node-websocket
ntopng
openlayers
pegjs
php-codecoverage
polymake
polymaps
prefixfree
proj4js
queue-async
rainbow.js
rainloop
raphael
requirejs
requirejs-text
reqwest
rickshaw
rtcninjajs
ruby-jquery-turbolinks
ruby-rails-assets-favico.js
ruby-rails-assets-jquery-fullscreen-plugin
ruby-rails-assets-perfect-scrollbar
sagenb
sax.js
science.js
searx
sizzle
slick
sockjs-client
spip
strophejs
theano
three.js
tinycon.js
twitter-bootstrap
twitter-bootstrap3
twitter-bootstrap4
typeahead.js
underscore
underscore.string
validator.js
vue.js
wax.js
wims
witty

Found a total of 225 reverse build-depend(s) for node-uglify.

Reverse Build-depends in contrib:
------------------------------

No reverse build-depends found for node-uglify.

Reverse Build-depends in non-free:
------------------------------

No reverse build-depends found for node-uglify.



Seems to me that bumping major version for uglifyjs would count as a 
"large/disruptive change" affected by the "transition freeze" in a week.

My current plan is to instead introduce the 3.x code as a separate 
package.  That should be doable before soft freeze a month from now, 
including shifting over packages to use that, without harming those 
packages working fine with the 2.x release of UglifyJS.


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-ruby-extras-maintainers/attachments/20190104/d3ec5236/attachment.sig>