[DRE-maint] Bug#924125: ruby-chromedriver-helper: attempt an internet communication?

[Gianfranco Costamagna]

Package: ruby-chromedriver-helper
Version: 2.1.0-6
Severity: serious

Hello, I'm filing this bug as serious, because I think the package is trying internet access during build.
I'm not 100% sure, but the problem is fully reproducible with pbuilder and in ubuntu builders, where internet
connection is more strictly checked (and there is a proxy IIRC).
Also DebOMatic (sbuild) fails in testsuite.

example of log:
https://launchpadlibrarian.net/414123400/buildlog_ubuntu-disco-amd64.ruby-chromedriver-helper_2.1.0-6_BUILDING.txt.gz

┌──────────────────────────────────────────────────────────────────────────────┐
│ Run tests for ruby2.5 from debian/ruby-tests.rake                            │
└──────────────────────────────────────────────────────────────────────────────┘

RUBYLIB=. GEM_PATH=debian/ruby-chromedriver-helper/usr/share/rubygems-integration/all:/tmp/.gem/ruby/2.5.0:/var/lib/gems/2.5.0:/usr/lib/x86_64-linux-gnu/rubygems-integration/2.5.0:/usr/share/rubygems-integration/2.5.0:/usr/share/rubygems-integration/all ruby2.5 -S rake -f debian/ruby-tests.rake
/usr/bin/ruby2.5 /usr/bin/rspec --pattern ./spec/\*\*/\*_spec.rb --format documentation

Randomized with seed 2655

Chromedriver::Helper::GoogleCodeParser
  #downloads
    returns an array of URLs for the platform
  #version_download_url
    returns the version asked for
  #newest_download_version
    returns the last URL for the platform

Chromedriver::Helper
  #platform
    given host OS darwin and host CPU irrelevant
      returns mac
    given an unknown host OS
      raises an exception
    given host OS linux and host CPU x86_64
      returns linux64
    given host OS linux and host CPU irrelevant
      returns linux32
    given host OS mswin and host CPU irrelevant
      returns win
    given host OS linux and host CPU amd64
      returns linux64
    given host OS mingw and host CPU irrelevant
      returns win
  #binary_path
    on a linux platform
      example at ./spec/helper_spec.rb:9 (FAILED - 1)
    on a windows platform
      example at ./spec/helper_spec.rb:14 (FAILED - 2)

Failures:

  1) Chromedriver::Helper#binary_path on a linux platform 
     Failure/Error: @source = open_uri_provider.open_uri(BUCKET_URL)

     SocketError:
       Failed to open TCP connection to chromedriver.storage.googleapis.com:443 (getaddrinfo: Name or service not known)
     # ./lib/chromedriver/helper/google_code_parser.rb:14:in `initialize'
     # ./lib/chromedriver/helper.rb:63:in `new'
     # ./lib/chromedriver/helper.rb:63:in `google_code_parser'
     # ./lib/chromedriver/helper.rb:55:in `download_version'
     # ./lib/chromedriver/helper.rb:85:in `version_install_dir'
     # ./lib/chromedriver/helper.rb:79:in `platform_install_dir'
     # ./lib/chromedriver/helper.rb:74:in `binary_path'
     # ./spec/helper_spec.rb:9:in `block (4 levels) in <top (required)>'
     # ------------------
     # --- Caused by: ---
     # SocketError:
     #   getaddrinfo: Name or service not known
     #   ./lib/chromedriver/helper/google_code_parser.rb:14:in `initialize'

  2) Chromedriver::Helper#binary_path on a windows platform 
     Failure/Error: @source = open_uri_provider.open_uri(BUCKET_URL)

     SocketError:
       Failed to open TCP connection to chromedriver.storage.googleapis.com:443 (getaddrinfo: Name or service not known)
     # ./lib/chromedriver/helper/google_code_parser.rb:14:in `initialize'
     # ./lib/chromedriver/helper.rb:63:in `new'
     # ./lib/chromedriver/helper.rb:63:in `google_code_parser'
     # ./lib/chromedriver/helper.rb:55:in `download_version'
     # ./lib/chromedriver/helper.rb:85:in `version_install_dir'
     # ./lib/chromedriver/helper.rb:79:in `platform_install_dir'
     # ./lib/chromedriver/helper.rb:72:in `binary_path'
     # ./spec/helper_spec.rb:14:in `block (4 levels) in <top (required)>'
     # ------------------
     # --- Caused by: ---
     # SocketError:
     #   getaddrinfo: Name or service not known
     #   ./lib/chromedriver/helper/google_code_parser.rb:14:in `initialize'

Finished in 0.13653 seconds (files took 0.28082 seconds to load)
12 examples, 2 failures

Failed examples:

rspec ./spec/helper_spec.rb:9 # Chromedriver::Helper#binary_path on a linux platform 
rspec ./spec/helper_spec.rb:14 # Chromedriver::Helper#binary_path on a windows platform 

Randomized with seed 2655

/usr/bin/ruby2.5 /usr/bin/rspec --pattern ./spec/\*\*/\*_spec.rb --format documentation failed
ERROR: Test "ruby2.5" failed. Exiting.
dh_auto_install: dh_ruby --install /<<PKGBUILDDIR>>/debian/ruby-chromedriver-helper returned exit code 1
make: *** [debian/rules:8: binary] Error 1


thanks for having a look!
Gianfranco