[DRE-maint] Bug#901379: gitlab: postinst script should not call psql if database is not managed by dbconfig-common

[Dominik George]

On Tue, 12 Jun 2018 11:56:45 +0200 Frederik Himpe <fhimpe at ai.vub.ac.be> wrote:
> Package: gitlab
> Version: 10.7.5+dfsg-2~bpo9+1
> Severity: normal
> 
> Dear Maintainer,
> 
> the gitlab.postinst script fails to enable the pg_trgm extension if
> there is no locally running postgresql database:
> 
> Setting up gitlab (10.7.5+dfsg-2~bpo9+1) ...
> Creating/updating gitlab user account...
> Making gitlab owner of /var/lib/gitlab...
> Creating runtime directories for gitlab...
> Updating file permissions...
> Configuring hostname and email...
> Configuring nginx with HTTPS...
> Configuring gitlab with HTTPS...
> Updating gitlab_url in gitlab-shell configuration...
> Registering /usr/lib/tmpfiles.d/gitlab.conf via ucf
> /etc/systemd/system/gitlab-mailroom.service.d/override.conf already
> exist
> /etc/systemd/system/gitlab-unicorn.service.d/override.conf already exist
> /etc/systemd/system/gitlab-sidekiq.service.d/override.conf already exist
> /etc/systemd/system/gitlab-workhorse.service.d/override.conf already
> exist
> Registering /etc/gitlab-shell/config.yml via ucf
> Registering /etc/gitlab/gitlab.yml via ucf
> Registering /etc/gitlab/gitlab-debian.conf via ucf
> dbconfig-common: writing config to /etc/dbconfig-common/gitlab.conf
> dbconfig-common: flushing administrative password
> psql: could not connect to server: No such file or directory
> 	Is the server running locally and accepting
> 		connections on Unix domain socket
> 		"/var/run/postgresql/.s.PGSQL.5432"?
> 		dpkg: error processing package gitlab (--configure):
> 		 subprocess installed post-installation script returned
> 		 error exit status 2
> 
> I chose to not manage the postgresql database by dbconfig because I am using
> an externally running database. In that case this command should not be run.
> 
> 
> -- System Information:
> Debian Release: 9.4
>   APT prefers stable
>   APT policy: (600, 'stable'), (550, 'proposed-updates'), (500, 'oldstable'), (450, 'oldstable-proposed-updates'), (420, 'testing'), (200, 'unstable'), (160, 'experimental'), (150, 'oldoldstable'), (140, 'oldoldstable-proposed-updates')
> Architecture: amd64 (x86_64)
> 
> Kernel: Linux 4.9.0-6-amd64 (SMP w/4 CPU cores)
> Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB:en (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: systemd (via /run/systemd/system)
> 
> Versions of packages gitlab depends on:
> ii  adduser                                    3.115
> ii  apache2 [httpd]                            2.4.25-3+deb9u4
> ii  asciidoctor                                1.5.6.2-2~bpo9+1
> ii  bc                                         1.06.95-9+b3
> ii  bundler                                    1.13.6-2
> ii  dbconfig-pgsql                             2.0.9~bpo9+1