[DRE-maint] Bug#945209: ruby-fakeredis FTBFS with redis 4 in experimental

[Pirate Praveen]

Package: ruby-fakeredis
version: 0.7.0-1
severity: important

This package FTBFS with ruby-redis 4 in experimental and blocking its 
upload to unstable.

Failures:

  1) KeysMethods with extended options uses nx option to only set the 
key if it does not already exist
     Failure/Error: expect(@client.set("key1", "2", { :nx => true 
})).to eq(false)

       expected: false
            got: 0

       (compared using ==)
     # /usr/lib/ruby/vendor_ruby/rspec/support.rb:97:in `block in 
<module:Support>'
     # /usr/lib/ruby/vendor_ruby/rspec/support.rb:106:in 
`notify_failure'
     # /usr/lib/ruby/vendor_ruby/rspec/expectations/fail_with.rb:35:in 
`fail_with'
     # /usr/lib/ruby/vendor_ruby/rspec/expectations/handler.rb:38:in 
`handle_failure'
     # /usr/lib/ruby/vendor_ruby/rspec/expectations/handler.rb:50:in 
`block in handle_matcher'
     # /usr/lib/ruby/vendor_ruby/rspec/expectations/handler.rb:27:in 
`with_matcher'
     # /usr/lib/ruby/vendor_ruby/rspec/expectations/handler.rb:48:in 
`handle_matcher'
     # 
/usr/lib/ruby/vendor_ruby/rspec/expectations/expectation_target.rb:65:in 
`to'
     # ./spec/keys_spec.rb:377:in `block (3 levels) in 
<module:FakeRedis>'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:254:in 
`instance_exec'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:254:in `block in 
run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:500:in `block in 
with_around_and_singleton_context_hooks'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:457:in `block in 
with_around_example_hooks'
     # /usr/lib/ruby/vendor_ruby/rspec/core/hooks.rb:464:in `block in 
run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/hooks.rb:602:in 
`run_around_example_hooks_for'
     # /usr/lib/ruby/vendor_ruby/rspec/core/hooks.rb:464:in `run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:457:in 
`with_around_example_hooks'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:500:in 
`with_around_and_singleton_context_hooks'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:251:in `run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example_group.rb:629:in 
`block in run_examples'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example_group.rb:625:in 
`map'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example_group.rb:625:in 
`run_examples'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example_group.rb:591:in 
`run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example_group.rb:592:in 
`block in run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example_group.rb:592:in 
`map'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example_group.rb:592:in 
`run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:116:in `block (3 
levels) in run_specs'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:116:in `map'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:116:in `block (2 
levels) in run_specs'
     # /usr/lib/ruby/vendor_ruby/rspec/core/configuration.rb:1989:in 
`with_suite_hooks'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:111:in `block in 
run_specs'
     # /usr/lib/ruby/vendor_ruby/rspec/core/reporter.rb:74:in `report'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:110:in `run_specs'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:87:in `run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:71:in `run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:45:in `invoke'
     # /usr/bin/rspec:4:in `<main>'

  2) KeysMethods with extended options uses xx option to only set the 
key if it already exists
     Failure/Error: expect(@client.set("key2", "1", { :xx => true 
})).to eq(false)

       expected: false
            got: 0

       (compared using ==)
     # /usr/lib/ruby/vendor_ruby/rspec/support.rb:97:in `block in 
<module:Support>'
     # /usr/lib/ruby/vendor_ruby/rspec/support.rb:106:in 
`notify_failure'
     # /usr/lib/ruby/vendor_ruby/rspec/expectations/fail_with.rb:35:in 
`fail_with'
     # /usr/lib/ruby/vendor_ruby/rspec/expectations/handler.rb:38:in 
`handle_failure'
     # /usr/lib/ruby/vendor_ruby/rspec/expectations/handler.rb:50:in 
`block in handle_matcher'
     # /usr/lib/ruby/vendor_ruby/rspec/expectations/handler.rb:27:in 
`with_matcher'
     # /usr/lib/ruby/vendor_ruby/rspec/expectations/handler.rb:48:in 
`handle_matcher'
     # 
/usr/lib/ruby/vendor_ruby/rspec/expectations/expectation_target.rb:65:in 
`to'
     # ./spec/keys_spec.rb:383:in `block (3 levels) in 
<module:FakeRedis>'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:254:in 
`instance_exec'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:254:in `block in 
run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:500:in `block in 
with_around_and_singleton_context_hooks'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:457:in `block in 
with_around_example_hooks'
     # /usr/lib/ruby/vendor_ruby/rspec/core/hooks.rb:464:in `block in 
run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/hooks.rb:602:in 
`run_around_example_hooks_for'
     # /usr/lib/ruby/vendor_ruby/rspec/core/hooks.rb:464:in `run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:457:in 
`with_around_example_hooks'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:500:in 
`with_around_and_singleton_context_hooks'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:251:in `run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example_group.rb:629:in 
`block in run_examples'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example_group.rb:625:in 
`map'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example_group.rb:625:in 
`run_examples'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example_group.rb:591:in 
`run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example_group.rb:592:in 
`block in run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example_group.rb:592:in 
`map'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example_group.rb:592:in 
`run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:116:in `block (3 
levels) in run_specs'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:116:in `map'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:116:in `block (2 
levels) in run_specs'
     # /usr/lib/ruby/vendor_ruby/rspec/core/configuration.rb:1989:in 
`with_suite_hooks'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:111:in `block in 
run_specs'
     # /usr/lib/ruby/vendor_ruby/rspec/core/reporter.rb:74:in `report'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:110:in `run_specs'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:87:in `run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:71:in `run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:45:in `invoke'
     # /usr/bin/rspec:4:in `<main>'

  3) KeysMethods with extended options does not set the key if both xx 
and nx option are specified
     Failure/Error: expect(@client.set("key2", "1", { :nx => true, :xx 
=> true })).to eq(false)

       expected: false
            got: 0

       (compared using ==)
     # /usr/lib/ruby/vendor_ruby/rspec/support.rb:97:in `block in 
<module:Support>'
     # /usr/lib/ruby/vendor_ruby/rspec/support.rb:106:in 
`notify_failure'
     # /usr/lib/ruby/vendor_ruby/rspec/expectations/fail_with.rb:35:in 
`fail_with'
     # /usr/lib/ruby/vendor_ruby/rspec/expectations/handler.rb:38:in 
`handle_failure'
     # /usr/lib/ruby/vendor_ruby/rspec/expectations/handler.rb:50:in 
`block in handle_matcher'
     # /usr/lib/ruby/vendor_ruby/rspec/expectations/handler.rb:27:in 
`with_matcher'
     # /usr/lib/ruby/vendor_ruby/rspec/expectations/handler.rb:48:in 
`handle_matcher'
     # 
/usr/lib/ruby/vendor_ruby/rspec/expectations/expectation_target.rb:65:in 
`to'
     # ./spec/keys_spec.rb:391:in `block (3 levels) in 
<module:FakeRedis>'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:254:in 
`instance_exec'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:254:in `block in 
run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:500:in `block in 
with_around_and_singleton_context_hooks'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:457:in `block in 
with_around_example_hooks'
     # /usr/lib/ruby/vendor_ruby/rspec/core/hooks.rb:464:in `block in 
run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/hooks.rb:602:in 
`run_around_example_hooks_for'
     # /usr/lib/ruby/vendor_ruby/rspec/core/hooks.rb:464:in `run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:457:in 
`with_around_example_hooks'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:500:in 
`with_around_and_singleton_context_hooks'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:251:in `run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example_group.rb:629:in 
`block in run_examples'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example_group.rb:625:in 
`map'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example_group.rb:625:in 
`run_examples'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example_group.rb:591:in 
`run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example_group.rb:592:in 
`block in run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example_group.rb:592:in 
`map'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example_group.rb:592:in 
`run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:116:in `block (3 
levels) in run_specs'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:116:in `map'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:116:in `block (2 
levels) in run_specs'
     # /usr/lib/ruby/vendor_ruby/rspec/core/configuration.rb:1989:in 
`with_suite_hooks'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:111:in `block in 
run_specs'
     # /usr/lib/ruby/vendor_ruby/rspec/core/reporter.rb:74:in `report'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:110:in `run_specs'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:87:in `run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:71:in `run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:45:in `invoke'
     # /usr/bin/rspec:4:in `<main>'

  4) SortedSetsMethods should add a member to a sorted set, or update 
its score if it already exists
     Failure/Error: expect(@client.zscore("key2", "val")).to 
eq(Infinity)

     ArgumentError:
       invalid value for Float(): "Infinity"
     # 
/usr/share/rubygems-integration/all/gems/redis-4.1.2/lib/redis.rb:3357:in 
`Float'
     # 
/usr/share/rubygems-integration/all/gems/redis-4.1.2/lib/redis.rb:3357:in 
`block in <class:Redis>'
     # 
/usr/share/rubygems-integration/all/gems/redis-4.1.2/lib/redis/client.rb:129:in 
`call'
     # 
/usr/share/rubygems-integration/all/gems/redis-4.1.2/lib/redis.rb:1732:in 
`block in zscore'
     # 
/usr/share/rubygems-integration/all/gems/redis-4.1.2/lib/redis.rb:52:in 
`block in synchronize'
     # /usr/lib/ruby/2.5.0/monitor.rb:235:in `mon_synchronize'
     # 
/usr/share/rubygems-integration/all/gems/redis-4.1.2/lib/redis.rb:52:in 
`synchronize'
     # 
/usr/share/rubygems-integration/all/gems/redis-4.1.2/lib/redis.rb:1731:in 
`zscore'
     # ./spec/sorted_sets_spec.rb:20:in `block (2 levels) in 
<module:FakeRedis>'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:254:in 
`instance_exec'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:254:in `block in 
run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:500:in `block in 
with_around_and_singleton_context_hooks'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:457:in `block in 
with_around_example_hooks'
     # /usr/lib/ruby/vendor_ruby/rspec/core/hooks.rb:464:in `block in 
run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/hooks.rb:602:in 
`run_around_example_hooks_for'
     # /usr/lib/ruby/vendor_ruby/rspec/core/hooks.rb:464:in `run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:457:in 
`with_around_example_hooks'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:500:in 
`with_around_and_singleton_context_hooks'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:251:in `run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example_group.rb:629:in 
`block in run_examples'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example_group.rb:625:in 
`map'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example_group.rb:625:in 
`run_examples'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example_group.rb:591:in 
`run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:116:in `block (3 
levels) in run_specs'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:116:in `map'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:116:in `block (2 
levels) in run_specs'
     # /usr/lib/ruby/vendor_ruby/rspec/core/configuration.rb:1989:in 
`with_suite_hooks'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:111:in `block in 
run_specs'
     # /usr/lib/ruby/vendor_ruby/rspec/core/reporter.rb:74:in `report'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:110:in `run_specs'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:87:in `run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:71:in `run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:45:in `invoke'
     # /usr/bin/rspec:4:in `<main>'

  5) SortedSetsMethods should handle infinity values when incrementing 
a sorted set key
     Failure/Error: expect(@client.zincrby("bar", "+inf", "s2")).to 
eq(Infinity)

     ArgumentError:
       invalid value for Float(): "Infinity"
     # 
/usr/share/rubygems-integration/all/gems/redis-4.1.2/lib/redis.rb:3357:in 
`Float'
     # 
/usr/share/rubygems-integration/all/gems/redis-4.1.2/lib/redis.rb:3357:in 
`block in <class:Redis>'
     # 
/usr/share/rubygems-integration/all/gems/redis-4.1.2/lib/redis/client.rb:129:in 
`call'
     # 
/usr/share/rubygems-integration/all/gems/redis-4.1.2/lib/redis.rb:1602:in 
`block in zincrby'
     # 
/usr/share/rubygems-integration/all/gems/redis-4.1.2/lib/redis.rb:52:in 
`block in synchronize'
     # /usr/lib/ruby/2.5.0/monitor.rb:235:in `mon_synchronize'
     # 
/usr/share/rubygems-integration/all/gems/redis-4.1.2/lib/redis.rb:52:in 
`synchronize'
     # 
/usr/share/rubygems-integration/all/gems/redis-4.1.2/lib/redis.rb:1601:in 
`zincrby'
     # ./spec/sorted_sets_spec.rb:139:in `block (2 levels) in 
<module:FakeRedis>'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:254:in 
`instance_exec'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:254:in `block in 
run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:500:in `block in 
with_around_and_singleton_context_hooks'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:457:in `block in 
with_around_example_hooks'
     # /usr/lib/ruby/vendor_ruby/rspec/core/hooks.rb:464:in `block in 
run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/hooks.rb:602:in 
`run_around_example_hooks_for'
     # /usr/lib/ruby/vendor_ruby/rspec/core/hooks.rb:464:in `run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:457:in 
`with_around_example_hooks'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:500:in 
`with_around_and_singleton_context_hooks'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example.rb:251:in `run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example_group.rb:629:in 
`block in run_examples'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example_group.rb:625:in 
`map'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example_group.rb:625:in 
`run_examples'
     # /usr/lib/ruby/vendor_ruby/rspec/core/example_group.rb:591:in 
`run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:116:in `block (3 
levels) in run_specs'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:116:in `map'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:116:in `block (2 
levels) in run_specs'
     # /usr/lib/ruby/vendor_ruby/rspec/core/configuration.rb:1989:in 
`with_suite_hooks'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:111:in `block in 
run_specs'
     # /usr/lib/ruby/vendor_ruby/rspec/core/reporter.rb:74:in `report'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:110:in `run_specs'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:87:in `run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:71:in `run'
     # /usr/lib/ruby/vendor_ruby/rspec/core/runner.rb:45:in `invoke'
     # /usr/bin/rspec:4:in `<main>'

Finished in 0.28633 seconds (files took 0.22608 seconds to load)
399 examples, 5 failures, 1 pending

Failed examples:

rspec ./spec/keys_spec.rb:375 # KeysMethods with extended options uses 
nx option to only set the key if it does not already exist
rspec ./spec/keys_spec.rb:382 # KeysMethods with extended options uses 
xx option to only set the key if it already exists
rspec ./spec/keys_spec.rb:390 # KeysMethods with extended options does 
not set the key if both xx and nx option are specified
rspec ./spec/sorted_sets_spec.rb:11 # SortedSetsMethods should add a 
member to a sorted set, or update its score if it already exists
rspec ./spec/sorted_sets_spec.rb:138 # SortedSetsMethods should handle 
infinity values when incrementing a sorted set key

/usr/bin/ruby2.5 /usr/bin/rspec --pattern ./spec/\*_spec.rb failed
ERROR: Test "ruby2.5" failed. Exi