[DRE-maint] Bug#891743: ruby-influxdb: FTBFS with ruby2.5: Failed examples: rspec ./spec/influxdb/client_spec.rb:47 # InfluxDB::Client#full_url escapes params

[Daniel Leidert]

Package: src:ruby-influxdb
Followup-For: Bug #891743

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Upstream fixed this. The relevant patch is attached. However there seem to be
more issues now:

The error is always the same:

     Failure/Error: parsed_response = JSON.parse(response.body)
     
     JSON::ParserError:
       783: unexpected token at ''

[..]
Finished in 1.19 seconds (files took 0.50163 seconds to load)
149 examples, 10 failures

Failed examples:

rspec ./spec/influxdb/cases/query_cluster_spec.rb:32 # InfluxDB::Client#create_cluster_admin with existing admin user should GET to create a new cluster admin
rspec ./spec/influxdb/cases/query_cluster_spec.rb:46 # InfluxDB::Client#create_cluster_admin with no admin user should GET to create a new cluster admin
rspec ./spec/influxdb/cases/query_cluster_spec.rb:80 # InfluxDB::Client#revoke_cluster_admin_privileges should GET to revoke cluster admin privileges from a user
rspec ./spec/influxdb/cases/query_continuous_query_spec.rb:74 # InfluxDB::Client#create_continuous_query without resampling should GET to create a new continuous query
rspec ./spec/influxdb/cases/query_continuous_query_spec.rb:83 # InfluxDB::Client#create_continuous_query with resampling EVERY <interval> should GET to create a new continuous query
rspec ./spec/influxdb/cases/query_continuous_query_spec.rb:91 # InfluxDB::Client#create_continuous_query with resampling FOR <interval> should GET to create a new continuous query
rspec ./spec/influxdb/cases/query_continuous_query_spec.rb:100 # InfluxDB::Client#create_continuous_query with resampling EVERY <interval> FOR <interval> should GET to create a new continuous query
rspec ./spec/influxdb/cases/query_continuous_query_spec.rb:117 # InfluxDB::Client#delete_continuous_query should GET to remove continuous query
rspec ./spec/influxdb/cases/query_series_spec.rb:65 # InfluxDB::Client#delete_series should GET to remove a database
rspec ./spec/influxdb/cases/query_user_spec.rb:120 # InfluxDB::Client#list_user_grants should GET for a user

Maybe it is best to start with the recent release 0.8.0?

Regards, Daniel

- -- System Information:
Debian Release: bullseye/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 5.3.0-3-amd64 (SMP w/8 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEvu1N7VVEpMA+KD3HS80FZ8KW0F0FAl5WfuwACgkQS80FZ8KW
0F1HBQ/6A6D0M0K+dTCaYloP+bhfbpaquRr629NwmQgK5K+NRFLC5CA8wcokjsdX
1Dt4uVGePo3T748pM0n9uABZL2NdNyVid1oXkGi1o3jshzId2bj+shHnMpHtttfs
j4pIDGAYCdpvnm2Ek2htuEaaEW1fXfEPU66Z3CBWJklji+oqRb1CMVPmQgxoezE1
Nf0UySGuTSSYaDvrF2MiXabEIL/Dgz6m7yIrQmDoGDSm/GfiAffIfLHreEUL588V
EPqWrpVdXKbjchV4wFZCIfwmn+fCkW8UmCIAAD97nER9gmqSavNfnWDL9dZZumdm
PYkNlvITyOEot+VGi4Pvu0fhu1k3lS5jeBcE8887e+Bh6TjidkMPSmajjgXkXy8e
PR/7c34l+RwDB5PaZ14oo54+hi8Ze5lZ3UhZfLlb+ivGFD22O9jMPnhiXRSRP6zx
oFjhtiyOTG9JBBNEkHZCG6127K6VNFHg57fqInK5juQRGqClZP1XMiPjjGBWpWAx
D5+Wj1f/0Zi91LIBH90VNRu6gpiyuWETJvV4T3J++Ks7jMzvpbhUINS3jVG1ks5y
3rPMM48comTAY6cjlYBpJ7DO0Ny5ad6r36RxAeIdRUyEXaIaOwVJ1+lt0g1JBe5t
C2CzU+pqDsojBNcVTTwd5eHeBLeUxmN0BSurs5N2t8Mj+KtpBk8=
=Fr0v
-----END PGP SIGNATURE-----
-------------- next part --------------
diff --git a/spec/influxdb/client_spec.rb b/spec/influxdb/client_spec.rb
index d1b0e52..3785e46 100644
--- a/spec/influxdb/client_spec.rb
+++ b/spec/influxdb/client_spec.rb
@@ -46,7 +46,9 @@ describe InfluxDB::Client do
 
     it "escapes params" do
       url = subject.send(:full_url, "/unknown", value: ' !@#$%^&*()/\\_+-=?|`~')
-      expect(url).to include("value=+%21%40%23%24%25%5E%26%2A%28%29%2F%5C_%2B-%3D%3F%7C%60%7E")
+      encoded_fragment = "value=+%21%40%23%24%25%5E%26%2A%28%29%2F%5C_%2B-%3D%3F%7C%60"
+      encoded_fragment << (RUBY_VERSION >= "2.5.0" ? "~" : "%7E")
+      expect(url).to include(encoded_fragment)
     end
 
     context "with prefix" do