[DRE-maint] Bug#925606: gitlab: Fail to upgrade (error with activesupport gem)

[Libor Klepáč]

Sorry,
it was because i was running it by hand for this email and did not set
RAILS_ENV

It fails with different error when I set RAILS_ENV to production

Libor

$ bundle exec rake db:migrate --trace
fatal: not a git repository (or any of the parent directories): .git
fatal: not a git repository (or any of the parent directories): .git
fatal: not a git repository (or any of the parent directories): .git
fatal: not a git repository (or any of the parent directories): .git
fatal: not a git repository (or any of the parent directories): .git
Attention: used pure ruby version of MurmurHash3
** Invoke db:migrate (first_time)
** Invoke db:load_config (first_time)
** Invoke environment (first_time)
** Execute environment
/usr/share/gitlab/lib/gitlab.rb:38: warning: already initialized
constant Gitlab::COM_URL
/usr/share/gitlab/lib/gitlab.rb:38: warning: previous definition of
COM_URL was here
/usr/share/gitlab/lib/gitlab.rb:39: warning: already initialized
constant Gitlab::APP_DIRS_PATTERN
/usr/share/gitlab/lib/gitlab.rb:39: warning: previous definition of
APP_DIRS_PATTERN was here
/usr/share/gitlab/lib/gitlab.rb:40: warning: already initialized
constant Gitlab::SUBDOMAIN_REGEX
/usr/share/gitlab/lib/gitlab.rb:40: warning: previous definition of
SUBDOMAIN_REGEX was here
/usr/share/gitlab/lib/gitlab.rb:41: warning: already initialized
constant Gitlab::VERSION
/usr/share/gitlab/lib/gitlab.rb:41: warning: previous definition of
VERSION was here
/usr/share/gitlab/lib/gitlab.rb:42: warning: already initialized
constant Gitlab::INSTALLATION_TYPE
/usr/share/gitlab/lib/gitlab.rb:42: warning: previous definition of
INSTALLATION_TYPE was here
/usr/share/gitlab/lib/gitlab.rb:43: warning: already initialized
constant Gitlab::HTTP_PROXY_ENV_VARS
/usr/share/gitlab/lib/gitlab.rb:43: warning: previous definition of
HTTP_PROXY_ENV_VARS was here
/usr/share/gitlab/config/initializers/2_app.rb:6: warning: already
initialized constant Gitlab::VERSION
/usr/share/gitlab/lib/gitlab.rb:41: warning: previous definition of
VERSION was here
rake aborted!
NoMethodError: undefined method `rails5?' for Gitlab:Module
/usr/share/gitlab/config/initializers/mysql_set_length_for_binary_index
es.rb:27:in `<top (required)>'
/usr/share/rubygems-integration/all/gems/activesupport-
5.2.3/lib/active_support/dependencies.rb:285:in `load'
/usr/share/rubygems-integration/all/gems/activesupport-
5.2.3/lib/active_support/dependencies.rb:285:in `block in load'
/usr/share/rubygems-integration/all/gems/activesupport-
5.2.3/lib/active_support/dependencies.rb:257:in `load_dependency'
/usr/share/rubygems-integration/all/gems/activesupport-
5.2.3/lib/active_support/dependencies.rb:285:in `load'
/usr/share/rubygems-integration/all/gems/railties-
5.2.3/lib/rails/engine.rb:657:in `block in load_config_initializer'
/usr/share/rubygems-integration/all/gems/activesupport-
5.2.3/lib/active_support/notifications.rb:170:in `instrument'
/usr/share/rubygems-integration/all/gems/railties-
5.2.3/lib/rails/engine.rb:656:in `load_config_initializer'
/usr/share/rubygems-integration/all/gems/railties-
5.2.3/lib/rails/engine.rb:614:in `block (2 levels) in <class:Engine>'
/usr/share/rubygems-integration/all/gems/railties-
5.2.3/lib/rails/engine.rb:613:in `each'
/usr/share/rubygems-integration/all/gems/railties-
5.2.3/lib/rails/engine.rb:613:in `block in <class:Engine>'
/usr/share/rubygems-integration/all/gems/railties-
5.2.3/lib/rails/initializable.rb:32:in `instance_exec'
/usr/share/rubygems-integration/all/gems/railties-
5.2.3/lib/rails/initializable.rb:32:in `run'
/usr/share/rubygems-integration/all/gems/railties-
5.2.3/lib/rails/initializable.rb:61:in `block in run_initializers'
/usr/lib/ruby/2.5.0/tsort.rb:228:in `block in tsort_each'
/usr/lib/ruby/2.5.0/tsort.rb:350:in `block (2 levels) in
each_strongly_connected_component'
/usr/lib/ruby/2.5.0/tsort.rb:422:in `block (2 levels) in
each_strongly_connected_component_from'
/usr/lib/ruby/2.5.0/tsort.rb:431:in
`each_strongly_connected_component_from'
/usr/lib/ruby/2.5.0/tsort.rb:421:in `block in
each_strongly_connected_component_from'
/usr/share/rubygems-integration/all/gems/railties-
5.2.3/lib/rails/initializable.rb:50:in `each'
/usr/share/rubygems-integration/all/gems/railties-
5.2.3/lib/rails/initializable.rb:50:in `tsort_each_child'
/usr/lib/ruby/2.5.0/tsort.rb:415:in `call'
/usr/lib/ruby/2.5.0/tsort.rb:415:in
`each_strongly_connected_component_from'
/usr/lib/ruby/2.5.0/tsort.rb:349:in `block in
each_strongly_connected_component'
/usr/lib/ruby/2.5.0/tsort.rb:347:in `each'
/usr/lib/ruby/2.5.0/tsort.rb:347:in `call'
/usr/lib/ruby/2.5.0/tsort.rb:347:in `each_strongly_connected_component'
/usr/lib/ruby/2.5.0/tsort.rb:226:in `tsort_each'
/usr/lib/ruby/2.5.0/tsort.rb:205:in `tsort_each'
/usr/share/rubygems-integration/all/gems/railties-
5.2.3/lib/rails/initializable.rb:60:in `run_initializers'
/usr/share/rubygems-integration/all/gems/railties-
5.2.3/lib/rails/application.rb:361:in `initialize!'
/usr/share/gitlab/config/environment.rb:6:in `<top (required)>'
/usr/share/rubygems-integration/all/gems/activesupport-
5.2.3/lib/active_support/dependencies.rb:291:in `require'
/usr/share/rubygems-integration/all/gems/activesupport-
5.2.3/lib/active_support/dependencies.rb:291:in `block in require'
/usr/share/rubygems-integration/all/gems/activesupport-
5.2.3/lib/active_support/dependencies.rb:257:in `load_dependency'
/usr/share/rubygems-integration/all/gems/activesupport-
5.2.3/lib/active_support/dependencies.rb:291:in `require'
/usr/share/rubygems-integration/all/gems/railties-
5.2.3/lib/rails/application.rb:337:in `require_environment!'
/usr/share/rubygems-integration/all/gems/railties-
5.2.3/lib/rails/application.rb:520:in `block in run_tasks_blocks'
/usr/lib/ruby/vendor_ruby/rake/task.rb:273:in `block in execute'
/usr/lib/ruby/vendor_ruby/rake/task.rb:273:in `each'
/usr/lib/ruby/vendor_ruby/rake/task.rb:273:in `execute'
/usr/lib/ruby/vendor_ruby/rake/task.rb:214:in `block in
invoke_with_call_chain'
/usr/lib/ruby/2.5.0/monitor.rb:235:in `mon_synchronize'
/usr/lib/ruby/vendor_ruby/rake/task.rb:194:in `invoke_with_call_chain'
/usr/lib/ruby/vendor_ruby/rake/task.rb:238:in `block in
invoke_prerequisites'
/usr/lib/ruby/vendor_ruby/rake/task.rb:236:in `each'
/usr/lib/ruby/vendor_ruby/rake/task.rb:236:in `invoke_prerequisites'
/usr/lib/ruby/vendor_ruby/rake/task.rb:213:in `block in
invoke_with_call_chain'
/usr/lib/ruby/2.5.0/monitor.rb:235:in `mon_synchronize'
/usr/lib/ruby/vendor_ruby/rake/task.rb:194:in `invoke_with_call_chain'
/usr/lib/ruby/vendor_ruby/rake/task.rb:238:in `block in
invoke_prerequisites'
/usr/lib/ruby/vendor_ruby/rake/task.rb:236:in `each'
/usr/lib/ruby/vendor_ruby/rake/task.rb:236:in `invoke_prerequisites'
/usr/lib/ruby/vendor_ruby/rake/task.rb:213:in `block in
invoke_with_call_chain'
/usr/lib/ruby/2.5.0/monitor.rb:235:in `mon_synchronize'
/usr/lib/ruby/vendor_ruby/rake/task.rb:194:in `invoke_with_call_chain'
/usr/lib/ruby/vendor_ruby/rake/task.rb:183:in `invoke'
/usr/lib/ruby/vendor_ruby/rake/application.rb:160:in `invoke_task'
/usr/lib/ruby/vendor_ruby/rake/application.rb:116:in `block (2 levels)
in top_level'
/usr/lib/ruby/vendor_ruby/rake/application.rb:116:in `each'
/usr/lib/ruby/vendor_ruby/rake/application.rb:116:in `block in
top_level'
/usr/lib/ruby/vendor_ruby/rake/application.rb:125:in `run_with_threads'
/usr/lib/ruby/vendor_ruby/rake/application.rb:110:in `top_level'
/usr/lib/ruby/vendor_ruby/rake/application.rb:83:in `block in run'
/usr/lib/ruby/vendor_ruby/rake/application.rb:186:in
`standard_exception_handling'
/usr/lib/ruby/vendor_ruby/rake/application.rb:80:in `run'
/usr/bin/rake:27:in `<main>'
Tasks: TOP => db:migrate => db:load_config => environment