[DRE-maint] Bug#976165: ruby-vcr: ftbfs with ruby-faraday 1.x in experimental

[Pirate Praveen]

Package: ruby-vcr
Version: 5.1.0-2
Severity: important

Hi,

ruby-faraday 1.x was in experimental for a long time and this is the 
last package blocking an upload to unstable. Upstream already supports 
faraday 1.0 with version 6.0.0

Please update to latest upstream or backport the faraday 1.0 patch so 
we can upload ruby-faraday 1.0 to unstable.

Test failure is,

Failures:

  1) Faraday hook inserts the VCR middleware just before the adapter
     Failure/Error:
       expect(conn.builder.handlers.last(2).map(&:klass)).to eq([
         VCR::Middleware::Faraday,
         Faraday::Adapter::NetHttp
       ])

       expected: [VCR::Middleware::Faraday, Faraday::Adapter::NetHttp]
            got: [Faraday::Response::Logger, VCR::Middleware::Faraday]

       (compared using ==)

       Diff:
       @@ -1 +1 @@
       -[VCR::Middleware::Faraday, Faraday::Adapter::NetHttp]
       +[Faraday::Response::Logger, VCR::Middleware::Faraday]
     # ./spec/lib/vcr/library_hooks/faraday_spec.rb:13:in `block (2 
levels) in <top (required)>'

  2) Faraday hook handles the case where no adapter is declared
     Failure/Error:
       expect(conn.builder.handlers.last(2).map(&:klass)).to eq([
         VCR::Middleware::Faraday,
         Faraday::Adapter::NetHttp
       ])

       expected: [VCR::Middleware::Faraday, Faraday::Adapter::NetHttp]
            got: [Faraday::Request::UrlEncoded, 
VCR::Middleware::Faraday]

       (compared using ==)

       Diff:
       @@ -1 +1 @@
       -[VCR::Middleware::Faraday, Faraday::Adapter::NetHttp]
       +[Faraday::Request::UrlEncoded, VCR::Middleware::Faraday]
     # ./spec/lib/vcr/library_hooks/faraday_spec.rb:23:in `block (2 
levels) in <top (required)>'

  3) Faraday hook does nothing if the VCR middleware has already been 
included
     Failure/Error: builder.use Faraday::Adapter::NetHttp

     RuntimeError:
       Adapter should be set using the `adapter` method, not `use`
     # ./spec/lib/vcr/library_hooks/faraday_spec.rb:33:in `block (3 
levels) in <top (required)>'
     # ./spec/lib/vcr/library_hooks/faraday_spec.rb:30:in `block (2 
levels) in <top (required)>'

  4) Faraday hook prints a warning if the faraday connection stack 
contains a middleware after the HTTP adapter
     Failure/Error: builder.use Faraday::Adapter::NetHttp

     RuntimeError:
       Adapter should be set using the `adapter` method, not `use`
     # ./spec/lib/vcr/library_hooks/faraday_spec.rb:46:in `block (3 
levels) in <top (required)>'
     # ./spec/lib/vcr/library_hooks/faraday_spec.rb:45:in `block (2 
levels) in <top (required)>'

Finished in 14.1 seconds (files took 1.24 seconds to load)
1739 examples, 4 failures, 1 pending

Failed examples:

rspec ./spec/lib/vcr/library_hooks/faraday_spec.rb:5 # Faraday hook 
inserts the VCR middleware just before the adapter
rspec ./spec/lib/vcr/library_hooks/faraday_spec.rb:19 # Faraday hook 
handles the case where no adapter is declared
rspec ./spec/lib/vcr/library_hooks/faraday_spec.rb:29 # Faraday hook 
does nothing if the VCR middleware has already been included
rspec ./spec/lib/vcr/library_hooks/faraday_spec.rb:44 # Faraday hook 
prints a warning if the faraday connection stack contains a middleware 
after the HTTP adapter

Full log is attached

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ruby-vcr.log
Type: text/x-log
Size: 258212 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-ruby-extras-maintainers/attachments/20201201/eda84310/attachment-0001.bin>