[DRE-maint] Bug#969738: ruby-asciidoctor-pdf: relax version constraint on ruby-prawn (2.3.0 in experimental)
Keith Packard
keithp at keithp.com
Mon Sep 7 20:17:18 BST 2020
Cédric Boutillier <boutil at debian.org> writes:
> Source: ruby-asciidoctor-pdf
> Version: 1.5.3-1
> Severity: important
>
> Dear Keith,
>
> I have just uploaded ruby-prawn 2.3.0-1~exp1 to experimental.
> The package ruby-asciidoctor-pdf does not accept versions of ruby-prawn
> higher than 2.2.x in debian control file and in the gemspec.
>
> Please relax this constraint and test against the package in
> experimental.
>
> I also saw that there is a comment in the gemspec about the fact that
> ttfunk 1.6 may cause problems with asciidoctor-pdf. Note that I already
> uploaded ttfunk 1.6 to unstable. Possible issues were unnoticed because
> of the lack of explicit dependency. I hope this is fixable, as prawn 2.3
> require ttfunk 1.6.
I changed the dependencies as follows:
s.add_runtime_dependency 'asciidoctor', '>= 1.5.3', '< 3.0.0'
- s.add_runtime_dependency 'prawn', '~> 2.2.0'
+ s.add_runtime_dependency 'prawn', '~> 2.3.0'
# NOTE ttfunk 1.6 generates TT instructions ghostscript cannot process, so lock the version of ttfunk
- s.add_runtime_dependency 'ttfunk', ['~> 1.5.0'], ['>= 1.5.1']
+ s.add_runtime_dependency 'ttfunk', ['~> 1.5'], ['>= 1.5.1']
# NOTE must use prawn-table from master branch (defined in Gemfile) for full functionality
s.add_runtime_dependency 'prawn-table', '~> 0.2.0'
# s.add_runtime_dependency 'prawn-templates', '~> 0.1.0'
Running the asciidoctor-pdf test suite , I'm getting a bunch of new
regressions, but all of the new errors are just integer-vs-float
changes:
expected: 12.0
got: 12
Otherwise, looks good. If this seems reasonable, I'll go ahead and
adjust the debian dependencies to match and get it packaged up.
We still don't have a prawn-templates package, so I'm still disabling
embedded PDF images. Last time I tried to package this, it was still
modifying the 'prawn' code as a part of this package, which seems
inappropriate for a Debian package.
Thanks for your help with this stuff!
--
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-ruby-extras-maintainers/attachments/20200907/f4c9a215/attachment-0001.sig>
More information about the Pkg-ruby-extras-maintainers
mailing list