[DRE-maint] Bug#989791: gitlab: Some views broken by Rails 6.0.3.7 upgrade

Antoine Le Gonidec debian.bugs at dotslashplay.it
Sun Jun 13 10:49:12 BST 2021


Package: gitlab
Version: 13.11.5+ds1-1~fto10+1
Severity: important

Since Rails 6.0.3.6 → Rails 6.0.3.7 upgrade, some views fail to load
with internal errors similar to this one:

ActionView::Template::Error (Please use symbols for polymorphic route arguments.):                          
    18:       %span.issuable-number= issuable.to_reference                                                                                                    
    19:                                                                                                                                                       
    20:     - labels.each do |label|                                                                                                                          
    21:       = render_label(label.present(issuable_subject: project), link: polymorphic_path(issuable_type_args, { milestone_title: @milestone.title, label_na
me: label.title, state: 'all' }), small: true)                                                                                                                
    22:                                                                                                                                                       
    23:     %span.assignee-icon                                                                                                                               
    24:       - assignees.each do |assignee|                                                                                                                  

This is due to the following upstream change to polymorphic routes:
https://github.com/rails/rails/commit/c4c21a9f8d7c9c8ca6570bdb82d64e2dc860e62c

GitLab has been patched 2 weeks ago, but I think it would be worth to
backport this fix.

I am going to answer to this report with a suggested patch.

-- System Information:
Debian Release: 10.9
  APT prefers stable
  APT policy: (500, 'stable'), (100, 'buster-fasttrack'), (100, 'buster-backports')
Architecture: amd64 (x86_64)

Kernel: Linux 5.10.0-7-amd64 (SMP w/8 CPU cores)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=C.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages gitlab depends on:
ii  asciidoctor                     2.0.10-2~bpo10+1
ii  bc                              1.07.1-2+b1
ii  bundler                         1.17.3-3+deb10u1
ii  bzip2                           1.0.6-9.2~deb10u1
ii  dbconfig-pgsql                  2.0.11+deb10u1
ii  debconf [debconf-2.0]           1.5.71
ii  fonts-font-awesome [node-font-  5.0.10+really4.7.0~dfsg-4~bpo10+1
ii  gitlab-common                   13.11.2+dfsg-2~fto10+1
ii  gitlab-workhorse                13.11.5+ds1-1~fto10+1
ii  katex [node-katex]              0.10.2+dfsg-8~bpo10+1
ii  libjs-bootstrap4 [node-bootstr  4.3.1+dfsg2-1
ii  libjs-codemirror [node-codemir  5.54.0-2~bpo10+1
ii  libjs-pdf [node-pdfjs-dist]     2.6.347+dfsg-3~bpo10+1
ii  libjs-popper.js [node-popper.j  1.16.1+ds-2~bpo10+1
ii  libruby2.7 [ruby-rexml]         2.7.3-2~fto10+1
ii  lsb-base                        10.2019051400
ii  nginx                           1.14.2-2+deb10u4
ii  nginx-full [nginx]              1.14.2-2+deb10u4
ii  node-autosize                   4.0.2~dfsg1-5~bpo10+1
ii  node-axios                      0.17.1+dfsg-2
ii  node-babel-loader               8.2.2-1~bpo10+1
ii  node-babel-plugin-lodash        3.3.4+~cs2.0.1-3~bpo10+1
ii  node-babel7                     7.12.12+~cs150.141.84-2~bpo10+1
ii  node-brace-expansion            1.1.8-1
ii  node-cache-loader               4.1.0-6~bpo10+1
ii  node-chart.js                   2.7.3+dfsg-5
ii  node-clipboard                  2.0.6+ds-1~bpo10+1
ii  node-compression-webpack-plugi  3.0.1-4~bpo10+1
ii  node-copy-webpack-plugin        5.1.2+~cs9.0.2-4~bpo10+1
ii  node-core-js                    3.6.1-2~bpo10+2
ii  node-css-loader                 5.0.1+~cs14.0.5-1~bpo10+1
ii  node-d3                         5.16.0-1~bpo10+1
ii  node-d3-scale                   2.2.2-2~bpo10+1
ii  node-d3-selection               1.4.0-3~bpo10+1
ii  node-dateformat                 3.0.0-1
ii  node-exports-loader             0.7.0-2~bpo10+1
ii  node-file-loader                6.2.0-2~bpo10+1
ii  node-fuzzaldrin-plus            0.5.0+dfsg-1
ii  node-glob                       7.1.6-1~bpo10+1
ii  node-imports-loader             0.8.0-2~bpo10+1
ii  node-jed                        1.1.1-2~bpo10+1
ii  node-jquery                     3.5.1+dfsg-4~bpo10+1
ii  node-jquery-ujs                 1.2.2-2
ii  node-js-cookie                  2.2.0-2
ii  node-js-yaml                    3.13.1+dfsg-2~bpo10+1
ii  node-jszip                      3.2.2+dfsg-1~bpo10+1
ii  node-jszip-utils                0.0.2+dfsg-2~bpo10+1
ii  node-lodash                     4.17.21+dfsg+~cs8.31.189.20210220-1~bpo10+1
ii  node-marked                     0.5.1+dfsg-1
ii  node-mermaid                    8.9.3+ds+~cs29.13.19-1~bpo10+1
ii  node-minimatch                  3.0.4-3
ii  node-mousetrap                  1.6.1+ds-1
ii  node-prismjs                    1.11.0+dfsg-3~bpo10+1
ii  node-prosemirror-markdown       1.5.1-1~bpo10+1
ii  node-prosemirror-model          1.14.0-1~bpo10+1
ii  node-raven-js                   3.22.1+dfsg-2
ii  node-raw-loader                 4.0.2-2~bpo10+1
ii  node-style-loader               2.0.0-2~bpo10+1
ii  node-three-orbit-controls       82.1.0-3~bpo10+1
ii  node-three-stl-loader           1.0.6-3~bpo10+1
ii  node-timeago.js                 4.0.2-2~bpo10+1
ii  node-underscore                 1.9.1~dfsg-1+deb10u1
ii  node-url-loader                 4.1.1-3~bpo10+1
ii  node-uuid                       8.3.2+~8.3.0-1~bpo10+1
ii  node-vue [node-vue-template-co  2.6.12+dfsg-1~bpo10+1
ii  node-vue-resource               1.5.1+dfsg-3~bpo10+1
ii  node-webpack-stats-plugin       0.2.1-1
ii  node-worker-loader              3.0.5-2~bpo10+1
ii  node-xterm                      3.8.1-4~bpo10+1
ii  nodejs                          10.24.0~dfsg-1~deb10u1
ii  nullmailer [mail-transport-age  1:2.2-3
ii  ohai                            16.13.0-2~fto10+1
ii  openssh-client                  1:7.9p1-10+deb10u2
ii  postgresql-client               11+200+deb10u4
ii  postgresql-client-11 [postgres  11.12-0+deb10u1
ii  postgresql-contrib              11+200+deb10u4
ii  puma                            5.3.2-1~fto10+1
ii  rake                            13.0.1-4~bpo10+1
ii  redis-server                    5:6.0.12-1~bpo10+1
ii  ruby-ace-rails-ap               4.1.1-1
ii  ruby-acme-client                2.0.6-1~bpo10+1
ii  ruby-actioncable [node-rails-a  2:6.0.3.7+dfsg-1~fto10+1
ii  ruby-activerecord-explain-anal  0.1.0-2~bpo10+1
ii  ruby-acts-as-taggable-on        7.0.0-1~bpo10+1
ii  ruby-addressable                2.7.0-1~bpo10+1
ii  ruby-akismet                    3.0.0-1~bpo10+1
ii  ruby-apollo-upload-server       2.0.3-1~bpo10+1
ii  ruby-asana                      0.10.3-1~bpo10+1
ii  ruby-asciidoctor-include-ext    0.3.1-2~bpo10+1
ii  ruby-asciidoctor-kroki          0.4.0-1~bpo10+1
ii  ruby-asciidoctor-plantuml       0.0.12-1~bpo10+1
ii  ruby-attr-encrypted             3.1.0-3~bpo10+1
ii  ruby-autoprefixer-rails         10.2.4.0+dfsg1+~cs14.2.17-1
ii  ruby-aws-sdk-cloudformation     1.41.0-2~bpo10+1
ii  ruby-aws-sdk-core               3.104.3-3~bpo10+1
ii  ruby-aws-sdk-s3                 1.48.0-3~bpo10+1
ii  ruby-azure-storage-blob         2.0.0-3~bpo10+1
ii  ruby-azure-storage-common       2.0.1-5~bpo10+1
ii  ruby-babosa                     1.0.3-1~bpo10+1
ii  ruby-base32                     0.3.2-3
ii  ruby-batch-loader               2.0.1+dfsg-1~bpo10+1
ii  ruby-bcrypt                     3.1.16-1~fto10+1
ii  ruby-bcrypt-pbkdf               1.0.1-1+fto10+1
ii  ruby-benchmark-memory           0.1.2-2~bpo10+1
ii  ruby-bootsnap                   1.4.6-1+fto10+2
ii  ruby-bootstrap-form             4.2.0-2~bpo10+1
ii  ruby-browser                    4.2.0-3~bpo10+1
ii  ruby-carrierwave                1.3.2-2~bpo10+1
ii  ruby-charlock-holmes            0.7.7-1~fto10+3
ii  ruby-chronic [ruby-gitlab-chro  0.10.5-2~bpo10+1
ii  ruby-chronic-duration [ruby-gi  0.10.6.2-2~bpo10+1
ii  ruby-commonmarker               0.21.0-1~fto10+1
ii  ruby-connection-pool            2.2.2-1
ii  ruby-countries                  3.0.0-2~bpo10+1
ii  ruby-creole                     0.5.0-2
ii  ruby-default-value-for          3.4.0-1~bpo10+1
ii  ruby-derailed-benchmarks        1.7.0-2~bpo10+1
ii  ruby-device-detector            1.0.1-2
ii  ruby-devise                     4.7.3-1~bpo10+1
ii  ruby-devise-two-factor          4.0.0-1~bpo10+1
ii  ruby-diff-match-patch           0.1.0-2~bpo10+1
ii  ruby-diffy                      3.3.0-1~bpo10+1
ii  ruby-discordrb-webhooks         3.4.2-1~bpo10+1
ii  ruby-doorkeeper                 5.5.0-1~bpo10+1
ii  ruby-doorkeeper-openid-connect  1.7.5-2~bpo10+1
ii  ruby-ed25519                    1.2.4-1+fto10+1
ii  ruby-elasticsearch              6.8.2-2~bpo10+1
ii  ruby-elasticsearch-api          6.8.2-2~bpo10+1
ii  ruby-email-reply-trimmer        0.1.6-1
ii  ruby-erubi                      1.9.0-1~bpo10+1
ii  ruby-escape-utils               1.2.1-1+fto10+1
ii  ruby-excon                      0.72.0-2~bpo10+1
ii  ruby-faraday                    1.1.0-6~bpo10+1
ii  ruby-faraday-middleware-aws-si  0.3.0-2~bpo10+1
ii  ruby-fast-blank                 1.0.0-1+fto10+1
ii  ruby-flipper [ruby-flipper-act  0.17.1-4~bpo10+1
pn  ruby-flipper-active-record      <none>
ii  ruby-flowdock                   0.7.1-1
ii  ruby-fog-aliyun                 0.3.2-3~bpo10+1
ii  ruby-fog-aws                    3.9.0-1~bpo10+1
ii  ruby-fog-core                   2.1.0-3
ii  ruby-fog-google                 1.13.0-1~fto10+1
ii  ruby-fog-local                  0.6.0-1
ii  ruby-fog-openstack              1.0.8-2
ii  ruby-fog-rackspace              0.1.6-2
ii  ruby-fogbugz                    0.2.1-3
ii  ruby-fugit                      1.3.3+gh-1~bpo10+1
ii  ruby-gemojione                  3.3.0-1
ii  ruby-gettext                    3.3.3-2~bpo10+1
ii  ruby-gettext-i18n-rails         1.8.0-1
ii  ruby-gettext-i18n-rails-js      1.3.0+dfsg-2
ii  ruby-gitaly                     13.11.2+dfsg-2~fto10+1
ii  ruby-github-markup              1.7.0+dfsg-2
ii  ruby-gitlab-experiment          0.5.3-1~fto10+1
ii  ruby-gitlab-fog-azure-rm        1.0.1-1~bpo10+1
ii  ruby-gitlab-labkit              0.16.2-1~fto10+1
ii  ruby-gitlab-sidekiq-fetcher     0.6.1-1~bpo10+1
ii  ruby-gon                        6.4.0-1~bpo10+1
ii  ruby-google-api-client          0.50.0-1~fto10+2
ii  ruby-google-protobuf            3.14.0-1~fto10+1
ii  ruby-gpgme                      2.0.19-3+fto10+1
ii  ruby-grape                      1.5.2-1~bpo10+1
ii  ruby-grape-entity               0.8.0-1~bpo10+1
ii  ruby-grape-logging              1.7.0-1
ii  ruby-grape-path-helpers         1.6.1-1~fto10+1
ii  ruby-graphiql-rails             1.4.10-1
ii  ruby-graphlient                 0.5.0-3~bpo10+1
ii  ruby-graphql                    1.11.8-1~bpo10+1
ii  ruby-hamlit                     2.15.0-1~fto10+1
ii  ruby-hangouts-chat              0.0.5-2
ii  ruby-hashie-forbidden-attribut  0.1.1-1
ii  ruby-health-check               3.0.0-1~bpo10+1
ii  ruby-html-pipeline              2.14.0-1~bpo10+1
ii  ruby-html2text                  0.2.0-1
ii  ruby-http                       4.4.1-4~bpo10+1
ii  ruby-httparty                   0.17.0-1~bpo10+1
ii  ruby-icalendar                  2.4.1-2
ii  ruby-invisible-captcha          1.1.0-1~fto10+1
ii  ruby-jira                       2.1.5-1~bpo10+1
ii  ruby-js-regex                   3.4.0-1+fto10+1
pn  ruby-json                       <none>
ii  ruby-json-schema                2.8.1-2~bpo10+1
ii  ruby-json-schemer               0.2.13-2~bpo10+1
ii  ruby-jwt                        2.1.0-2~bpo10+1
ii  ruby-kaminari                   1.2.1-1~bpo10+1
ii  ruby-kramdown                   2.3.1-1~fto10+1
ii  ruby-kubeclient                 4.9.1-2~bpo10+1
ii  ruby-licensee                   9.14.1-2~bpo10+1
ii  ruby-lockbox                    0.6.4-1~bpo10+1
ii  ruby-lograge                    0.10.0-1
ii  ruby-loofah                     2.4.0+dfsg-1~bpo10+1
ii  ruby-lru-redux                  1.1.0-2~bpo10+1
ii  ruby-mail                       2.7.1+dfsg1-1
ii  ruby-mail-room                  0.10.0+really0.0.9-1~bpo10+1
ii  ruby-marginalia                 1.10.1-1~bpo10+1
ii  ruby-memory-profiler            0.9.14-2~bpo10+1
ii  ruby-method-source              1.0.0-1~bpo10+1
ii  ruby-mini-magick                4.10.1-1~bpo10+1
ii  ruby-multi-json                 1.14.1-1~bpo10+1
ii  ruby-net-dns [ruby-gitlab-net-  0.9.1-2~bpo10+1
ii  ruby-net-ldap                   0.16.3-1~bpo10+1
ii  ruby-net-ntp                    2.1.3-2~bpo10+1
ii  ruby-net-ssh                    1:6.0.2-2~bpo10+1
ii  ruby-nokogiri                   1.11.1+dfsg-2~fto10+1
ii  ruby-ntlm                       0.6.1-2
ii  ruby-oauth2                     1.4.4-1~bpo10+1
ii  ruby-octokit                    4.17.0-2~bpo10+1
ii  ruby-oj                         3.10.8-1+fto10+1
ii  ruby-omniauth                   1.9.1-1~bpo10+1
ii  ruby-omniauth-atlassian-oauth2  0.2.0-2~bpo10+1
ii  ruby-omniauth-auth0             2.0.0-1
ii  ruby-omniauth-authentiq         0.3.3-1
ii  ruby-omniauth-azure-activedire  1.0.0-1~bpo10+1
ii  ruby-omniauth-azure-oauth2      0.0.10-1~bpo10+1
ii  ruby-omniauth-cas3              1.1.4-2
ii  ruby-omniauth-crowd             2.4.0-1
ii  ruby-omniauth-facebook          4.0.0-2
ii  ruby-omniauth-github            1.4.0-1~bpo10+1
ii  ruby-omniauth-gitlab            1.0.2-1
ii  ruby-omniauth-google-oauth2     0.6.0-2~bpo10+1
ii  ruby-omniauth-kerberos          0.3.0-3
ii  ruby-omniauth-ldap              2.1.1-1~bpo10+1
ii  ruby-omniauth-oauth2-generic    0.2.2-1
ii  ruby-omniauth-openid-connect    0.3.5-1~bpo10+1
ii  ruby-omniauth-salesforce        1.0.5-2~bpo10+1
ii  ruby-omniauth-saml              1.10.0-1
ii  ruby-omniauth-shibboleth        1.3.0-1
ii  ruby-omniauth-twitter           1.4.0-1
ii  ruby-org                        0.9.12-2
ii  ruby-parslet                    1.8.2-2
ii  ruby-peek                       1.1.0-1~bpo10+1
ii  ruby-pg                         1.2.3-1+fto10+1
ii  ruby-pg-query                   1.3.0-1~fto10+1
ii  ruby-posix-spawn                0.3.13-2+fto10+1
ii  ruby-premailer-rails            1.10.3-2~bpo10+1
ii  ruby-prof                       1.3.1-2+fto10+1
ii  ruby-progressbar                1.10.1-1~bpo10+1
ii  ruby-prometheus-client-mmap     0.12.0-1~fto10+1
ii  ruby-puma-worker-killer         0.3.1-1~fto10+1
ii  ruby-rack                       2.2.3-1~bpo10+1
ii  ruby-rack-attack                6.3.1-1~bpo10+1
ii  ruby-rack-cors                  1.1.1-1~bpo10+1
ii  ruby-rack-oauth2                1.16.0-1~bpo10+1
ii  ruby-rack-proxy                 0.6.1-2
ii  ruby-rack-timeout               0.5.1-1~bpo10+1
ii  ruby-rails                      2:6.0.3.7+dfsg-1~fto10+1
ii  ruby-rails-i18n                 6.0.0-2~bpo10+1
ii  ruby-rainbow                    3.0.0-2
ii  ruby-raindrops                  0.19.0-1+fto10+1
ii  ruby-rbtrace                    0.4.11-3+fto10+1
ii  ruby-re2                        1.2.0-1+fto10+1
ii  ruby-recaptcha                  4.11.1-2
ii  ruby-recursive-open-struct      1.1.1-1~bpo10+1
ii  ruby-redcloth                   4.3.2-3+fto10+1
ii  ruby-redis                      4.1.2-4~bpo10+1
ii  ruby-redis-actionpack           5.2.0-2~bpo10+1
ii  ruby-redis-activesupport        5.2.0-1~bpo10+1
ii  ruby-redis-namespace            1.7.0-2~bpo10+1
ii  ruby-redis-rails                5.0.2-3
ii  ruby-request-store              1.5.0-2~bpo10+1
ii  ruby-responders                 3.0.0-3~bpo10+1
ii  ruby-retriable                  3.1.2-1~bpo10+1
ii  ruby-rouge                      3.21.0-1~bpo10+1
ii  ruby-rqrcode-rails3             0.1.7-1
ii  ruby-ruby-magic-static [ruby-r  0.4.0-3~fto10+1
ii  ruby-ruby-parser                3.15.1-1~bpo10+1
ii  ruby-rugged                     1.1.0+ds-3~fto10+1
ii  ruby-saml                       1.12.2-1~fto10+1
ii  ruby-sanitize                   5.2.1-2~fto10+1
ii  ruby-sassc                      2.0.1-2~bpo10+1
ii  ruby-sassc-rails                2.1.2-5~bpo10+1
ii  ruby-seed-fu                    2.3.7-3~bpo10+1
ii  ruby-sentry-raven               3.0.0-2~bpo10+1
ii  ruby-settingslogic              2.0.9-3
ii  ruby-sidekiq                    6.0.4+dfsg-2~fto10+1
ii  ruby-sidekiq-cron               1.1.0-3
ii  ruby-slack-messenger            2.3.4-1~bpo10+1
ii  ruby-snowplow-tracker           0.6.1-2~bpo10+1
ii  ruby-sprockets                  3.7.2-1
ii  ruby-sshkey                     2.0.0-2~bpo10+1
ii  ruby-stackprof                  0.2.15-2+fto10+1
ii  ruby-state-machines-activemode  0.8.0-1~bpo10+1
ii  ruby-state-machines-activereco  0.8.0-1~bpo10+1
ii  ruby-sys-filesystem             1.1.7-2
ii  ruby-task-list [node-deckar01-  2.3.1-1~bpo10+1
ii  ruby-terser                     1.0.2+dfsg-4~bpo10+1
ii  ruby-thrift                     0.14.0-1~fto10+1
ii  ruby-toml-rb                    1.0.0-2
ii  ruby-truncato                   0.7.11-1~bpo10+1
ii  ruby-tzinfo                     1.2.6-1~bpo10+1
ii  ruby-u2f                        0.2.1-2
ii  ruby-unf                        0.1.4-2
ii  ruby-unf-ext                    0.0.7.6-1+fto10+1
ii  ruby-unleash                    0.1.6-2~bpo10+1
ii  ruby-valid-email                0.1.3-2~bpo10+1
ii  ruby-validates-hostname         1.0.11-1~bpo10+1
ii  ruby-version-sorter             2.2.4-1+fto10+1
ii  ruby-virtus                     1.0.5-3
ii  ruby-vmstat                     2.3.0-2+fto10+1
ii  ruby-webauthn                   2.4.0-2~fto10+1
ii  ruby-webpack-rails              0.9.11+git-1
ii  ruby-websocket-extensions       0.1.5-1~bpo10+1
ii  ruby-wikicloth                  0.8.1+dfsg-4
ii  ruby-yajl                       1.4.1-1+fto10+1
ii  ruby-zip                        2.0.0-1~bpo10+1
ii  ruby2.7                         2.7.3-2~fto10+1
ii  rubygems-integration            1.18~fto10+1
ii  ucf                             3.0038+nmu1
ii  webpack                         4.43.0-6~bpo10+1
ii  yarnpkg                         1.22.4-5~bpo10+1

Versions of packages gitlab recommends:
pn  certbot  <none>
ii  gitaly   13.11.2+dfsg-2~fto10+1

gitlab suggests no packages.

-- Configuration Files:
/etc/gitlab/initializers/smtp_settings.rb changed:
if Rails.env.production?
  Rails.application.config.action_mailer.delivery_method = :sendmail
  Rails.application.config.action_mailer.default_options = {from: "#{ENV['GITLAB_EMAIL_FROM']}" || "#{Settings.gitlab['email_from']}" || ''}
  ActionMailer::Base.sendmail_settings = {}
end


-- debconf information:
  gitlab/pgsql/manualconf:
  gitlab/upgrade-backup: true
  gitlab/dbconfig-remove: true
* gitlab/dbconfig-install: true
* gitlab/database-type: pgsql
  gitlab/dbconfig-upgrade: true
  gitlab/pgsql/no-empty-passwords:
  gitlab/missing-db-package-error: abort
  gitlab/letsencrypt: false
* gitlab/fqdn: <redacted>
  gitlab/purge: false
* gitlab/remote/host: localhost
  gitlab/upgrade-error: abort
  gitlab/internal/skip-preseed: false
  gitlab/db/app-user: <redacted>
  gitlab/pgsql/admin-user: postgres
  gitlab/dbconfig-reinstall: false
* gitlab/ssl: false
  gitlab/db/dbname: gitlab_production
  gitlab/purge_data: true
  gitlab/pgsql/changeconf: false
  gitlab/pgsql/authmethod-user: password
  gitlab/remove-error: abort
  gitlab/install-error: abort
  gitlab/remote/newhost: localhost
  gitlab/pgsql/method: TCP/IP
  gitlab/letsencrypt_email:
  gitlab/pgsql/authmethod-admin: ident
  gitlab/passwords-do-not-match:
  gitlab/remote/port:
  gitlab/internal/reconfiguring: false


More information about the Pkg-ruby-extras-maintainers mailing list