[DRE-maint] Bug#1027093: ruby-thor: FTBFS with ruby-rspec 3.12: ERROR: Test "ruby3.1" failed: Failure/Error: result = Thor::LineEditor.readline(message, options)

Tue Dec 27 17:12:09 GMT 2022

Source: ruby-thor
Version: 1.2.1-1
Severity: important
Justification: FTBFS
Tags: bookworm sid ftbfs
User: debian-ruby at lists.debian.org
Usertags: ruby-rspec-3.12

Hi,

I'm about to upload ruby-rspec 3.12. During a test rebuild with that version,
ruby-thor failed to build.

Relevant part of the build log (hopefully):
>       Failure/Error: result = Thor::LineEditor.readline(message, options)
> 
>         Thor::LineEditor received :readline with unexpected arguments
>           expected: ("Overwrite foo? (enter \"h\" for help) [Ynaqdhm] ", {:add_to_history=>false}) (keyword arguments)
>                got: ("Overwrite foo? (enter \"h\" for help) [Ynaqdhm] ", {:add_to_history=>false}) (options hash)
>       # /usr/share/rubygems-integration/all/gems/rspec-support-3.12.0/lib/rspec/support.rb:102:in `block in <module:Support>'
>       # /usr/share/rubygems-integration/all/gems/rspec-support-3.12.0/lib/rspec/support.rb:111:in `notify_failure'
>       # /usr/share/rubygems-integration/all/gems/rspec-mocks-3.12.1/lib/rspec/mocks/error_generator.rb:348:in `notify'
>       # /usr/share/rubygems-integration/all/gems/rspec-mocks-3.12.1/lib/rspec/mocks/error_generator.rb:332:in `__raise'
>       # /usr/share/rubygems-integration/all/gems/rspec-mocks-3.12.1/lib/rspec/mocks/error_generator.rb:55:in `raise_unexpected_message_args_error'
>       # /usr/share/rubygems-integration/all/gems/rspec-mocks-3.12.1/lib/rspec/mocks/message_expectation.rb:555:in `raise_unexpected_message_args_error'
>       # /usr/share/rubygems-integration/all/gems/rspec-mocks-3.12.1/lib/rspec/mocks/proxy.rb:216:in `message_received'
>       # /usr/share/rubygems-integration/all/gems/rspec-mocks-3.12.1/lib/rspec/mocks/proxy.rb:360:in `message_received'
>       # /usr/share/rubygems-integration/all/gems/rspec-mocks-3.12.1/lib/rspec/mocks/method_double.rb:91:in `proxy_method_invoked'
>       # /usr/share/rubygems-integration/all/gems/rspec-mocks-3.12.1/lib/rspec/mocks/method_double.rb:67:in `block (2 levels) in define_proxy_method'
>       # ./lib/thor/shell/basic.rb:460:in `ask_simply'
>       # ./lib/thor/shell/basic.rb:85:in `ask'
>       # ./lib/thor/shell/basic.rb:290:in `block in file_collision'
>       # ./lib/thor/shell/basic.rb:289:in `loop'
>       # ./lib/thor/shell/basic.rb:289:in `file_collision'
>       # ./spec/shell/basic_spec.rb:492:in `block (4 levels) in <top (required)>'
>       # /usr/share/rubygems-integration/all/gems/rspec-core-3.12.0/lib/rspec/core/example.rb:263:in `instance_exec'
>       # /usr/share/rubygems-integration/all/gems/rspec-core-3.12.0/lib/rspec/core/example.rb:263:in `block in run'
>       # /usr/share/rubygems-integration/all/gems/rspec-core-3.12.0/lib/rspec/core/example.rb:511:in `block in with_around_and_singleton_context_hooks'
>       # /usr/share/rubygems-integration/all/gems/rspec-core-3.12.0/lib/rspec/core/example.rb:468:in `block in with_around_example_hooks'
>       # /usr/share/rubygems-integration/all/gems/rspec-core-3.12.0/lib/rspec/core/hooks.rb:486:in `block in run'
>       # /usr/share/rubygems-integration/all/gems/rspec-core-3.12.0/lib/rspec/core/hooks.rb:624:in `run_around_example_hooks_for'
>       # /usr/share/rubygems-integration/all/gems/rspec-core-3.12.0/lib/rspec/core/hooks.rb:486:in `run'
>       # /usr/share/rubygems-integration/all/gems/rspec-core-3.12.0/lib/rspec/core/example.rb:468:in `with_around_example_hooks'
>       # /usr/share/rubygems-integration/all/gems/rspec-core-3.12.0/lib/rspec/core/example.rb:511:in `with_around_and_singleton_context_hooks'
>       # /usr/share/rubygems-integration/all/gems/rspec-core-3.12.0/lib/rspec/core/example.rb:259:in `run'
>       # /usr/share/rubygems-integration/all/gems/rspec-core-3.12.0/lib/rspec/core/example_group.rb:646:in `block in run_examples'
>       # /usr/share/rubygems-integration/all/gems/rspec-core-3.12.0/lib/rspec/core/example_group.rb:642:in `map'
>       # /usr/share/rubygems-integration/all/gems/rspec-core-3.12.0/lib/rspec/core/example_group.rb:642:in `run_examples'
>       # /usr/share/rubygems-integration/all/gems/rspec-core-3.12.0/lib/rspec/core/example_group.rb:607:in `run'
>       # /usr/share/rubygems-integration/all/gems/rspec-core-3.12.0/lib/rspec/core/example_group.rb:608:in `block in run'
>       # /usr/share/rubygems-integration/all/gems/rspec-core-3.12.0/lib/rspec/core/example_group.rb:608:in `map'
>       # /usr/share/rubygems-integration/all/gems/rspec-core-3.12.0/lib/rspec/core/example_group.rb:608:in `run'
>       # /usr/share/rubygems-integration/all/gems/rspec-core-3.12.0/lib/rspec/core/example_group.rb:608:in `block in run'
>       # /usr/share/rubygems-integration/all/gems/rspec-core-3.12.0/lib/rspec/core/example_group.rb:608:in `map'
>       # /usr/share/rubygems-integration/all/gems/rspec-core-3.12.0/lib/rspec/core/example_group.rb:608:in `run'
>       # /usr/share/rubygems-integration/all/gems/rspec-core-3.12.0/lib/rspec/core/runner.rb:121:in `block (3 levels) in run_specs'
>       # /usr/share/rubygems-integration/all/gems/rspec-core-3.12.0/lib/rspec/core/runner.rb:121:in `map'
>       # /usr/share/rubygems-integration/all/gems/rspec-core-3.12.0/lib/rspec/core/runner.rb:121:in `block (2 levels) in run_specs'
>       # /usr/share/rubygems-integration/all/gems/rspec-core-3.12.0/lib/rspec/core/configuration.rb:2070:in `with_suite_hooks'
>       # /usr/share/rubygems-integration/all/gems/rspec-core-3.12.0/lib/rspec/core/runner.rb:116:in `block in run_specs'
>       # /usr/share/rubygems-integration/all/gems/rspec-core-3.12.0/lib/rspec/core/reporter.rb:74:in `report'
>       # /usr/share/rubygems-integration/all/gems/rspec-core-3.12.0/lib/rspec/core/runner.rb:115:in `run_specs'
>       # /usr/share/rubygems-integration/all/gems/rspec-core-3.12.0/lib/rspec/core/runner.rb:89:in `run'
>       # /usr/share/rubygems-integration/all/gems/rspec-core-3.12.0/lib/rspec/core/runner.rb:71:in `run'
>       # /usr/share/rubygems-integration/all/gems/rspec-core-3.12.0/lib/rspec/core/runner.rb:45:in `invoke'
>       # /usr/share/rubygems-integration/all/gems/rspec-core-3.12.0/exe/rspec:4:in `<main>'
> 
> Finished in 1.03 seconds (files took 0.50471 seconds to load)
> 793 examples, 18 failures
> 
> Failed examples:
> 
> rspec ./spec/line_editor_spec.rb:16 # Thor::LineEditor on a system without Readline support .readline uses the Basic line editor
> rspec ./spec/parser/options_spec.rb:112 # Thor::Options#parse raises an error for unknown switches
> rspec ./spec/shell/basic_spec.rb:71 # Thor::Shell::Basic#ask prints a message to the user with the available options, expects case-sensitive matching, and determines the correctness of the answer
> rspec ./spec/shell/basic_spec.rb:77 # Thor::Shell::Basic#ask prints a message to the user with the available options, expects case-sensitive matching, and reasks the question after an incorrect response
> rspec ./spec/shell/basic_spec.rb:84 # Thor::Shell::Basic#ask prints a message to the user with the available options, expects case-sensitive matching, and reasks the question after a case-insensitive match
> rspec ./spec/shell/basic_spec.rb:91 # Thor::Shell::Basic#ask prints a message to the user with the available options, expects case-insensitive matching, and determines the correctness of the answer
> rspec ./spec/shell/basic_spec.rb:97 # Thor::Shell::Basic#ask prints a message to the user with the available options, expects case-insensitive matching, and reasks the question after an incorrect response
> rspec ./spec/shell/basic_spec.rb:104 # Thor::Shell::Basic#ask prints a message to the user containing a default and sets the default if only enter is pressed
> rspec ./spec/shell/basic_spec.rb:109 # Thor::Shell::Basic#ask prints a message to the user with the available options and reasks the question after an incorrect response and then returns the default
> rspec ./spec/shell/basic_spec.rb:118 # Thor::Shell::Basic#yes? asks the user and returns true if the user replies yes
> rspec ./spec/shell/basic_spec.rb:123 # Thor::Shell::Basic#yes? asks the user and returns false if the user replies no
> rspec ./spec/shell/basic_spec.rb:128 # Thor::Shell::Basic#yes? asks the user and returns false if the user replies with an answer other than yes or no
> rspec ./spec/shell/basic_spec.rb:135 # Thor::Shell::Basic#no? asks the user and returns true if the user replies no
> rspec ./spec/shell/basic_spec.rb:140 # Thor::Shell::Basic#no? asks the user and returns false if the user replies yes
> rspec ./spec/shell/basic_spec.rb:145 # Thor::Shell::Basic#no? asks the user and returns false if the user replies with an answer other than yes or no
> rspec ./spec/shell/basic_spec.rb:439 # Thor::Shell::Basic#file_collision shows a menu with options
> rspec ./spec/shell/basic_spec.rb:480 # Thor::Shell::Basic#file_collision always returns true if the user chooses always
> rspec ./spec/shell/basic_spec.rb:490 # Thor::Shell::Basic#file_collision when a block is given displays diff and merge options to the user
> 
> Coverage report generated for RSpec to /<<PKGBUILDDIR>>/coverage. 2201 / 2341 LOC (94.02%) covered.
> [33m[Coveralls] Outside the CI environment, not sending data.[0m
> Stopped processing SimpleCov as a previous error not related to SimpleCov has been detected
> /usr/bin/ruby3.1 -I/usr/share/rubygems-integration/all/gems/rspec-support-3.12.0/lib:/usr/share/rubygems-integration/all/gems/rspec-core-3.12.0/lib /usr/share/rubygems-integration/all/gems/rspec-core-3.12.0/exe/rspec --pattern ./spec/\*\*/\*_spec.rb --backtrace -r ./spec/helper.rb failed
> ERROR: Test "ruby3.1" failed: 

The full build log is attached.

If you reassign this bug to another package, please marking it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ruby-thor.log.gz
Type: application/gzip
Size: 20616 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-ruby-extras-maintainers/attachments/20221227/3bf5a039/attachment-0001.gz>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-ruby-extras-maintainers/attachments/20221227/3bf5a039/attachment-0001.sig>