[DRE-maint] Bug#1002532: pygments breaks ruby-pygments.rb autopkgtest: UTF-8 != ASCII-8BIT

[Mattia Rizzolo]

Hi Alex,

On Thu, Jan 06, 2022 at 11:19:00AM +0100, Alexandre Ghiti wrote:
> As the current version we have is from 2017, I bumped the version of
> this package to the latest available version: I updated the patches,
> removed the ones that do not apply anymore, updated the build system
> and dependencies. The result is available in my PPA [2] and fixes the
> issue we encounter here.
> 
> Can you consider pulling this?

Thank you for this!!


I had a look at your work, however I couldn't help but notice that:
* the .orig you used looks odd, much larger than what I get from uscan
  (despite yours is also using a different compression, so repacked).
* You did a ton of patch wrangling, including deletion, renaming,
  rebasing, etc.  which is all fine, except that the way you did it
  obscures quite a bit what you did.  Why did you drop the numbers from
  the patches?  Do you have --no-patch-numbers as you gbp-pq default or
  something?
* why requiring gem2deb >=1 ?  that's already in bullseye as well in
  focal, so why did you feel the need to add the version?  (that's also
  not in the changelog)

As such, I went ahead and re-imported the repacked origin I got myself
in git.
Could I ask you to submit a MR on top of it, with at least commits
separating the deletion, refresh and rebasing of patches (and eventual
new ones, I can't tell at a glance if any new patch appeared…) also
separated.
https://salsa.debian.org/ruby-team/ruby-pygments.rb

Thank you for your work!!  :)

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
More about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-ruby-extras-maintainers/attachments/20220120/20ab1c60/attachment-0001.sig>