[DRE-maint] Bug#1002532: pygments breaks ruby-pygments.rb autopkgtest: UTF-8 != ASCII-8BIT

[Alexandre Ghiti]

On Sun, 23 Jan 2022 22:17:08 +0100 Mattia Rizzolo <mattia at debian.org> wrote:
> On Fri, Jan 21, 2022 at 03:51:02PM +0100, Alexandre Ghiti wrote:
> > I can't find how to create a MR in salsa, can you pull directly from here:
> >
> > https://salsa.debian.org/alexghiti/ruby-pygments.rb/-/tree/int/alex/2.3.0
> >
> > It successfully built in my PPA, if you need any more modification, do
> > not hesitate.
>
> Ah, another thing. Please be careful with the version you pick.
>
> You used 2.3.0+ds-1ubuntu1, which is *higher* than what I'll be
> uploading, namely 2.3.0+ds-1.
> Furthermore, in your PPA you used 2.3.0+ds-1ubuntu2, which would also
> conflict with an eventual -1ubuntu done in the offical ubuntu archive.
>
> I'd recommend you used something like -0ppa1 or -0ubuntu1~ppa1 or
> somesuch.
>
> (in this case this is of no consequence, but just something to note).

Thanks for the advice.

>
>
>
> Lastly, I noticed that you haven't even touched the changelog. In this
> case there was even a new copyright holder, so it really should have
> been updated.

Sorry and thanks for taking care of that.

> I didn't add you to the paragraph of d/copyright, as I assume you are
> doing this under your paid time, and I don't know what's Canonical's
> rules regarding copyright here. If needed/wanted, just send me a note
> and I'll update the copy in git.

No problem.

Regarding the autopkgtest failure (again an oversight on my part,
sorry), I fixed it here, it works in my PPA and on an ubuntu jammy VM
(I failed to make autopkgtest work with testing):

https://salsa.debian.org/alexghiti/ruby-pygments.rb/-/commit/19442f7b89c5a6ca5ef1d8e1e6ebc42a261e441e

Thanks again,

Alex

>
> --
> regards,
> Mattia Rizzolo
>
> GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
> More about me: https://mapreri.org : :' :
> Launchpad user: https://launchpad.net/~mapreri `. `'`
> Debian QA page: https://qa.debian.org/developer.php?login=mattia `-