[DRE-maint] Bug#1024631: gitlab: preinst: invalid number 9.1

[Kurt Roeckx]

On Tue, Nov 22, 2022 at 10:20:06PM +0530, Pirate Praveen wrote:
> 
> 
> On Tue, Nov 22 2022 at 02:27:05 PM +01:00:00 +01:00:00, Kurt Roeckx
> <kurt at roeckx.be> wrote:
> > Package: gitlab
> > Version: 15.4.2+ds1-1~fto11+3
> > 
> > On install I get:
> > /var/lib/dpkg/tmp.ci/preinst: 7 [: Illagal number: 9.1
> > 
> > I have several postgresql clusters, 9.1, 9.6, 12, 14. Not all of them
> > are used. 9.1 is using port 5432.
> > 
> 
> Do you have another recommendation on how to make sure we use at least
> postgresql 12?
> 
> Does adding a configuration option to skip this check
> "gitlab_pg_version_check" which can be set to "false" in
> /etc/gitlab/gitlab-debian.conf suffice?

Note that it just continues the installation because it ignores
the error.

To be able to install things, I had to edit the database.yml to set the
port number. I also had to manually create the user and database.

I think it asks for a hostname, but not for a port number. I at least
assume it supports a remote database. The check should be for that
combination, which is probably harder. In any case, the default cluster
points to 14, it's just not on port 5432.


Kurt