[DRE-maint] Bug#1019403: gitlab: failed to fetch comments in issue (500 Internal Server Error)

[Antoine Le Gonidec]

On Thu, 08 Sep 2022 17:04:31 +0200 Maximilian Stein <m at steiny.biz> wrote:
> To me, this seemed like a typo, so I simply removed "h " in
> labels_helper.rb:250. This fixed the issue for me, as far as I can
> tell.

This might not be a typo. It has been added in the following upstream commit:
https://gitlab.com/gitlab-org/gitlab/-/commit/513066c360bcfaa8d5cd40795f7d98d46b9e1e44
(I could not find the original merge request discussion, its access might be restricted)

An alternative fix is to replace:
#{"style=\"background-color: #{h bg_color}\"" if bg_color}
with:
#{"style=\"background-color: #{html_escape bg_color}\"" if bg_color}

I think "h" is supposed to be a method alias for "html_escape", but is not loaded due to something missing in our setup.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 236 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-ruby-extras-maintainers/attachments/20221003/09073b60/attachment.sig>