[DRE-maint] Bug#1019403: gitlab: failed to fetch comments in issue (500 Internal Server Error)

[Maximilian Stein]

Package: gitlab
Version: 15.3.2+ds1-1~fto11+1
Severity: normal
Tags: patch

Dear Maintainer,

After upgrading Gitlab, issue comments failed to fetch. I got the
following log entries:

    Completed 500 Internal Server Error in 234ms (ActiveRecord: 154.4ms | Elasticsearch: 0.0ms | Allocations: 66512)

    NoMethodError (undefined method `h' for LabelsHelper:Module):

    app/helpers/labels_helper.rb:250:in `render_label_text'
    app/helpers/labels_helper.rb:61:in `render_colored_label'
    lib/banzai/filter/references/label_reference_filter.rb:120:in `object_link_text'


To me, this seemed like a typo, so I simply removed "h " in
labels_helper.rb:250. This fixed the issue for me, as far as I can
tell.

Best,
Maximilian


---

--- a/usr/share/gitlab/app/helpers/labels_helper.rb
+++ b/usr/share/gitlab/app/helpers/labels_helper.rb
@@ -247,7 +247,7 @@
         class="#{css_class}"
         data-container="body"
         data-html="true"
-        #{"style=\"background-color: #{h bg_color}\"" if bg_color}
+        #{"style=\"background-color: #{bg_color}\"" if bg_color}
       >#{ERB::Util.html_escape_once(name)}#{suffix}</span>
     HTML
   end