[DRE-maint] Bug#1019678: ruby-websocket: FTBFS with ruby3.1: ERROR: Test "ruby3.1" failed: Failure/Error: expect(handshake.to_s).to eql(client_request)

[Antonio Terceiro]

Source: ruby-websocket
Version: 1.2.9-2
Severity: important
Justification: FTBFS
Tags: bookworm sid ftbfs
User: debian-ruby at lists.debian.org
Usertags: ruby3.1

Hi,

We are about to start the ruby3.1 transition in unstable. While trying to
rebuild ruby-websocket with ruby3.1 enabled, the build failed.

Relevant part of the build log (hopefully):
>       Failure/Error: expect(handshake.to_s).to eql(client_request)
> 
>         expected: "GET /demo HTTP/1.1\r\nUpgrade: WebSocket\r\nConnection: Upgrade\r\nHost: example.com\r\nOrigin: http...L  09 358 67  Q\r\nSec-WebSocket-Key2: T 1   &6 0 W7228i :0x  0v_K s0n\r\n\r\n_\fq\x85\xF6\x9E[\x1D"
>              got: "GET /demo HTTP/1.1\r\nUpgrade: WebSocket\r\nConnection: Upgrade\r\nHost: example.com:80\r\nOrigin: h...L  09 358 67  Q\r\nSec-WebSocket-Key2: T 1   &6 0 W7228i :0x  0v_K s0n\r\n\r\n_\fq\x85\xF6\x9E[\x1D"
> 
>         (compared using eql?)
> 
>         Diff:
>         @@ -1,7 +1,7 @@
>          GET /demo HTTP/1.1
>          Upgrade: WebSocket
>          Connection: Upgrade
>         -Host: example.com
>         +Host: example.com:80
>          Origin: http://example.com
>          aaa: bbb
>          Sec-WebSocket-Key1: 4 *03L  09 358 67  Q
>       Shared Example Group: "all client drafts" called from ./spec/handshake/client_76_spec.rb:12
>       # ./spec/support/all_client_drafts.rb:5:in `validate_request'
>       # ./spec/support/all_client_drafts.rb:93:in `block (2 levels) in <top (required)>'
> 
> Finished in 0.22071 seconds (files took 0.25283 seconds to load)
> 1021 examples, 16 failures
> 
> Failed examples:
> 
> rspec './spec/handshake/client_04_spec.rb[1:1:11]' # Client draft 4 handshake behaves like all client drafts returns valid response
> rspec './spec/handshake/client_04_spec.rb[1:1:12]' # Client draft 4 handshake behaves like all client drafts allows custom path
> rspec './spec/handshake/client_04_spec.rb[1:1:13]' # Client draft 4 handshake behaves like all client drafts allows query in path
> rspec './spec/handshake/client_04_spec.rb[1:1:15]' # Client draft 4 handshake behaves like all client drafts allows custom headers
> rspec './spec/handshake/client_11_spec.rb[1:1:11]' # Client draft 11 handshake behaves like all client drafts returns valid response
> rspec './spec/handshake/client_11_spec.rb[1:1:12]' # Client draft 11 handshake behaves like all client drafts allows custom path
> rspec './spec/handshake/client_11_spec.rb[1:1:13]' # Client draft 11 handshake behaves like all client drafts allows query in path
> rspec './spec/handshake/client_11_spec.rb[1:1:15]' # Client draft 11 handshake behaves like all client drafts allows custom headers
> rspec './spec/handshake/client_75_spec.rb[1:1:11]' # Client draft 75 handshake behaves like all client drafts returns valid response
> rspec './spec/handshake/client_75_spec.rb[1:1:12]' # Client draft 75 handshake behaves like all client drafts allows custom path
> rspec './spec/handshake/client_75_spec.rb[1:1:13]' # Client draft 75 handshake behaves like all client drafts allows query in path
> rspec './spec/handshake/client_75_spec.rb[1:1:15]' # Client draft 75 handshake behaves like all client drafts allows custom headers
> rspec './spec/handshake/client_76_spec.rb[1:1:11]' # Client draft 76 handshake behaves like all client drafts returns valid response
> rspec './spec/handshake/client_76_spec.rb[1:1:12]' # Client draft 76 handshake behaves like all client drafts allows custom path
> rspec './spec/handshake/client_76_spec.rb[1:1:13]' # Client draft 76 handshake behaves like all client drafts allows query in path
> rspec './spec/handshake/client_76_spec.rb[1:1:15]' # Client draft 76 handshake behaves like all client drafts allows custom headers
> 
> /usr/bin/ruby3.1 -I/usr/share/rubygems-integration/all/gems/rspec-support-3.10.3/lib:/usr/share/rubygems-integration/all/gems/rspec-core-3.10.1/lib /usr/share/rubygems-integration/all/gems/rspec-core-3.10.1/exe/rspec --pattern ./spec/\*\*/\*_spec.rb --format documentation failed
> ERROR: Test "ruby3.1" failed: 


The full build log is available from:
https://people.debian.org/~terceiro/ruby3.1/17/ruby-websocket/ruby-websocket_1.2.9-2+rebuild1663008321_amd64-2022-09-12T18:45:22Z.build

To reproduce this, you need to install ruby-all-dev >= 1:3.0+2. Depending on
when you try this, it might mean installing ruby-all-dev from experimental, or
if the transition has already started, a normal build on unstable will be
enough.  If you fail to reproduce, please provide a build log and diff it with
mine so that we can identify if something relevant changed in the meantime.

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please marking it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-ruby-extras-maintainers/attachments/20220913/a4b6abf1/attachment.sig>