[DRE-maint] Bug#1050581: ruby-html-proofer: broken by ruby-nokogiri 1.15.4

Wed Aug 30 21:16:23 BST 2023

On 26/08/23 at 16:55 +0200, Lucas Nussbaum wrote:
> Source: ruby-html-proofer
> Version: 3.19.2-7
> Severity: serious
> 
> Hi,
> 
> I just uploaded ruby-nokogiri 1.15.4, and while testing reverse
> dependencies, noticed that it breaks this package.

It fails with

  1) Html test reports failures
     Failure/Error: expect(proofer.failed_tests.first).to match(/ERROR: That tag isn't allowed here/)
     
       expected "spec/html-proofer/fixtures/html/parse_failure.html: 1:33: ERROR: End tag 'a' isn't allowed here. Cur... open tags: html.\n<!DOCTYPE html><html><!-- -- --></a>\n                                ^ (line 1)" to match /ERROR: That tag isn't allowed here/
       Diff:
       @@ -1,3 +1,5 @@
       -/ERROR: That tag isn't allowed here/
       +spec/html-proofer/fixtures/html/parse_failure.html: 1:33: ERROR: End tag 'a' isn't allowed here. Currently open tags: html.
       +<!DOCTYPE html><html><!-- -- --></a>
       +                                ^ (line 1)
       
     # ./spec/html-proofer/html_spec.rb:132:in `block (2 levels) in <top (required)>'

  2) Html test allows div inside head
     Failure/Error: expect(proofer.failed_tests).to eq []
     
       expected: []
            got: ["spec/html-proofer/fixtures/html/div_inside_head.html: 5:1: ERROR: End tag 'head' isn't allowed here. Currently open tags: html, body.\n</head>\n^ (line 5)"]
     
       (compared using ==)
     
       Diff:
       @@ -1 +1,2 @@
       +spec/html-proofer/fixtures/html/div_inside_head.html: 5:1: ERROR: End tag 'head' isn't allowed here. Currently open tags: html, body.\n</head>\n^ (line 5)
       
     # ./spec/html-proofer/html_spec.rb:51:in `block (2 levels) in <top (required)>'

  3) Html test allows an unmatched end tag
     Failure/Error: expect(proofer.failed_tests).to eq []
     
       expected: []
            got: ["spec/html-proofer/fixtures/html/unmatched_end_tag.html: 3:1: ERROR: End tag 'div' isn't allowed here. Currently open tags: html, body.\n</div>\n^ (line 3)"]
     
       (compared using ==)
     
       Diff:
       @@ -1 +1,2 @@
       +spec/html-proofer/fixtures/html/unmatched_end_tag.html: 3:1: ERROR: End tag 'div' isn't allowed here. Currently open tags: html, body.\n</div>\n^ (line 3)
       
     # ./spec/html-proofer/html_spec.rb:33:in `block (2 levels) in <top (required)>'

  4) Html test allows mismatch between opening and ending tag
     Failure/Error: expect(proofer.failed_tests).to eq []
     
       expected: []
            got: ["spec/html-proofer/fixtures/html/opening_and_ending_tag_mismatch.html: 3:31: ERROR: End tag 'p' isn'...ed here. Currently open tags: html, body, strong, p.\n<p>lazy</strong> dog.</p>\n       ^ (line 5)"]
     
       (compared using ==)
     
       Diff:
       @@ -1,2 +1,4 @@
       +spec/html-proofer/fixtures/html/opening_and_ending_tag_mismatch.html: 3:31: ERROR: End tag 'p' isn't allowed here. Currently open tags: html, body, p, strong.\n<p>The quick <strong>brown fox</p>\n                              ^ (line 3)
       +spec/html-proofer/fixtures/html/opening_and_ending_tag_mismatch.html: 5:8: ERROR: End tag 'strong' isn't allowed here. Currently open tags: html, body, strong, p.\n<p>lazy</strong> dog.</p>\n       ^ (line 5)
       
     # ./spec/html-proofer/html_spec.rb:45:in `block (2 levels) in <top (required)>'


Lucas