[DRE-maint] Bug#1037529: ruby-jekyll-github-metadata: FTBFS with test failures when there's no network

[Steve Langasek]

Package: ruby-jekyll-github-metadata
Version: 2.15.0-1
Severity: serious
Tags: patch
Justification: Policy 4.9
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu mantic ubuntu-patch

Hi Daniel,

ruby-jekyll-github-metadata has a test suite that relies on accessing the
github.com website at build time, so the package fails to build in an
offline environment.

[...]
Failures:

  1) Jekyll::GitHubMetadata::SiteGitHubMunger generating repo for org with displayname sets title to org's displayname
     Failure/Error: expect(site.config["title"]).to eql("Jekyll")

       expected: "Jekyll"
            got: #<Jekyll::GitHubMetadata::Value:0x00007f28de8ff0a8 @key="title", @value="jekyll", @rendered="jekyll">

       (compared using eql?)

       Diff:
       @@ -1,4 +1,7 @@
       -"Jekyll"
       +#<Jekyll::GitHubMetadata::Value:0x00007f28de8ff0a8
       + @key="title",
       + @rendered="jekyll",
       + @value="jekyll">
     # ./spec/site_github_munger_spec.rb:177:in `block (3 levels) in <top (required)>'
     # /usr/share/rubygems-integration/all/gems/webmock-3.18.1/lib/webmock/rspec.rb:37:in `block (2 levels) in <top (required)>'
[...]

  (https://launchpad.net/ubuntu/+source/ruby-jekyll-github-metadata/2.15.0-1/+build/26010086)

The attached patch filters out those source files whose tests fail when
offline.  I've uploaded it to Ubuntu to fix a build failure there.

Thanks for considering,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
diff -Nru ruby-jekyll-github-metadata-2.15.0/debian/ruby-tests.rake ruby-jekyll-github-metadata-2.15.0/debian/ruby-tests.rake
--- ruby-jekyll-github-metadata-2.15.0/debian/ruby-tests.rake	2023-02-09 02:27:58.000000000 -0800
+++ ruby-jekyll-github-metadata-2.15.0/debian/ruby-tests.rake	2023-06-13 13:27:27.000000000 -0700
@@ -2,7 +2,11 @@
 
 skip = [
   './spec/integration_spec.rb',
-  './spec/metadata_drop_spec.rb'
+  './spec/metadata_drop_spec.rb',
+  './spec/site_github_munger_spec.rb',
+  './spec/owner_spec.rb',
+  './spec/client_spec.rb',
+  './spec/repository_spec.rb'
 ]
 
 Gem2Deb::Rake::RSpecTask.new do |spec|