[DRE-maint] Bug#1085833: `extract_and_parse_dependencies': undefined method `source' for nil:NilClass

[Gabriel Filion]

I've done more debuggig during the day and I found out that it's 
actually a bug in the upstream source code. I've reported it here:

https://github.com/voxpupuli/librarian-puppet/issues/126

So this bug report can probably be closed. Hopefully it'll get fixed 
upstream not to far into the future, but who knows when :\

On 2024-10-22 14:37, Gabriel Filion wrote:
> Package: librarian-puppet
> Version: 5.0.0-1
> Severity: important
> 
> Hello,
> 
> I've just installed librarian-puppet in sid and tried using `librarian-puppet
> install` to get new dependencies from something I added to a Puppetfile and the
> binary crashed with the following stack trace:
> 
> /usr/lib/ruby/vendor_ruby/librarian/puppet/lockfile.rb:32:in `extract_and_parse_dependencies': undefined method `source' for nil:NilClass (NoMethodError)
> 
>              dependencies << environment.dsl_class.dependency_type.new(name, requirement, manifests_index[name].source, 'lockfile')
>                                                                                                                ^^^^^^^
> 	from /usr/share/rubygems-integration/all/gems/librarianp-0.6.4/lib/librarian/lockfile/parser.rb:29:in `parse'
> 	from /usr/lib/ruby/vendor_ruby/librarian/puppet/lockfile.rb:73:in `load'
> 	from /usr/share/rubygems-integration/all/gems/librarianp-0.6.4/lib/librarian/lockfile.rb:25:in `read'
> 	from /usr/share/rubygems-integration/all/gems/librarianp-0.6.4/lib/librarian/action/resolve.rb:16:in `run'
> 	from /usr/lib/ruby/vendor_ruby/librarian/puppet/action/resolve.rb:11:in `run'
> 	from /usr/lib/ruby/vendor_ruby/librarian/puppet/cli.rb:111:in `resolve!'
> 	from /usr/lib/ruby/vendor_ruby/librarian/puppet/cli.rb:68:in `install'
> 	from /usr/share/rubygems-integration/all/gems/thor-1.3.1/lib/thor/command.rb:28:in `run'
> 	from /usr/share/rubygems-integration/all/gems/thor-1.3.1/lib/thor/invocation.rb:127:in `invoke_command'
> 	from /usr/share/rubygems-integration/all/gems/thor-1.3.1/lib/thor.rb:527:in `dispatch'
> 	from /usr/share/rubygems-integration/all/gems/thor-1.3.1/lib/thor/base.rb:584:in `start'
> 	from /usr/share/rubygems-integration/all/gems/librarianp-0.6.4/lib/librarian/cli.rb:26:in `block (2 levels) in bin!'
> 	from /usr/share/rubygems-integration/all/gems/librarianp-0.6.4/lib/librarian/cli.rb:31:in `returning_status'
> 	from /usr/share/rubygems-integration/all/gems/librarianp-0.6.4/lib/librarian/cli.rb:26:in `block in bin!'
> 	from /usr/share/rubygems-integration/all/gems/librarianp-0.6.4/lib/librarian/cli.rb:47:in `with_environment'
> 	from /usr/share/rubygems-integration/all/gems/librarianp-0.6.4/lib/librarian/cli.rb:26:in `bin!'
> 	from /usr/bin/librarian-puppet:7:in `<main>'
> 
> 
>  From what I can see, all of the files in the stack trace are part of one of
> three debian packages:
> 
> * librarian-puppet
> * ruby-librarian
> * ruby-thor
> 
> I'm unfortuanately not sure what's happening there. Is it maybe an
> incompatibility with either ruby-librarian or ruby-thor?
> 
> I can run `librarian-puppet version`, `config`, `help`, `clean` without issues
> but most other actions crash with a similar stack trace. So librarian-puppet is
> useless for me in this condition.
> 
> -- System Information:
> Debian Release: trixie/sid
>    APT prefers unstable
>    APT policy: (500, 'unstable')
> Architecture: amd64 (x86_64)
> Foreign Architectures: i386
> 
> Kernel: Linux 6.11.2-amd64 (SMP w/16 CPU threads; PREEMPT)
> Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_CA.utf8), LANGUAGE not set
> Shell: /bin/sh linked to /usr/bin/dash
> Init: systemd (via /run/systemd/system)
> LSM: AppArmor: enabled
> 
> Versions of packages librarian-puppet depends on:
> ii  libruby3.1t64 [ruby-json]  3.1.2-8.4
> ii  puppet                     8.4.0-2
> ii  ruby                       1:3.1+nmu1
> ii  ruby-librarian             0.6.4-5
> ii  ruby-puppet-forge          5.0.3-1
> ii  ruby-rsync                 1.0.9-3
> 
> librarian-puppet recommends no packages.
> 
> librarian-puppet suggests no packages.
> 
> -- no debconf information