[DRE-maint] Bug#1097553: passenger: ftbfs with GCC-15

[Matthias Klose]

Package: src:passenger
Version: 6.0.24+ds-3
Severity: important
Tags: sid forky
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/passenger_6.0.24+ds-3_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
src/apache2_module/Hooks.cpp:1204:32: warning: unknown option after ‘#pragma GCC diagnostic’ kind [-Wpragmas]
 1204 | #pragma GCC diagnostic ignored "-Wnull-pointer-subtraction"
      |                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
c++ -shared buildout/apache2/mod_passenger.o buildout/apache2/CBindings.o buildout/apache2/Config.o buildout/apache2/Bucket.o buildout/apache2/Hooks.o -fPIC -o buildout/apache2/mod_passenger.so buildout/apache2/module_libpassenger_common/LoggingKit.o buildout/apache2/module_libpassenger_common/Exceptions.o buildout/apache2/module_libpassenger_common/FileTools/PathManip.o buildout/apache2/module_libpassenger_common/FileTools/FileManip.o buildout/apache2/module_libpassenger_common/FileTools/PathSecurityCheck.o buildout/apache2/module_libpassenger_common/ProcessManagement/Spawn.o buildout/apache2/module_libpassenger_common/ProcessManagement/Utils.o buildout/apache2/module_libpassenger_common/SystemTools/UserDatabase.o buildout/apache2/module_libpassenger_common/Utils/SystemTime.o buildout/apache2/module_libpassenger_common/StrIntTools/StrIntUtils.o buildout/apache2/module_libpassenger_common/StrIntTools/StrIntUtilsNoStrictAliasing.o buildout/apache2/module_libpassenger_common/IOTools/IOUtils.o buildout/apache2/module_libpassenger_common/Algorithms/Hasher.o buildout/apache2/module_libpassenger_common/Utils.o buildout/apache2/module_libpassenger_common/jsoncpp.o buildout/apache2/module_libpassenger_common/vendor-modified/modp_b64.o buildout/apache2/module_libpassenger_common/vendor-modified/modp_b64_strict_aliasing.o buildout/apache2/module_libboost_oxt.a -Wl,--as-needed -Wl,-z,relro -Wl,-z,now -lpcre2-8 -L/usr/lib/x86_64-linux-gnu/libpcre2-8.so.0 -fPIC -DLINUX -D_REENTRANT -D_GNU_SOURCE -I/usr/include/apr-1.0 -I/usr/include/apr-1.0 -I/usr/include -pipe -g -Werror=implicit-function-declaration -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -I/usr/include/apache2 -L/usr/lib/x86_64-linux-gnu -lapr-1 -L/usr/lib/x86_64-linux-gnu -laprutil-1 -std=gnu++11 -lpthread -lrt -ldl
mkdir -p buildout/support-binaries
c++ -o buildout/support-binaries/AgentMain.o  -Isrc/agent -Isrc/cxx_supportlib -Isrc/cxx_supportlib/vendor-copy -Isrc/cxx_supportlib/vendor-modified -I/usr/include/libev -I/usr/include/libuv -Isrc/cxx_supportlib/vendor-modified/websocketpp -D_REENTRANT -I/usr/local/include -Wall -Wextra -Wno-unused-parameter -Wno-parentheses -Wpointer-arith -Wwrite-strings -Wno-long-long -Wno-missing-field-initializers -Wno-unknown-pragmas -feliminate-unused-debug-symbols -feliminate-unused-debug-types -fvisibility=hidden -DVISIBILITY_ATTRIBUTE_SUPPORTED -Wno-attributes -DHAS_ALLOCA_H -DHAVE_ACCEPT4 -DHAS_SFENCE -DHAS_LFENCE -DPASSENGER_DEBUG -DBOOST_DISABLE_ASSERTS -ggdb -std=gnu++11 -Wno-unused-local-typedefs -Wno-format-nonliteral -DHAS_UNORDERED_MAP -g -O2 -ffile-prefix-map=/build/reproducible-path/passenger-6.0.24+ds=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -c src/agent/AgentMain.cpp
c++ -o buildout/support-binaries/AgentFundamentals.o  -Isrc/agent -Isrc/cxx_supportlib -Isrc/cxx_supportlib/vendor-copy -Isrc/cxx_supportlib/vendor-modified -I/usr/include/libev -I/usr/include/libuv -Isrc/cxx_supportlib/vendor-modified/websocketpp -D_REENTRANT -I/usr/local/include -Wall -Wextra -Wno-unused-parameter -Wno-parentheses -Wpointer-arith -Wwrite-strings -Wno-long-long -Wno-missing-field-initializers -Wno-unknown-pragmas -feliminate-unused-debug-symbols -feliminate-unused-debug-types -fvisibility=hidden -DVISIBILITY_ATTRIBUTE_SUPPORTED -Wno-attributes -DHAS_ALLOCA_H -DHAVE_ACCEPT4 -DHAS_SFENCE -DHAS_LFENCE -DPASSENGER_DEBUG -DBOOST_DISABLE_ASSERTS -ggdb -std=gnu++11 -Wno-unused-local-typedefs -Wno-format-nonliteral -DHAS_UNORDERED_MAP -g -O2 -ffile-prefix-map=/build/reproducible-path/passenger-6.0.24+ds=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -c src/agent/Shared/Fundamentals/Implementation.cpp
c++ -o buildout/support-binaries/WatchdogMain.o  -Isrc/agent -Isrc/cxx_supportlib -Isrc/cxx_supportlib/vendor-copy -Isrc/cxx_supportlib/vendor-modified -I/usr/include/libev -I/usr/include/libuv -Isrc/cxx_supportlib/vendor-modified/websocketpp -D_REENTRANT -I/usr/local/include -Wall -Wextra -Wno-unused-parameter -Wno-parentheses -Wpointer-arith -Wwrite-strings -Wno-long-long -Wno-missing-field-initializers -Wno-unknown-pragmas -feliminate-unused-debug-symbols -feliminate-unused-debug-types -fvisibility=hidden -DVISIBILITY_ATTRIBUTE_SUPPORTED -Wno-attributes -DHAS_ALLOCA_H -DHAVE_ACCEPT4 -DHAS_SFENCE -DHAS_LFENCE -DPASSENGER_DEBUG -DBOOST_DISABLE_ASSERTS -ggdb -std=gnu++11 -Wno-unused-local-typedefs -Wno-format-nonliteral -DHAS_UNORDERED_MAP -g -O2 -ffile-prefix-map=/build/reproducible-path/passenger-6.0.24+ds=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -c src/agent/Watchdog/WatchdogMain.cpp
In file included from src/cxx_supportlib/ServerKit/Server.h:61,
                 from src/agent/Shared/ApiServerUtils.h:71,
                 from src/agent/Watchdog/WatchdogMain.cpp:66:
src/cxx_supportlib/Algorithms/MovingAverage.h: In member function ‘double Passenger::DiscExpMovingAverageWithStddev<alpha, alphaTimeUnit, maxAge>::stddev(long long unsigned int) const’:
src/cxx_supportlib/Algorithms/MovingAverage.h:193:58: error: ‘class Passenger::DiscExpMovingAverageWithStddev<alpha, alphaTimeUnit, maxAge>’ has no member named ‘sumOfWeights’ [-Wtemplate-body]
  193 |                 return sqrt(copy.sumOfSquaredData / copy.sumOfWeights - pow(copy.average(), 2));
      |                                                          ^~~~~~~~~~~~
In file included from src/cxx_supportlib/vendor-modified/websocketpp/websocketpp/config/core_client.hpp:55,
                 from src/cxx_supportlib/vendor-modified/websocketpp/websocketpp/config/asio_no_tls_client.hpp:31,
                 from src/cxx_supportlib/WebSocketCommandReverseServer.h:29,
                 from src/agent/Core/AdminPanelConnector.h:43,
                 from src/agent/Core/Config.h:50,
                 from src/agent/Watchdog/Config.h:32,
                 from src/agent/Watchdog/WatchdogMain.cpp:68:
src/cxx_supportlib/vendor-modified/websocketpp/websocketpp/logger/basic.hpp: At global scope:
src/cxx_supportlib/vendor-modified/websocketpp/websocketpp/logger/basic.hpp:61:49: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
   61 |     basic<concurrency,names>(channel_type_hint::value h =
      |                                                 ^~~~~
src/cxx_supportlib/vendor-modified/websocketpp/websocketpp/logger/basic.hpp:61:49: note: remove the ‘< >’
src/cxx_supportlib/vendor-modified/websocketpp/websocketpp/logger/basic.hpp:67:35: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
   67 |     basic<concurrency,names>(std::ostream * out)
      |                                   ^~~~~~~
src/cxx_supportlib/vendor-modified/websocketpp/websocketpp/logger/basic.hpp:67:35: note: remove the ‘< >’
src/cxx_supportlib/vendor-modified/websocketpp/websocketpp/logger/basic.hpp:72:30: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
   72 |     basic<concurrency,names>(level c, channel_type_hint::value h =
      |                              ^~~~~
src/cxx_supportlib/vendor-modified/websocketpp/websocketpp/logger/basic.hpp:72:30: note: remove the ‘< >’
src/cxx_supportlib/vendor-modified/websocketpp/websocketpp/logger/basic.hpp:78:30: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
   78 |     basic<concurrency,names>(level c, std::ostream * out)
      |                              ^~~~~
src/cxx_supportlib/vendor-modified/websocketpp/websocketpp/logger/basic.hpp:78:30: note: remove the ‘< >’
src/cxx_supportlib/vendor-modified/websocketpp/websocketpp/logger/basic.hpp:84:5: warning: template-id not allowed for destructor in C++20 [-Wtemplate-id-cdtor]
   84 |     ~basic<concurrency,names>() {}
      |     ^
src/cxx_supportlib/vendor-modified/websocketpp/websocketpp/logger/basic.hpp:84:5: note: remove the ‘< >’
src/cxx_supportlib/vendor-modified/websocketpp/websocketpp/logger/basic.hpp:87:30: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
   87 |     basic<concurrency,names>(basic<concurrency,names> const & other)
      |                              ^~~~~~~~~~~~~~~~~~~~~~~~
src/cxx_supportlib/vendor-modified/websocketpp/websocketpp/logger/basic.hpp:87:30: note: remove the ‘< >’
src/cxx_supportlib/vendor-modified/websocketpp/websocketpp/logger/basic.hpp:100:30: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
  100 |     basic<concurrency,names>(basic<concurrency,names> && other)
      |                              ^~~~~~~~~~~~~~~~~~~~~~~~
src/cxx_supportlib/vendor-modified/websocketpp/websocketpp/logger/basic.hpp:100:30: note: remove the ‘< >’
In file included from src/cxx_supportlib/vendor-modified/websocketpp/websocketpp/roles/client_endpoint.hpp:31,
                 from src/cxx_supportlib/vendor-modified/websocketpp/websocketpp/client.hpp:31,
                 from src/cxx_supportlib/WebSocketCommandReverseServer.h:30:
src/cxx_supportlib/vendor-modified/websocketpp/websocketpp/endpoint.hpp:112:5: warning: template-id not allowed for destructor in C++20 [-Wtemplate-id-cdtor]
  112 |     ~endpoint<connection,config>() {}
      |     ^
src/cxx_supportlib/vendor-modified/websocketpp/websocketpp/endpoint.hpp:112:5: note: remove the ‘< >’
rake aborted!
Command failed with status (1): [c++ -o buildout/support-binaries/WatchdogMain.o  -Isrc/agent -Isrc/cxx_supportlib -Isrc/cxx_supportlib/vendor-copy -Isrc/cxx_supportlib/vendor-modified -I/usr/include/libev -I/usr/include/libuv -Isrc/cxx_supportlib/vendor-modified/websocketpp -D_REENTRANT -I/usr/local/include -Wall -Wextra -Wno-unused-parameter -Wno-parentheses -Wpointer-arith -Wwrite-strings -Wno-long-long -Wno-missing-field-initializers -Wno-unknown-pragmas -feliminate-unused-debug-symbols -feliminate-unused-debug-types -fvisibility=hidden -DVISIBILITY_ATTRIBUTE_SUPPORTED -Wno-attributes -DHAS_ALLOCA_H -DHAVE_ACCEPT4 -DHAS_SFENCE -DHAS_LFENCE -DPASSENGER_DEBUG -DBOOST_DISABLE_ASSERTS -ggdb -std=gnu++11 -Wno-unused-local-typedefs -Wno-format-nonliteral -DHAS_UNORDERED_MAP -g -O2 -ffile-prefix-map=/build/reproducible-path/passenger-6.0.24+ds=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -c src/agent/Watchdog/WatchdogMain.cpp]
/build/reproducible-path/passenger-6.0.24+ds/build/support/cplusplus.rb:53:in `run_compiler'
/build/reproducible-path/passenger-6.0.24+ds/build/support/cplusplus.rb:104:in `compile_cxx'
/build/reproducible-path/passenger-6.0.24+ds/build/support/cplusplus.rb:162:in `block in define_cxx_object_compilation_task'
/usr/share/rubygems-integration/all/gems/rake-13.2.1/exe/rake:27:in `<top (required)>'
Tasks: TOP => fakeroot => apache2 => buildout/support-binaries/PassengerAgent => buildout/support-binaries/WatchdogMain.o
(See full trace by running task with --trace)
make[1]: *** [debian/rules:21: override_dh_auto_build] Error 1
make[1]: Leaving directory '/build/reproducible-path/passenger-6.0.24+ds'
make: *** [debian/rules:18: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2