[Pkg-rust-maintainers] rust-same-file_1.0.2-1_amd64.changes REJECTED

[Josh Triplett]

On Sat, Jul 14, 2018 at 04:37:00AM +0000, Ximin Luo wrote:
> Josh Triplett:
> > (Narrowing to just pkg-rust-maintainers)
> > 
> > On Fri, Jul 13, 2018 at 09:00:09PM +0000, Thorsten Alteholz wrote:
> >>
> >> Hi Sylvestre,
> >>
> >> please also mention
> >>   Copyright 2011, The Snappy-Rust Authors. 
> >> in your debian/copyright. Maybe you can also fix the FIXME?
> > 
> > Didn't debcargo originally have a mechanism to scan the whole source for
> > things that look like copyright notices and copy them into the copyright
> > file?
> > 
> > It seems like that ought to have picked things like this up, unless
> > there's an issue with the regex.
> > 
> 
> It did pick those up, see debcargo-conf.git/src/*/debian/copyright.debcargo.hint.
> 
> We just made manual mistakes in transcribing that over to debian/copyright merging stanzas together etc. Sometimes there are extra copyright holders in LICENSE-* files which it turns out we sometimes accidentally omitted.

What's the reason for manually merging pieces of that into
debian/copyright? While I realize that the automated process might
generate some redundant notices, redundancy isn't *incorrect*, and full
automation would make issues like this much less likely. (Not to mention
making packaging easier, as it would just require a quick review rather
than a manual process.)

> It would be nice to add a pre-release check to verify that all notices in d/copyright.debcargo.hint also exist in d/copyright but this is tricky because sometimes we clean up the notices to be in a uniform format, which is allowed by the Debian rules.

As above: to the extent we can automate that cleanup, by all means lets
do so, but other than that, why not just leave the notices exactly as
they are?