[Pkg-rust-maintainers] Bug#881845: Bug#881845: Bug#881845: rustc: FTBFS on mips*: test failures

[Ximin Luo]

Can you explain what this patch does and file it to Rust upstream first so I can see that they think it's OK?

The first hunk seems like it should be conditioned on the target-architecture being mips64, rather than blanket applied to all architetcures.

I'm also unsure if it's better being applied to ./src/librustc_target/spec/mips64{,el}_unknown_linux_gnuabi64.rs rather than these files.

X

YunQiang Su:
> 1.27.1+dfsg1-1~exp4 still FTBFS.
> As rustc seems need big got.
> 
> --- a/src/bootstrap/bootstrap.py
> +++ b/src/bootstrap/bootstrap.py
> @@ -590,7 +590,7 @@
>          env["LIBRARY_PATH"] = os.path.join(self.bin_root(), "lib") + \
>              (os.pathsep + env["LIBRARY_PATH"]) \
>              if "LIBRARY_PATH" in env else ""
> -        env["RUSTFLAGS"] = "-Cdebuginfo=2"
> +        env["RUSTFLAGS"] = "-Cdebuginfo=2 -Cllvm-args=-mxgot"
>          env["PATH"] = os.path.join(self.bin_root(), "bin") + \
>              os.pathsep + env["PATH"]
>          if not os.path.isfile(self.cargo()):
> --- a/src/vendor/cc/src/lib.rs
> +++ b/src/vendor/cc/src/lib.rs
> @@ -1106,6 +1106,8 @@
>                      cmd.args.push("-mx32".into());
>                  } else if target.contains("x86_64") ||
> target.contains("powerpc64") {
>                      cmd.args.push("-m64".into());
> +                } else if target.contains("mips") {
> +                    cmd.args.push("-mxgot".into());
>                  }
> 
>                  if self.static_flag.is_none() {


-- 
GPG: ed25519/56034877E1F87C35
GPG: rsa4096/1318EFAC5FBBDBCE
https://github.com/infinity0/pubkeys.git