[Pkg-rust-maintainers] Bug#921693: rust-ripgrep uses fixed directory in /tmp, causes FTBFS if multiple people try to build the package on the same system.

peter green plugwash at p10link.net
Thu Feb 7 23:54:23 GMT 2019


Package: rust-ripgrep
Version: 0.10.0-1
Severity: serious

While testing to see if 916615 was still reproducible (it is :( ) I ran into another issue
with the testsuite. By default it uses a fixed directory name in /tmp , specifically
/tmp/ripgrep-tests . If this directory already exists and is owned by another user
the testsuite will fail. A log can be found at

https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=916615;filename=rust-ripgrep.log;msg=19

My soloution was to edit debian/rules to put the temporary directory under the
build tree. Debdiff attatched, no intent to NMU.

-------------- next part --------------
diff -Nru rust-ripgrep-0.10.0/debian/changelog rust-ripgrep-0.10.0/debian/changelog
--- rust-ripgrep-0.10.0/debian/changelog	2018-12-15 10:20:34.000000000 +0000
+++ rust-ripgrep-0.10.0/debian/changelog	2019-02-07 22:48:11.000000000 +0000
@@ -1,3 +1,10 @@
+rust-ripgrep (0.10.0-1.1) UNRELEASED; urgency=medium
+
+  * Use a temporary directory under the package build directory
+    (avoids issues when multiple people build the package on the same machine)
+
+ -- Peter Michael Green <plugwash at debian.org>  Thu, 07 Feb 2019 22:48:11 +0000
+
 rust-ripgrep (0.10.0-1) unstable; urgency=medium
 
   * Package ripgrep 0.10.0 from crates.io using debcargo 2.2.7
diff -Nru rust-ripgrep-0.10.0/debian/rules rust-ripgrep-0.10.0/debian/rules
--- rust-ripgrep-0.10.0/debian/rules	2018-12-15 10:20:34.000000000 +0000
+++ rust-ripgrep-0.10.0/debian/rules	2019-02-07 22:47:56.000000000 +0000
@@ -2,6 +2,16 @@
 %:
 	dh $@ --buildsystem cargo --with bash-completion
 
+export TMPDIR=$(CURDIR)/tmp
+
+override_dh_auto_configure:
+	mkdir -p $(CURDIR)/tmp
+	dh_auto_configure $@
+
+override_dh_auto_clean:
+	dh_auto_clean $@
+	rm -rf $(CURDIR)/tmp
+
 override_dh_install:
 	mkdir -p debian/ripgrep/usr/share/zsh/vendor-completions debian/ripgrep/usr/share/fish/completions
 	cp -f complete/_rg debian/ripgrep/usr/share/zsh/vendor-completions/


More information about the Pkg-rust-maintainers mailing list