[Pkg-rust-maintainers] Bug#941229: Bug#941229: rust-sha1-asm, useless on most architectures.

[Ximin Luo]

peter green:
> package: rust-sha1-asm
> version: 0.4.3-2
> 
> The rust-sha1-asm upstream code outright refuses to build on anything other than x86 and x86_64 . During the debian package build the upstream code is only actually built as part of running the testsuite, not as part of making the package (since Debian rust library packages only ship source code).
> 
> The Debian package currently builds successfully on all Debian architectures but not on raspbian. On further investigation this is because the Debian package built process ignores the testsuite result unless DEB_BUILD_RUST_ARCH matches arm-* x86-* or x86-64-* (note: DEB_BUILD_RUST_ARCH on the debian arm architectures does not match arm-*)
> 
> I can understand building with a testsuite disabled/neutered in cases where some tests fail, but the package appears to be broadly usable, but that does not appear to be the case here. IMO ,unless there is a good reason to do otherwise that I am missing, librust-sha-1-dev and it's reverse dependencies librust-sha-1+asm-dev and librust-sha-1+sha1-asm-dev should only be built on architectures where the code inside can actually be built.
> 

In general, we have to build platform-only crates everywhere due to https://github.com/rust-lang/cargo/issues/5896 and I would guess it's the same with this issue.

So we do have to simply disable the testsuite and build the crate on every architecture.

See also https://salsa.debian.org/rust-team/debcargo/issues/14

X

-- 
GPG: ed25519/56034877E1F87C35
GPG: rsa4096/1318EFAC5FBBDBCE
https://github.com/infinity0/pubkeys.git