[Pkg-rust-maintainers] Bug#992778: rust-thread-local: autopkgtest failure

[peter green]

Package: rust-thread-local
Version: 1.1.3-2
Severity: serious

Rust-thread-local's autopkgtests are failing and blocking it's migration to testing.

https://ci.debian.net/data/autopkgtest/testing/amd64/r/rust-thread-local/14765623/log.gz

>      Running `CARGO=/usr/bin/cargo CARGO_CRATE_NAME=thread_local CARGO_MANIFEST_DIR=/usr/share/cargo/registry/thread_local-1.1.3 CARGO_PKG_AUTHORS='Amanieu d'\''Antras <amanieu at gmail.com>' CARGO_PKG_DESCRIPTION='Per-object thread-local storage' CARGO_PKG_HOMEPAGE='' CARGO_PKG_LICENSE=Apache-2.0/MIT CARGO_PKG_LICENSE_FILE='' CARGO_PKG_NAME=thread_local CARGO_PKG_REPOSITORY='https://github.com/Amanieu/thread_local-rs' CARGO_PKG_VERSION=1.1.3 CARGO_PKG_VERSION_MAJOR=1 CARGO_PKG_VERSION_MINOR=1 CARGO_PKG_VERSION_PATCH=3 CARGO_PKG_VERSION_PRE='' LD_LIBRARY_PATH='/tmp/tmp.OlDihhKdPX/target/debug/deps:/usr/lib' rustc --crate-name thread_local --edition=2018 benches/thread_local.rs --error-format=json --json=diagnostic-rendered-ansi --emit=dep-info,link -Cembed-bitcode=no -C debuginfo=2 --test -C metadata=84c6c306f6e0bed2 -C extra-filename=-84c6c306f6e0bed2 --out-dir /tmp/tmp.OlDihhKdPX/target/x86_64-unknown-linux-gnu/debug/deps --target x86_64-unknown-linux-gnu -C incremental=/tmp/tmp.OlDihhKdPX/target/x86_64-unknown-linux-gnu/debug/incremental -L dependency=/tmp/tmp.OlDihhKdPX/target/x86_64-unknown-linux-gnu/debug/deps -L dependency=/tmp/tmp.OlDihhKdPX/target/debug/deps --extern once_cell=/tmp/tmp.OlDihhKdPX/target/x86_64-unknown-linux-gnu/debug/deps/libonce_cell-453a2446d2f99dbf.rlib --extern thread_local=/tmp/tmp.OlDihhKdPX/target/x86_64-unknown-linux-gnu/debug/deps/libthread_local-f9dcf1a1fea5cb2d.rlib -C debuginfo=2 --cap-lints warn -C linker=x86_64-linux-gnu-gcc -C link-arg=-Wl,-z,relro --remap-path-prefix /usr/share/cargo/registry/thread_local-1.1.3=/usr/share/cargo/registry/thread-local-1.1.3`
> error[E0463]: can't find crate for `criterion`
>  --> benches/thread_local.rs:1:1
>   |
> 1 | extern crate criterion;
>   | ^^^^^^^^^^^^^^^^^^^^^^^ can't find crate
> 
> error: aborting due to previous error
> 
> For more information about this error, try `rustc --explain E0463`.
> error: could not compile `thread_local`.


Looking at the package, it seems some attempt was made to disable criterion, but it doesn't seem to have been
successful with regards to autopkgtests, I'm not sure if there is a sane way to tell autopkgtest not to run
"benches".

In sniffglue I resorted to completely deleting the offending file to solve a similarissie but that is a
pain from a maintenance point of view, so I'd rather not do it in more packages.

I'd rather not completely disable/mark as broken the autopkgtests because they pass in testing, so
it would be a step backwards.

Thoughts on the best way to proceed?