[Pkg-rust-maintainers] Bug#1008847: rust-atk-sys

[Samuel Thibault]

Source: rust-atk-sys
Version: 0.7.0-1
Severity: serious
Tags: upstream patch
Justification: Prevents atk1.0 migration
Control: fixed-upstream -1

Hello,

rust-atk-sys was hardcoding the value of ATK_STATE_LAST_DEFINED,
and thus its autopkgtest fails with the newer atk1.0 package
version 2.38, which introduces ATK_STATE_COLLAPSED thus bumping
ATK_STATE_LAST_DEFINED.  Upstream actually stopped hardcoding the value
in 22f00076493c040b5b20d434bd0348d047027f61 

Until that newer upstream version gets packaged, could you please apply
the attached patch to update ATK_STATE_LAST_DEFINED so atk1.0 version
2.38 can migrate to testing?

Samuel

-- System Information:
Debian Release: bookworm/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 'testing-debug'), (500, 'stable-security'), (500, 'stable-debug'), (500, 'proposed-updates-debug'), (500, 'proposed-updates'), (500, 'oldstable-proposed-updates-debug'), (500, 'oldstable-proposed-updates'), (500, 'oldoldstable'), (500, 'buildd-unstable'), (500, 'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), (1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386, arm64

Kernel: Linux 5.17.0 (SMP w/8 CPU threads; PREEMPT)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

-- 
Samuel
---
Pour une évaluation indépendante, transparente et rigoureuse !
Je soutiens la Commission d'Évaluation de l'Inria.
-------------- next part --------------
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -255,7 +255,8 @@ pub const ATK_STATE_CHECKABLE: AtkStateT
 pub const ATK_STATE_HAS_POPUP: AtkStateType = 40;
 pub const ATK_STATE_HAS_TOOLTIP: AtkStateType = 41;
 pub const ATK_STATE_READ_ONLY: AtkStateType = 42;
-pub const ATK_STATE_LAST_DEFINED: AtkStateType = 43;
+pub const ATK_STATE_COLLAPSED: AtkStateType = 43;
+pub const ATK_STATE_LAST_DEFINED: AtkStateType = 44;
 
 pub type AtkTextAttribute = c_int;
 pub const ATK_TEXT_ATTR_INVALID: AtkTextAttribute = 0;
--- a/tests/abi.rs
+++ b/tests/abi.rs
@@ -829,6 +829,7 @@ const RUST_CONSTANTS: &[(&str, &str)] =
     ("(gint) ATK_STATE_BUSY", "3"),
     ("(gint) ATK_STATE_CHECKABLE", "39"),
     ("(gint) ATK_STATE_CHECKED", "4"),
+    ("(gint) ATK_STATE_COLLAPSED", "43"),
     ("(gint) ATK_STATE_DEFAULT", "36"),
     ("(gint) ATK_STATE_DEFUNCT", "5"),
     ("(gint) ATK_STATE_EDITABLE", "6"),
@@ -844,7 +845,7 @@ const RUST_CONSTANTS: &[(&str, &str)] =
     ("(gint) ATK_STATE_INDETERMINATE", "30"),
     ("(gint) ATK_STATE_INVALID", "0"),
     ("(gint) ATK_STATE_INVALID_ENTRY", "33"),
-    ("(gint) ATK_STATE_LAST_DEFINED", "43"),
+    ("(gint) ATK_STATE_LAST_DEFINED", "44"),
     ("(gint) ATK_STATE_MANAGES_DESCENDANTS", "29"),
     ("(gint) ATK_STATE_MODAL", "14"),
     ("(gint) ATK_STATE_MULTISELECTABLE", "16"),
--- a/tests/constant.c
+++ b/tests/constant.c
@@ -203,6 +203,7 @@ int main() {
     PRINT_CONSTANT((gint) ATK_STATE_BUSY);
     PRINT_CONSTANT((gint) ATK_STATE_CHECKABLE);
     PRINT_CONSTANT((gint) ATK_STATE_CHECKED);
+    PRINT_CONSTANT((gint) ATK_STATE_COLLAPSED);
     PRINT_CONSTANT((gint) ATK_STATE_DEFAULT);
     PRINT_CONSTANT((gint) ATK_STATE_DEFUNCT);
     PRINT_CONSTANT((gint) ATK_STATE_EDITABLE);