[Pkg-rust-maintainers] Bug#1023413: dh-cargo: should prevent dh_clean from removing Cargo.toml.orig
Daniel Kahn Gillmor
dkg at fifthhorseman.net
Wed Nov 23 21:19:49 GMT 2022
Control: tags 1023413 + patch
On Sun 2022-11-20 19:03:08 +0100, Niels Thykier wrote:
> As for doing it, you would be adding:
>
> add_command_options('dh_clean', '-XCargo.toml.orig');
>
> (or something along those lines) to the
> Debian/Debhelper/Sequence/cargo.pm file. It would cover the base case
> where people is using dh with the cargo sequence (and is not overriding
> dh_clean - it might also work for overrides, I do not remember).
>
>
> While you are at it, I can recommend adding `Provides:
> dh-sequence-cargo` to the dh-cargo package. This will enable consumers
> to enable the `cargo` sequence by using `Build-Depends:
> dh-sequence-cargo`. Means less boilerplate for them.
Thanks for these suggestions, Niels. I've submitted some patches to
dh-cargo that should resolve the problem over here:
https://salsa.debian.org/rust-team/dh-cargo/-/merge_requests/8
the relevant changeset is included in the attachment below.
--dkg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Avoid-stripping-Cargo.toml.orig-Closes-1023413.patch
Type: text/x-diff
Size: 1873 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-rust-maintainers/attachments/20221123/818c4c53/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-rust-maintainers/attachments/20221123/818c4c53/attachment.sig>
More information about the Pkg-rust-maintainers
mailing list