[Pkg-rust-maintainers] Bug#1056253: rust-ripasso-cursive - FTBFS with rust-ripasso 0.6.4

[Peter Michael Green]

Package: rust-ripasso-cursive
Version: 0.6.1-1
Severity: serious
Tags: trixie, sid

It appears, that despite the version number indicating a compatible 
release, that the new
version of ripasso broke the build of ripasso-cursive.

https://tests.reproducible-builds.org/debian/rb-pkg/trixie/amd64/rust-ripasso-cursive.html

> error[E0425]: cannot find function `push` in module `pass`
>     --> src/main.rs:941:29
>      |
> 941 |     let push_result = pass::push(&store.lock().unwrap().lock().unwrap());
>      |                             ^^^^ not found in `pass`
>      |
> help: consider importing this function
>      |
> 18  + use ripasso::git::push;
>      |
> help: if you import `push`, refer to it directly
>      |
> 941 -     let push_result = pass::push(&store.lock().unwrap().lock().unwrap());
> 941 +     let push_result = push(&store.lock().unwrap().lock().unwrap());
>      |
>
> error[E0425]: cannot find function `pull` in module `pass`
>     --> src/main.rs:953:19
>      |
> 953 |     let _ = pass::pull(&store.lock().unwrap().lock().unwrap())
>      |                   ^^^^ not found in `pass`
>      |
> help: consider importing this function
>      |
> 18  + use ripasso::git::pull;
>      |
> help: if you import `pull`, refer to it directly
>      |
> 953 -     let _ = pass::pull(&store.lock().unwrap().lock().unwrap())
> 953 +     let _ = pull(&store.lock().unwrap().lock().unwrap())
>      |
>
> error[E0603]: function `init_git_repo` is private
>    --> src/wizard.rs:32:26
>     |
> 32 |     let init_res = pass::init_git_repo(&pass::password_dir(password_store_dir, home).unwrap());
>     |                          ^^^^^^^^^^^^^ private function
>     |
> note: the function `init_git_repo` is defined here
>    --> /usr/share/cargo/registry/ripasso-0.6.4/src/pass.rs:34:60
>     |
> 34 |         add_and_commit_internal, commit, find_last_commit, init_git_repo, match_with_parent,
>     |                                                            ^^^^^^^^^^^^^

I tried to update ripasso-cursive to 0.6.4 to match ripasso but I got.
> Applying patch unbreak-new-user-wizard.patch
> patching file src/main.rs
> Hunk #1 succeeded at 1111 with fuzz 1 (offset -58 lines).
> Hunk #2 FAILED at 1189.
> Hunk #3 succeeded at 1324 with fuzz 1 (offset 109 lines).
> Hunk #4 FAILED at 1773.
> Hunk #5 FAILED at 1789.
> Hunk #6 FAILED at 1798.
> Hunk #7 succeeded at 1849 with fuzz 2 (offset 43 lines).
> 4 out of 7 hunks FAILED -- rejects in file src/main.rs
> Patch unbreak-new-user-wizard.patch does not apply (enforce with -f)

Can someone confirm whether this patch is still needed, and if-so
update it for the new upstream version?


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-rust-maintainers/attachments/20231119/09b7b081/attachment.htm>