[Pkg-rust-maintainers] Bug#1069926: laurel: move from dh-sysuser to standard dh_installsysusers

[Helmut Grohne]

Package: laurel
Version: 0.6.1-1
Severity: wishlist
Tags: patch

Hi,

dh-sysusers exists since 7 years and has gained 9 users in that time -
laurel being one of them. Still it has a number of deficiencies such as
using useradd instead of the policy-recommended adduser or removing
users during package removal against project consensus and is not making
progress on addressing them. Meanwhile, a viable alternative with larger
adoption exists: sysusers.d. This mechanism is built into debhelper and
it no longer requires using systemd as multiple implementations now
exist. I therefore think it is time to call dh-sysusers a failed
experiment and move on. Do you agree with this reasoning? I'm attaching
a patch for your convenience.

Helmut
-------------- next part --------------
diff --minimal -Nru rust-laurel-0.6.1/debian/changelog rust-laurel-0.6.1/debian/changelog
--- rust-laurel-0.6.1/debian/changelog	2024-04-03 17:52:57.000000000 +0200
+++ rust-laurel-0.6.1/debian/changelog	2024-04-27 10:16:01.000000000 +0200
@@ -1,3 +1,10 @@
+rust-laurel (0.6.1-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Move from dh-sysuser to standard dh_installsysusers. (Closes: #-1)
+
+ -- Helmut Grohne <helmut at subdivi.de>  Sat, 27 Apr 2024 10:16:01 +0200
+
 rust-laurel (0.6.1-1) unstable; urgency=medium
 
   * Team upload.
diff --minimal -Nru rust-laurel-0.6.1/debian/control rust-laurel-0.6.1/debian/control
--- rust-laurel-0.6.1/debian/control	2024-04-03 17:52:57.000000000 +0200
+++ rust-laurel-0.6.1/debian/control	2024-04-27 10:14:59.000000000 +0200
@@ -1,7 +1,7 @@
 Source: rust-laurel
 Section: admin
 Priority: optional
-Build-Depends: debhelper (>= 12),
+Build-Depends: debhelper (>= 13.3),
  dh-cargo (>= 25),
  cargo:native,
  rustc:native (>= 1.56),
@@ -36,7 +36,6 @@
  librust-tinyvec-1+default-dev,
  librust-tinyvec-1+serde-dev,
  librust-toml-0.5+default-dev,
- dh-sysuser,
  pandoc
 Maintainer: Debian Rust Maintainers <pkg-rust-maintainers at alioth-lists.debian.net>
 Uploaders:
diff --minimal -Nru rust-laurel-0.6.1/debian/laurel.sysuser rust-laurel-0.6.1/debian/laurel.sysuser
--- rust-laurel-0.6.1/debian/laurel.sysuser	2024-04-03 17:52:57.000000000 +0200
+++ rust-laurel-0.6.1/debian/laurel.sysuser	1970-01-01 01:00:00.000000000 +0100
@@ -1 +0,0 @@
-_laurel home=/var/log/laurel
diff --minimal -Nru rust-laurel-0.6.1/debian/laurel.sysusers rust-laurel-0.6.1/debian/laurel.sysusers
--- rust-laurel-0.6.1/debian/laurel.sysusers	1970-01-01 01:00:00.000000000 +0100
+++ rust-laurel-0.6.1/debian/laurel.sysusers	2024-04-27 10:14:39.000000000 +0200
@@ -0,0 +1 @@
+u	_laurel	-	"daemon user for laurel"	/var/log/laurel	/usr/sbin/nologin
diff --minimal -Nru rust-laurel-0.6.1/debian/rules rust-laurel-0.6.1/debian/rules
--- rust-laurel-0.6.1/debian/rules	2024-04-03 17:52:57.000000000 +0200
+++ rust-laurel-0.6.1/debian/rules	2024-04-27 10:15:36.000000000 +0200
@@ -1,6 +1,6 @@
 #!/usr/bin/make -f
 %:
-	dh $@ --buildsystem cargo --with sysuser
+	dh $@ --buildsystem cargo
 
 override_dh_auto_build:
 	dh_auto_build
@@ -18,3 +18,7 @@
 	dh_install
 	sed -i 's/usr\/local/usr/' debian/laurel/etc/audit/plugins.d/laurel.conf
 	sed -i 's/^read-users/# read-users/' debian/laurel/etc/laurel/config.toml
+
+# Can be dropped in compat 14:
+execute_after_dh_installinit:
+	dh_installsysusers