[Pkg-rust-maintainers] Bug#1108397: rust-fastrand: please enable js feature

[Rene Engelhard]

Source: rust-fastrand

Version: 2.1.1-1

Severity: wishlist


Hi,

I need rust-yrs (see #1108320) which apparently needs the js feature in fastrand (which needs it in getrandom).

I fail to get the debcargo-conf workflow to work so I am filing this bug. Maybe you can have a look?

If I did it manually I'd have done

$ debdiff rust-fastrand_2.1.1-1.dsc rust-fastrand_2.1.1-2.dsc
diff -Nru rust-fastrand-2.1.1/debian/changelog rust-fastrand-2.1.1/debian/changelog
--- rust-fastrand-2.1.1/debian/changelog    2024-10-13 18:35:07.000000000 +0200
+++ rust-fastrand-2.1.1/debian/changelog    2025-06-24 21:25:23.000000000 +0200
@@ -1,3 +1,11 @@
+rust-fastrand (2.1.1-2) UNRELEASED; urgency=medium
+
+  * Team upload
+  * disable no-wasm.diff to get +js feature
+  * add +js Provides. B-D on libgetrandom+js-dev
+
+ -- Rene Engelhard <rene at debian.org>  Tue, 24 Jun 2025 21:25:23 +0200
+
  rust-fastrand (2.1.1-1) unstable; urgency=medium

    * Team upload.
diff -Nru rust-fastrand-2.1.1/debian/control rust-fastrand-2.1.1/debian/control
--- rust-fastrand-2.1.1/debian/control    2024-10-13 18:35:07.000000000 +0200
+++ rust-fastrand-2.1.1/debian/control    2025-06-24 21:25:23.000000000 +0200
@@ -5,7 +5,8 @@
   dh-sequence-cargo,
   cargo:native <!nocheck>,
   rustc:native (>= 1.36) <!nocheck>,
- libstd-rust-dev <!nocheck>
+ libstd-rust-dev <!nocheck>,
+ librust-getrandom+js-dev
  Maintainer: Debian Rust Maintainers <pkg-rust-maintainers at alioth-lists.debian.net>
  Uploaders:
   Andrej Shadura <andrewsh at debian.org>
@@ -23,18 +24,22 @@
  Provides:
   librust-fastrand+alloc-dev (= ${binary:Version}),
   librust-fastrand+default-dev (= ${binary:Version}),
+ librust-fastrand+js-dev (= ${binary:Version}),
   librust-fastrand+std-dev (= ${binary:Version}),
   librust-fastrand-2-dev (= ${binary:Version}),
   librust-fastrand-2+alloc-dev (= ${binary:Version}),
   librust-fastrand-2+default-dev (= ${binary:Version}),
+ librust-fastrand-2+js-dev (= ${binary:Version}),
   librust-fastrand-2+std-dev (= ${binary:Version}),
   librust-fastrand-2.1-dev (= ${binary:Version}),
   librust-fastrand-2.1+alloc-dev (= ${binary:Version}),
   librust-fastrand-2.1+default-dev (= ${binary:Version}),
+ librust-fastrand-2.1+js-dev (= ${binary:Version}),
   librust-fastrand-2.1+std-dev (= ${binary:Version}),
   librust-fastrand-2.1.1-dev (= ${binary:Version}),
   librust-fastrand-2.1.1+alloc-dev (= ${binary:Version}),
   librust-fastrand-2.1.1+default-dev (= ${binary:Version}),
+ librust-fastrand-2.1.1+js-dev (= ${binary:Version}),
   librust-fastrand-2.1.1+std-dev (= ${binary:Version})
  Description: Simple and fast random number generator - Rust source code
   Source code for Debianized Rust crate "fastrand"
diff -Nru rust-fastrand-2.1.1/debian/patches/no-wasm.patch rust-fastrand-2.1.1/debian/patches/no-wasm.patch
--- rust-fastrand-2.1.1/debian/patches/no-wasm.patch    2024-10-13 18:35:07.000000000 +0200
+++ rust-fastrand-2.1.1/debian/patches/no-wasm.patch    1970-01-01 01:00:00.000000000 +0100
@@ -1,35 +0,0 @@
---- a/Cargo.toml
-+++ b/Cargo.toml
-@@ -71,18 +71,18 @@
- default = ["std"]
--js = [
--    "std",
--    "getrandom",
--]
-+#js = [
-+#    "std",
-+#    "getrandom",
-+#]
- std = ["alloc"]
-
--[target.'cfg(all(any(target_arch = "wasm32", target_arch = "wasm64"), target_os = "unknown"))'.dependencies.getrandom]
--version = "0.2"
--features = ["js"]
--optional = true
--
--[target.'cfg(all(any(target_arch = "wasm32", target_arch = "wasm64"), target_os = "unknown"))'.dev-dependencies.getrandom]
--version = "0.2"
--features = ["js"]
-+#[target.'cfg(all(any(target_arch = "wasm32", target_arch = "wasm64"), target_os = "unknown"))'.dependencies.getrandom]
-+#version = "0.2"
-+#features = ["js"]
-+#optional = true
-+
-+#[target.'cfg(all(any(target_arch = "wasm32", target_arch = "wasm64"), target_os = "unknown"))'.dev-dependencies.getrandom]
-+#version = "0.2"
-+#features = ["js"]
-
--[target.'cfg(all(any(target_arch = "wasm32", target_arch = "wasm64"), target_os = "unknown"))'.dev-dependencies.wasm-bindgen-test]
--version = "0.3"
-+#[target.'cfg(all(any(target_arch = "wasm32", target_arch = "wasm64"), target_os = "unknown"))'.dev-dependencies.wasm-bindgen-test]
-+#version = "0.3"
diff -Nru rust-fastrand-2.1.1/debian/patches/series rust-fastrand-2.1.1/debian/patches/series
--- rust-fastrand-2.1.1/debian/patches/series    2024-10-13 18:35:07.000000000 +0200
+++ rust-fastrand-2.1.1/debian/patches/series    2025-06-24 21:25:23.000000000 +0200
@@ -1,4 +1,3 @@
-no-wasm.patch
  disable-benches.patch
  fix-tests-no-default-features.patch
  fix-gated-tests.patch

At least with that fastrand builds fine with +js used from getrandom, too.

Can you please apply/do the right thing to make the same effect?

Regards,

Rene