[Pkg-rust-maintainers] Bug#1108396: rust-getrandom: please enable js feature

[Rene Engelhard]

Source: rust-getrandom
Version: 0.2.15-1
Severity: wishlist

Hi,

I need rust-yrs (see #1108320) which apparently needs the js feature in fastrand (which needs it in getrandom).

I fail to get the debcargo-conf workflow to work so I am filing this bug. Maybe you can have a look?

If I did it manually I'd have done

$ debdiff rust-getrandom_0.2.15-1.dsc rust-getrandom_0.2.15-2.dsc
diff -Nru rust-getrandom-0.2.15/debian/changelog rust-getrandom-0.2.15/debian/changelog
--- rust-getrandom-0.2.15/debian/changelog	2024-12-08 17:48:09.000000000 +0100
+++ rust-getrandom-0.2.15/debian/changelog	2025-06-26 21:41:13.000000000 +0200
@@ -1,3 +1,14 @@
+rust-getrandom (0.2.15-2) UNRELEASED; urgency=medium
+
+  * Team upload
+  * disable drop-js-wasm.patch; add +js to Provides
+  * add librust-wasm-bindgen-test-dev <!nocheck> and
+    librust-js-sys-dev <!nocheck> to B-D
+  * add librust-wasm-bindgen-dev and librust-js-sys-dev to Depends of
+    librust-getrandom-dev
+
+ -- Rene Engelhard <rene at debian.org>  Thu, 26 Jun 2025 21:41:13 +0200
+
  rust-getrandom (0.2.15-1) unstable; urgency=medium
  
    * Package getrandom 0.2.15 from crates.io using debcargo 2.7.5
diff -Nru rust-getrandom-0.2.15/debian/control rust-getrandom-0.2.15/debian/control
--- rust-getrandom-0.2.15/debian/control	2024-12-08 17:48:09.000000000 +0100
+++ rust-getrandom-0.2.15/debian/control	2025-06-26 21:41:13.000000000 +0200
@@ -7,7 +7,9 @@
   rustc:native <!nocheck>,
   libstd-rust-dev <!nocheck>,
   librust-cfg-if-1+default-dev <!nocheck>,
- librust-libc-0.2-dev (>= 0.2.154-~~) <!nocheck>
+ librust-libc-0.2-dev (>= 0.2.154-~~) <!nocheck>,
+ librust-wasm-bindgen-test-dev <!nocheck>,
+ librust-js-sys-dev <!nocheck>
  Maintainer: Debian Rust Maintainers <pkg-rust-maintainers at alioth-lists.debian.net>
  Uploaders:
   kpcyrd <git at rxv.cc>
@@ -24,7 +26,9 @@
  Depends:
   ${misc:Depends},
   librust-cfg-if-1+default-dev,
- librust-libc-0.2-dev (>= 0.2.154-~~)
+ librust-libc-0.2-dev (>= 0.2.154-~~),
+ librust-wasm-bindgen-dev,
+ librust-js-sys-dev
  Suggests:
   librust-getrandom+compiler-builtins-dev (= ${binary:Version}),
   librust-getrandom+core-dev (= ${binary:Version}),
@@ -32,6 +36,7 @@
  Provides:
   librust-getrandom+custom-dev (= ${binary:Version}),
   librust-getrandom+default-dev (= ${binary:Version}),
+ librust-getrandom+js-dev (= ${binary:Version}),
   librust-getrandom+linux-disable-fallback-dev (= ${binary:Version}),
   librust-getrandom+rdrand-dev (= ${binary:Version}),
   librust-getrandom+std-dev (= ${binary:Version}),
@@ -39,6 +44,7 @@
   librust-getrandom-0-dev (= ${binary:Version}),
   librust-getrandom-0+custom-dev (= ${binary:Version}),
   librust-getrandom-0+default-dev (= ${binary:Version}),
+ librust-getrandom-0+js-dev (= ${binary:Version}),
   librust-getrandom-0+linux-disable-fallback-dev (= ${binary:Version}),
   librust-getrandom-0+rdrand-dev (= ${binary:Version}),
   librust-getrandom-0+std-dev (= ${binary:Version}),
@@ -46,6 +52,7 @@
   librust-getrandom-0.2-dev (= ${binary:Version}),
   librust-getrandom-0.2+custom-dev (= ${binary:Version}),
   librust-getrandom-0.2+default-dev (= ${binary:Version}),
+ librust-getrandom-0.2+js-dev (= ${binary:Version}),
   librust-getrandom-0.2+linux-disable-fallback-dev (= ${binary:Version}),
   librust-getrandom-0.2+rdrand-dev (= ${binary:Version}),
   librust-getrandom-0.2+std-dev (= ${binary:Version}),
@@ -53,6 +60,7 @@
   librust-getrandom-0.2.15-dev (= ${binary:Version}),
   librust-getrandom-0.2.15+custom-dev (= ${binary:Version}),
   librust-getrandom-0.2.15+default-dev (= ${binary:Version}),
+ librust-getrandom-0.2.15+js-dev (= ${binary:Version}),
   librust-getrandom-0.2.15+linux-disable-fallback-dev (= ${binary:Version}),
   librust-getrandom-0.2.15+rdrand-dev (= ${binary:Version}),
   librust-getrandom-0.2.15+std-dev (= ${binary:Version}),
diff -Nru rust-getrandom-0.2.15/debian/patches/drop-js-wasm.patch rust-getrandom-0.2.15/debian/patches/drop-js-wasm.patch
--- rust-getrandom-0.2.15/debian/patches/drop-js-wasm.patch	2024-12-08 17:48:09.000000000 +0100
+++ rust-getrandom-0.2.15/debian/patches/drop-js-wasm.patch	1970-01-01 01:00:00.000000000 +0100
@@ -1,28 +0,0 @@
---- a/Cargo.toml
-+++ b/Cargo.toml
-@@ -49,10 +49,6 @@
-
- [features]
- custom = []
--js = [
--    "wasm-bindgen",
--    "js-sys",
--]
- linux_disable_fallback = []
- rdrand = []$ debdiff rust-getrandom_0.2.15-1.dsc rust-getrandom_0.2.15-2.dsc

At least with that fastrand builds fine with +js used from getrandom, too.

Can you please apply/do the right thing to make the same effect?

Regards,

Rene