[Pkg-rust-maintainers] rust-dragonbox-ecma_0.1.12-1_amd64.changes REJECTED

[Juan M. Méndez Rey]

Thanks Reinhard again for your thorough review. 

New MR to address these concerns: 

https://salsa.debian.org/rust-team/debcargo-conf/-/merge_requests/1163

Long explanation: 
I did a doublecheck and certainly we needed to bring the BSD-3 license for 

1. src/to_chars_ecma.rs is a Rust port of V8's DoubleToStringView.

So, added the copyright attribution for the V8 project authors even if he is the same person, and the BSD-3-Clause license text as required by the original license.

2. Regarding the other two files, I checked the upstream git history
(https://github.com/magic-akari/dragonbox) and they are both authored by David Tolnay, not Junekey Jeon or Ulf Adams:

2.1 src/buffer.rs 

First added by David Tolnay, not Junekey Jeon:

$ git log --all --format="%ai %an %s" --diff-filter=A -- src/buffer.rs
2021-07-17 17:33:56 -0700 David Tolnay Copy Buffer API from ryu

Full history (all Tolnay + one magic-akari commit):

$ git log --all --format="%ai %an %s" -- src/buffer.rs
2026-01-03 17:47:09 +0800 magic-akari feat: implement ECMA-262 compliant number formatting
2025-12-13 19:09:28 -0800 David Tolnay Resolve ptr_as_ptr pedantic clippy lint
2025-10-18 08:38:56 -0700 David Tolnay Remove link to closed clippy issue
2025-10-18 08:38:38 -0700 David Tolnay Relocate clippy non_canonical_clone_impl suppression
2025-02-19 19:07:33 -0800 David Tolnay Convert html links to intra-doc links
2023-09-13 22:46:19 -0600 David Tolnay Update name of clippy clone impl lint
2023-07-02 20:36:17 -0700 David Tolnay Suppress incorrect_clone_impl_on_copy_type clippy false positive
2021-07-17 17:35:04 -0700 David Tolnay Write rustdoc
2021-07-17 17:33:56 -0700 David Tolnay Copy Buffer API from ryu

2.3 tests/macros/mod.rs 

Created by David Tolnay, not Ulf Adams:

$ git log --all --format="%ai %an %s" --diff-filter=A -- tests/macros/mod.rs
2021-07-17 17:35:49 -0700 David Tolnay Copy tests from ryu

Both files are correctly covered by the Files: * stanza which credits David Tolnay and magic-akari.

I checked the ryu crate in case there was a different author, but it is Tolnay himself.

Cheers,

Juan


El viernes, 5 de junio de 2026 a las 17:00, Reinhard Tartler <siretart at debian.org> escribió:

> 
> Thanks for your diligence in preparing this package. I've taken a
> look at the licensing and found a couple of spots that could use
> some refinement in debian/copyright to ensure we're covering all
> the bases.
> 
> The most important thing I spotted is that src/to_chars_ecma.rs is
> explicitly described as a port of V8's DoubleToStringView. The code
> itself contains several functions labeled as V8's (like
> convert_2_digits, convert_8_digits, etc.). Since porting code
> creates a derivative work under copyright law, we're legally
> required by V8's BSD-3-Clause license to preserve their copyright
> notice and license text.
> 
> This looks like a bit of a licensing omission by upstream—while the
> comment attribution is great, it doesn't quite satisfy the BSD
> requirement to include the actual license boilerplate. It would be
> best if this were sorted out upstream eventually, but for now, we
> absolutely need to document the V8 project authors' copyright and
> the BSD-3-Clause text in debian/copyright to ensure the Debian
> package is legally sound.
> 
> I also noticed that src/buffer.rs and src/to_chars_ecma.rs are
> missing from the specific src/*.rs section that credits Junekey
> Jeon. While src/to_chars_ecma.rs is a V8 port, src/buffer.rs seems
> to be part of the core logic that Junekey Jeon originally authored
> in the dragonbox crate. Similarly, tests/macros/mod.rs is missing
> from the section covering the tests authored by Ulf Adams. Adding
> these specifically would make the file coverage much clearer.
> 
> Everything else looks solid. Once these attributions are tidied up,
> the package should be in great shape.
> 
> -rt
> 
> Further information may be found at:
>    https://dfsg-new-queue.debian.org/reviews/rust-dragonbox-ecma
> 
> Regards, Reinhard Tartler
> Member of the DFSG, Licensing & New Packages Team
> 
> 
> 
> ===
> 
> Please feel free to respond to this email if you don't understand why
> your files were rejected, or if you upload new files which address our
> concerns.
> 
>