[Pkg-rust-maintainers] Debian NEW review of rust-hdrhistogram 7.6.0-1: ACCEPTED

[awm at debian.org]

This is an automated message from the Debian DFSG, Licensing & New
Packages Team.

The Debian NEW review of rust-hdrhistogram 7.6.0-1 has been completed.

Decision: ACCEPTED
Reviewer: Andrew McMillan

Review comment:

Hi,

A couple of minor issues that could be fixed...

1. [minor] [packaging] update-base64.diff is obsolete for the 7.6.0 sources

 - Files: `debian/patches/update-base64.diff; tests/interval_log.rs (import block)`
 - Evidence: The diff adds `use base64::Engine;` to tests/interval_log.rs. The pristine 7.6.0 file (in the orig tarball) already contains `use base64::Engine as _;` and `B64STANDARD.decode(...)`, and src/serialization/interval_log/mod.rs:221 already has `use base64::Engine as _;` with `base64::engine::general_purpose::STANDARD` usage — i.e. upstream 7.6.0 is already on the 0.22 API. After patch application the file ends up with both `use base64::Engine as _;` and `use base64::Engine;`, the latter being an unused import (warning, not error).
 - Problem: This patch was needed for the 7.5.2 base64 0.21->0.22 bump and is now dead weight against 7.6.0: it applies cleanly (so the series still builds) but adds a redundant import and means the package carries a patch that upstream has already absorbed, which a sponsor would expect to be dropped.
 - Fix: Remove update-base64.diff and its line from debian/patches/series, then rebuild/retest to confirm the unused-import warning disappears and tests still pass.

2. [minor] [packaging] Four of the five patches lack DEP-3 headers

 - Files: `debian/patches/eliminate-ieee754-dev-depends.diff, eliminate-rug-dev-depends.diff, fix-tests-no-default-features.diff, update-base64.diff` - Evidence: Each of these diffs starts directly with the `Index:`/diff hunks; only fix-racy-sync-tests.diff carries Description/Author/Origin/Forwarded/Last-Update headers.
 - Problem: Without DEP-3 headers (Description, Origin, Forwarded, Last-Update) the purpose and provenance of the patches — in particular who to forward the fixes to and that the upstream PR for fix-racy-sync-tests.diff (#151) is tracked — are not documented, and obsolete patches (see update-base64.diff) are hard to identify.
 - Fix: Add DEP-3 headers to the four headerless patches, noting Forwarded for any that should be proposed upstream (e.g.  fix-tests-no-default-features.diff), or drop the obsolete update-base64.diff.


Thanks!

Full review details: https://dfsg-new-queue.debian.org/reviews/rust-hdrhistogram