[Pkg-rust-maintainers] Debian NEW review of rust-hashify 0.3.1-1: ACCEPTED

Peter Green plugwash at debian.org
Mon Oct 12 22:51:36 BST 2026


> one minor issue that you should consider:
> 
> Autopkgtest entry `--no-default-features` is restricted to `Architecture: !riscv64` without any stated reason
> 
>  - **Files:** `debian/tests/control`
>  - **Evidence:** `Architecture: !riscv64` on the third stanza only (`cargo-auto-test hashify 0.3.1 --all-targets --no-default-features`); the other two entries run everywhere. The crate has no features, so the restriction can only come from a real test failing on riscv64.
>  - **Problem:** The exclusion is unexplained, so a reviewer cannot tell whether it papers over a genuine crate bug on riscv64 (in which case it should be forwarded upstream as a bug) or whether it is spurious CI loss. A one-line justification in debian/tests/control or a comment would resolve it.
>  - **Fix:** Add a comment in debian/tests/control explaining why riscv64 is excluded from that test run, or drop the restriction if it is no longer needed.

FYI in debcargo we limit tests on riscv64 to the "default-features" and "all-features"
tests because we were having lots of problems with tests timing out.

There is definitely an argument though that we should make debcargo's test
generation special-case crates with no features, as right now we are
generating three tests that essentially test the same thing.




More information about the Pkg-rust-maintainers mailing list