[Pkg-rust-maintainers] Bug#796256: Bug#796256: Bug#796256: Bug#796256: Bug#796256: Bug#796256: Please consider packaging a Rust version that allows #![feature(...)]

[Ximin Luo]

On 31/08/15 08:59, Sylvestre Ledru wrote:
> Le 31/08/2015 00:22, Ximin Luo a écrit :
>> I built these source packages using the attached script:
>>
>> Version 1.2.0.20150812.beta+dfsg1-1
>> Version 1.2.0.20150830.nightly+dfsg1-1
>> https://mentors.debian.net/package/rustc
>>
>> I haven't yet built binary packages out of them, though - the tests keep failing. Next, I will play around with giving DEB_BUILD_OPTIONS=nocheck to cowbuilder.
> What kind of failure?

>From building 1.2.0.20150812.beta+dfsg1-1 (I haven't yet tried nightly):

failures:

---- [run-pass] run-pass/issue-26468.rs stdout ----
	
error: test run failed!
status: exit code: 101
command: x86_64-unknown-linux-gnu/test/run-pass/issue-26468.stage2-x86_64-unknown-linux-gnu 
stdout:
------------------------------------------

------------------------------------------
stderr:
------------------------------------------
thread '<main>' panicked at 'assertion failed: `(left == right)` (left: `42`, right: `19`)', /tmp/buildd/rustc-1.2.0.20150812.beta+dfsg1/src/test/run-pass/issue-26468.rs:37

------------------------------------------

thread '[run-pass] run-pass/issue-26468.rs' panicked at 'explicit panic', /tmp/buildd/rustc-1.2.0.20150812.beta+dfsg1/src/compiletest/runtest.rs:1490


---- [run-pass] run-pass/wait-forked-but-failed-child.rs stdout ----
	
error: test run failed!
status: exit code: 101
command: x86_64-unknown-linux-gnu/test/run-pass/wait-forked-but-failed-child.stage2-x86_64-unknown-linux-gnu 
stdout:
------------------------------------------

------------------------------------------
stderr:
------------------------------------------
thread '<main>' panicked at 'called `Result::unwrap()` on an `Err` value: Error { repr: Os { code: 2, message: "No such file or directory" } }', src/libcore/result.rs:732

------------------------------------------

thread '[run-pass] run-pass/wait-forked-but-failed-child.rs' panicked at 'explicit panic', /tmp/buildd/rustc-1.2.0.20150812.beta+dfsg1/src/compiletest/runtest.rs:1490



failures:
    [run-pass] run-pass/issue-26468.rs
    [run-pass] run-pass/wait-forked-but-failed-child.rs

test result: FAILED. 2179 passed; 2 failed; 4 ignored; 0 measured

>>
>> Some notes:
>>
>> - we could probably come up with a better system for the version strings
> dates + changeset?
>> - for the nightly, I dropped debian/patches/fix-test-llvm-3.6.diff which seems to have been applied upstream
> Indeed.
>> - for some reason we bundle a src/etc/snapshot.pyc in the .debian.tar.gz and force it to be ignored with debian/source/include-binaries, wtf?
> Please avoid using "wtf" in this kind of discussion.
> About the issue itself, I saw it too but didn't bother investigating it.
> No big deal anywayy.

well, it is probably against policy.

>> - both beta and nightly have upgraded to jquery 2.1.4 but my upgrade script doesn't account for this
> should be trivial.
>> - pretty sure we can symlink jquery.js in debian/rust-doc.links instead of having debian/rules explicitly do it
> I would be happy to apply a patch.
>> - not sure what to do with the libstd-rust-xxxx stuff. I couldn't find the id anywhere in the upstream source, even in the current debian sid version. Also, will we continue to keep adding the old package versions to Replaces/Breaks? This seems unsustainable.
> We are aware of this and we decided to take this approach on purpose for
> now. This is not perfect but as rust is a moving target,
> we took this shortcut. We hope they will be able to improve/fix that
> upstream in the near future.
> 

How is the hash generated and how do we guarantee that our hash matches with upstream's hash? Is there a way to calculate the hash *before* doing the build?

FWIW, the hash for beta 20150812.beta is 198068b3, so anyone building the about source package I made, needs to make further edits to change it so. I can currently build only using cowbuilder because of the libstdc++6 transitions, so looks like I will have to do it again, sigh.

X

-- 
GPG: 4096R/1318EFAC5FBBDBCE
git://github.com/infinity0/pubkeys.git