[Pkg-rust-maintainers] Not embedding jquery

[Ximin Luo]

Angus Lees:
> On Tue, 16 Aug 2016 at 06:13 Ximin Luo <infinity0 at debian.org> wrote:
> 
>> Angus Lees:
>>> I think your patch also needs a rustdoc run-time dependency on
>> libjs-jquery.
>>> If we're going to remove it from the repacked upstream source, then we
>> can
>>> also remove the un-minified source in debian/missing-sources/
>>>
>>
>> [..] Apparently rust-doc already has a dependency on libjs-jquery.
>>
> 
> No, I meant rustdoc-the-executable (aka binary:rustc) needs a runtime
> dependency on libjs-jquery, since it (with your patch) attempts to symlink
> to the file from libjs-jquery.
> 
> But that isn't strictly correct either.  With your patch, all *generated*
> docs need a dependency on libjs-jquery, otherwise they have a broken
> symlink.  I don't know what we want to do about that, but I feel like
> rustc.deb should at least suggest libjs-jquery now (and perhaps even
> depend).
> 

Yes, in my patch both rustc and rust-doc have Depends: libjs-jquery. rust-doc already has this from the existing packaging, even though it's not using it.

Right, good point about adding depends to generated docs, that is another user-visible change.

But I suppose at least in the meantime we can go for copying, then have debian/rules additionally replace this with a symlink for the rust-doc binary package.

X

-- 
GPG: ed25519/56034877E1F87C35
GPG: rsa4096/1318EFAC5FBBDBCE
https://github.com/infinity0/pubkeys.git