[Pkg-salt-team] Init files

[Joe Healy]

Hi Franklin,

I've finally had a chance to review your init files.

1) It is different to any other init file I have ever read.

It uses many if statements, which I have not seen before. Normally
these init files seem to use || and case statements for control.

2) I think the line widths should be less than 80 characters. Probably
less than 78 or 76.

3) It doesn't use functions like do_start, do_stop etc.

Although the simplicity of the script may not warrant them in
isolation, it may be worth having them in to be consistent with other
init scrips and also possibly to allow calling these from other
scrips.

4) Is it worth working from an example like init.d.ex from running dh_make?

I'm interested in both others feedback and also feedback on my
feedback. If either could be provided I (and I presume Franklin) would
be most grateful.

Cheers and Thanks,

Joe