[Pkg-salt-team] Fwd: Init files

[Joe Healy]

We forgot to include the list. Apologies.

Joe

---------- Forwarded message ----------
From: Franklin G. Mendoza <franklin.g.mendoza at gmail.com>
Date: Wed, Apr 24, 2013 at 9:58 PM
Subject: Re: [Pkg-salt-team] Init files
To: Joe Healy <joehealy at gmail.com>


Hi Joe,

My mistake :( i forgot to do a "reply all"

You can forward it! :)

Good night friend,

El 23/04/2013 08:48, "Joe Healy" <joehealy at gmail.com> escribió:

> Morning Franklin,
>
> I hope my comments weren't to harsh.
>
> I basically put down everything I could think of that looked different
> to what I had seen before.
>
> I'd think i'd be happy to deploy with these, but I suspect there are
> stylistic things ulrich referred to.
>
> I am hoping to get some feedback from madduck and ulrich, but I think
> we also need to be having a go. I'm feeling very new at all elements
> of this...
>
> The other thing is I think you replied to just me rather than the
> mailing list. Was this deliberate?
>
> Hope things are going well.
>
> Joe
>
>
>
> On Tue, Apr 23, 2013 at 11:03 PM, Franklin G. Mendoza
> <franklin.g.mendoza at gmail.com> wrote:
> > Hi Joe
> >
> > 2013/4/22 Joe Healy <joehealy at gmail.com>:
> >> Hi Franklin,
> >>
> >> I've finally had a chance to review your init files.
> >>
> >> 1) It is different to any other init file I have ever read.
> >>
> >> It uses many if statements, which I have not seen before. Normally
> >> these init files seem to use || and case statements for control.
> >>
> >
> > There is only 2 if statements one for validates the status "start" and
> > another for "stop"
> >
> > This statements these are within the start and stop cases statements.
> >
> >> 2) I think the line widths should be less than 80 characters. Probably
> >> less than 78 or 76.
> >
> > I must re-read the init files and configure vim then.
> >
> >>
> >> 3) It doesn't use functions like do_start, do_stop etc.
> >
> > This is necessary? i read another init files (squid and cups) and do
> > not have it.
> >
> >>
> >> Although the simplicity of the script may not warrant them in
> >> isolation, it may be worth having them in to be consistent with other
> >> init scrips and also possibly to allow calling these from other
> >> scrips.
> >
> > The current file (in repo) have a integration with anothers daemos?
> >
> >>
> >> 4) Is it worth working from an example like init.d.ex from running dh_make?
> >
> > Yes, and i don't see any difference except in the log_{end,failure,
> > daemon}_msg used.
> >>
> >> I'm interested in both others feedback and also feedback on my
> >> feedback. If either could be provided I (and I presume Franklin) would
> >> be most grateful.
> >
> > Of course! :D
> >
> >>
> >> Cheers and Thanks,
> >>
> >> Joe
> >>
> >
> > Cheers,
> >
> > Franklin
> >
> >>
> >>
> >> On Fri, Apr 19, 2013 at 2:56 AM, Franklin G. Mendoza
> >> <franklin.g.mendoza at gmail.com> wrote:
> >>> Hi team,
> >>>
> >>> I upload the new init files to a new branch named "init_files".
> >>>
> >>> Cheers,
> >>>
> >>> Franklin.
> >>>
> >>>
> >>> 2013/4/17 Franklin G. Mendoza <franklin.g.mendoza at gmail.com>:
> >>>> Hi Joe,
> >>>>
> >>>> Thank you so much Joe.
> >>>>
> >>>> 2013/4/17 Joe Healy <joehealy at gmail.com>:
> >>>>> On Thu, Apr 18, 2013 at 7:07 AM, Franklin G. Mendoza
> >>>>> <franklin.g.mendoza at gmail.com> wrote:
> >>>>>
> >>>>>> Now i need to know which branch i should upload it and without
> >>>>>> generate problems.
> >>>>>
> >>>>> I think create a new branch and commit them there.
> >>>>>
> >>>>> From memory:
> >>>>>
> >>>>> git checkout -b update_init_files
> >>>>>
> >>>>>
> >>>>> then do your commit (just the updated files).
> >>>>>
> >>>>> I think you will then need to do a git push --all.
> >>>>>
> >>>>> Pull it down to a new repository to check if you have it right.
> >>>>>
> >>>>> I'm at a conference this week, so I've been a little quiet, but should
> >>>>> have a chance to look at things tonight.
> >>>>>
> >>>>
> >>>> don't worry
> >>>>
> >>>>> Joe
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>>>
> >>>>>>
> >>>>>> Thanks,
> >>>>>>
> >>>>>> Franklin
> >>>>>>
> >>>>
> >>>> Cheers
> >>>>
> >>>> Franklin
> >>>>
> >>>>>> _______________________________________________
> >>>>>> pkg-salt-team mailing list
> >>>>>> pkg-salt-team at lists.alioth.debian.org
> >>>>>> https://lists.alioth.debian.org/mailman/listinfo/pkg-salt-team
> >>>>>
> >>>>> _______________________________________________
> >>>>> pkg-salt-team mailing list
> >>>>> pkg-salt-team at lists.alioth.debian.org
> >>>>> https://lists.alioth.debian.org/mailman/listinfo/pkg-salt-team
> >>>
> >>> _______________________________________________
> >>> pkg-salt-team mailing list
> >>> pkg-salt-team at lists.alioth.debian.org
> >>> https://lists.alioth.debian.org/mailman/listinfo/pkg-salt-team