[Pkg-salt-team] Bug#921631: salt-master: gitfs requires git when using pygit2 as gitfs_provider

[Malcolm Acker]

Package: salt-master
Version: 2018.3.3+dfsg1-2
Severity: normal

Dear Maintainer,

When using pygit2 as the gitfs_provider critical errors are thrown in the error log if the git package is not installed:
  2019-02-07 07:44:20,180 [salt.utils.gitfs :2565][ERROR   ][2577] The git command line utility is required when using the 'pygit2' gitfs_provider.
  2019-02-07 07:44:20,181 [salt.utils.gitfs :2468][CRITICAL][2577] No suitable gitfs provider module is installed.
  2019-02-07 07:44:20,185 [salt.loader      :1702][ERROR   ][2577] Failed to load function git.envs because its module (git) is not in the whitelist: ['gitfs', 'roots']

Installing the Debian git package and restarting salt-master resolves this issue.  I have briefly tested the pygit2 python module (https clone, commit log listing) and it does not appear the python module on it's own requires the git binary.

-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-2-amd64 (SMP w/1 CPU core)
Kernel taint flags: TAINT_BAD_PAGE, TAINT_DIE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages salt-master depends on:
ii  adduser          3.118
ii  lsb-base         10.2018112800
ii  python3          3.7.2-1
ii  python3-crypto   2.6.1-9+b1
ii  python3-systemd  234-2+b1
ii  python3-zmq      17.1.2-2
ii  salt-common      2018.3.3+dfsg1-2

Versions of packages salt-master recommends:
ii  python3-pygit2  0.27.4-1

salt-master suggests no packages.

-- Configuration Files:
/etc/salt/master changed [not included]

-- no debconf information