[Pkg-salt-team] Bug#922352: salt autopkgtests fail on kernels with no Xen support

[Steve Langasek]

Source: salt
Version: 2018.3.4~git20180207+dfsg1-1
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu disco

Dear maintainers,

The latest version of salt is failing its autopkgtests on ppc64el and s390x
architectures in Ubuntu:

[...]
FAIL: test_xen_virtual (unit.grains.test_core.CoreGrainsTestCase)
[CPU:0.0%|MEM:53.3%] 
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/autopkgtest.V5NGQK/autopkgtest_tmp/tests/unit/grains/test_core.py", line 701, in test_xen_virtual
    'Xen PV DomU'
AssertionError: None != 'Xen PV DomU'

----------------------------------------------------------------------
Ran 7575 tests in 3249.235s
[...]

  (http://autopkgtest.ubuntu.com/packages/s/salt/disco/ppc64el)

The cause of this failure is an improper test which mocks up an isfile check
for /sys/bus/xen/drivers/xenconsole, but which doesn't also mock up the
check for the /sys/bus/xen directory; so if run on a kernel with no Xen
support at all, the test will fail.

The test happens to pass on the other architectures on which Ubuntu runs
autopkgtests, because these happen to be architectures which have Xen
support and Xen happens to be enabled in the kernels on these architectures. 
But it's a bad test that depends on the kernel instead of actually unit
testing the code, so that really ought to be fixed upstream.

For now, the test results on ppc64el and s390x will be ignored in Ubuntu for
package migration.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-salt-team/attachments/20190214/c8b79ba9/attachment.sig>