[Pkg-salt-team] Bug#954154: src:salt: Requires a package outside of Main

[Scott Kitterman]

Package: src:salt
Version: 3000+dfsg1-3
Severity: serious
Justification: Policy 2.2.1

This package uses python pip to download and install packages from outside the
Debian archive to run autopkgtests.  Main is required to be self-contained,
including for tests.  See the FTP Master's reject FAQ [1] item Non-Main II.

An excerpt from a recent autpkgtest log is included below to demonstrate the
issue with this package.  Note that while there is a tracback that looks
like a pip issue, installing pep8 with pip works outside the salt
autopkgtest.  It's not enough that something be available from Main, you
actually have to use it.

In any case, the autopkgtest fails, so this has to be addressed
regardless.

Scott K

[1] https://ftp-master.debian.org/REJECT-FAQ.html

======================================================================
ERROR: test_install_requirements_parsing (unit.states.test_pip_state.PipStateTest)
[CPU:0.0%|MEM:15.7%] 
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/autopkgtest-lxc.hrrvw95w/downtmp/autopkgtest_tmp/tests/unit/states/test_pip_state.py", line 66, in test_install_requirements_parsing
    ret = pip_state.installed('pep8=1.3.2')
  File "/usr/lib/python3/dist-packages/salt/states/pip_state.py", line 794, in installed
    out = _check_pkg_version_format(pkg)
  File "/usr/lib/python3/dist-packages/salt/states/pip_state.py", line 211, in _check_pkg_version_format
    install_req = _from_line(pkg)
  File "/usr/lib/python3/dist-packages/salt/states/pip_state.py", line 147, in _from_line
    import pip._internal.req.constructors  # pylint: disable=E0611,E0401
  File "/usr/lib/python3/dist-packages/pip/_internal/req/__init__.py", line 11, in <module>
    from .req_file import parse_requirements
  File "/usr/lib/python3/dist-packages/pip/_internal/req/req_file.py", line 19, in <module>
    from pip._internal.cli import cmdoptions
  File "/usr/lib/python3/dist-packages/pip/_internal/cli/cmdoptions.py", line 28, in <module>
    from pip._internal.models.target_python import TargetPython
  File "/usr/lib/python3/dist-packages/pip/_internal/models/target_python.py", line 3, in <module>
    from pip._internal.pep425tags import get_supported, version_info_to_nodot
  File "/usr/lib/python3/dist-packages/pip/_internal/pep425tags.py", line 7, in <module>
    from pip._vendor.packaging.tags import (
ImportError: cannot import name 'compatible_tags' from 'pip._vendor.packaging.tags' (/usr/lib/python3/dist-packages/packaging/tags.py)

----------------------------------------------------------------------
Ran 8922 tests in 2132.334s

FAILED (errors=1, skipped=989, expected failures=1)
autopkgtest [06:37:27]: test unittest: -----------------------]
autopkgtest [06:37:27]: test unittest:  - - - - - - - - - - results - - - - - - - - - -
unittest             FAIL non-zero exit status 1