[Pkg-salt-team] Bug#955057: salt: FTBFS with Sphinx 2.4: AttributeError: __enter__

[Lucas Nussbaum]

Source: salt
Version: 3000+dfsg1-3
Severity: important
Tags: ftbfs
User: python-modules-team at lists.alioth.debian.org
Usertags: sphinx2.4

Hi,

salt fails to build with Sphinx 2.4, currently available in
experimental.

Relevant part (hopefully):
> make[2]: Entering directory '/<<PKGBUILDDIR>>/doc'
> /usr/share/sphinx/scripts/python3/sphinx-build -b html -d _build/doctrees   . _build/html
> Running Sphinx v2.4.3
> loading translations [en]... done
> making output directory... done
> [autosummary] generating autosummary for: contents.rst, faq.rst, glossary.rst, ref/auth/all/index.rst, ref/auth/all/salt.auth.auto.rst, ref/auth/all/salt.auth.django.rst, ref/auth/all/salt.auth.file.rst, ref/auth/all/salt.auth.keystone.rst, ref/auth/all/salt.auth.ldap.rst, ref/auth/all/salt.auth.mysql.rst, ..., topics/using_salt.rst, topics/utils/index.rst, topics/venafi/index.rst, topics/virt/disk.rst, topics/virt/index.rst, topics/virt/nic.rst, topics/windows/index.rst, topics/windows/windows-package-manager.rst, topics/windows/windows-specific-behavior.rst, topics/yaml/index.rst
> /<<PKGBUILDDIR>>/salt/modules/boto_route53.py:161: SyntaxWarning: "is not" with a literal. Did you mean "!="?
>   while marker is not '':
> /<<PKGBUILDDIR>>/salt/utils/schedule.py:724: SyntaxWarning: "is not" with a literal. Did you mean "!="?
>   if key is not 'kwargs':
> /<<PKGBUILDDIR>>/salt/states/user.py:155: SyntaxWarning: "is not" with a literal. Did you mean "!="?
>   if expire and expire is not -1 and salt.utils.dateutils.strftime(lshad['expire']) != salt.utils.dateutils.strftime(expire):
> /<<PKGBUILDDIR>>/salt/states/git.py:2467: SyntaxWarning: "is" with a literal. Did you mean "=="?
>   if remote_rev_type is 'hash':
> /<<PKGBUILDDIR>>/salt/states/git.py:2646: SyntaxWarning: "is" with a literal. Did you mean "=="?
>   if remote_rev_type is 'hash':
> /<<PKGBUILDDIR>>/salt/cloud/clouds/softlayer_hw.py:140: SyntaxWarning: "is" with a literal. Did you mean "=="?
>   if location.get('isAvailable', 0) is 0:
> /<<PKGBUILDDIR>>/salt/modules/virt.py:4735: SyntaxWarning: "is not" with a literal. Did you mean "!="?
>   kind = option_kind if option_kind is not 'vol' else 'volume'
> /<<PKGBUILDDIR>>/salt/states/debconfmod.py:213: SyntaxWarning: "is" with a literal. Did you mean "=="?
>   if ret['comment'] is '':
> /<<PKGBUILDDIR>>/salt/modules/win_ip.py:345: SyntaxWarning: "is" with a literal. Did you mean "=="?
>   if addrs is () or str(addrs[0]).lower() == 'none':
> /<<PKGBUILDDIR>>/salt/modules/win_system.py:1152: SyntaxWarning: "is not" with a literal. Did you mean "!="?
>   if succeeded is not 0:
> /<<PKGBUILDDIR>>/salt/modules/mongodb.py:487: SyntaxWarning: "is not" with a literal. Did you mean "!="?
>   if len(objs) is not 2:
> /<<PKGBUILDDIR>>/salt/states/mysql_grants.py:170: SyntaxWarning: "is" with a literal. Did you mean "=="?
>   my_db = __salt__['mysql.quote_identifier'](my_db, (my_table is '*'))
> /<<PKGBUILDDIR>>/salt/utils/win_pdh.py:167: SyntaxWarning: "is" with a literal. Did you mean "=="?
>   if win32pdh.ValidatePath(path) is 0:
> /<<PKGBUILDDIR>>/salt/modules/lxd.py:1827: SyntaxWarning: "is" with a literal. Did you mean "=="?
>   if uid or uid is '0':
> /<<PKGBUILDDIR>>/salt/modules/lxd.py:1831: SyntaxWarning: "is" with a literal. Did you mean "=="?
>   if gid or gid is '0':
> /<<PKGBUILDDIR>>/salt/modules/x509.py:134: SyntaxWarning: "is not" with a literal. Did you mean "!="?
>   value.strip('0123456789abcdefABCDEF:') is not '':
> /<<PKGBUILDDIR>>/salt/modules/iptables.py:908: SyntaxWarning: "is" with a literal. Did you mean "=="?
>   if position is 0:
> /<<PKGBUILDDIR>>/salt/modules/iptables.py:1043: SyntaxWarning: "is not" with a literal. Did you mean "!="?
>   if parsed_args[arg] and arg is not 'append':
> /<<PKGBUILDDIR>>/salt/modules/win_lgpo.py:4695: SyntaxWarning: "is" with a literal. Did you mean "=="?
>   elif val is 'Not Configured':
> /<<PKGBUILDDIR>>/salt/modules/file.py:2751: SyntaxWarning: "is not" with a literal. Did you mean "!="?
>   has_changes = diff is not ''
> /<<PKGBUILDDIR>>/salt/output/highstate.py:212: SyntaxWarning: "is not" with a literal. Did you mean "!="?
>   if isinstance(info, dict) and tname is not 'changes' and info and '__run_num__' not in info:
> 
> Exception occurred:
>   File "/usr/lib/python3/dist-packages/sphinx/ext/intersphinx.py", line 233, in load_mappings
>     with concurrent.futures.ThreadPoolExecutor() as pool:
> AttributeError: __enter__
> The full traceback has been saved in /tmp/sphinx-err-r3r4hnih.log, if you want to report the issue to the developers.
> Please also report this if it was a user error, so that a better error message can be provided next time.
> A bug report can be filed in the tracker at <https://github.com/sphinx-doc/sphinx/issues>. Thanks!
> make[2]: *** [Makefile:56: html] Error 2

The full build log is available from:
   http://qa-logs.debian.net/2020/03/26/salt_3000+dfsg1-3_unstable_sphinx243.log

Please see [1] for Sphinx changelog, which may give a hint of what changes in
Sphinx caused this error.

Also see [2] for the list of deprecated/removed APIs and possible alternatives
to them.

Sphinx 2.4 is going to be uploaded to unstable in a couple of weeks. When that
happens, the severity of this bug will be bumped to serious.

In case you have questions, please Cc sphinx at packages.debian.org on reply.

[1]: https://www.sphinx-doc.org/en/2.0/changes.html
[2]: https://www.sphinx-doc.org/en/2.0/extdev/deprecated.html#dev-deprecated-apis

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.