[Pkg-salt-team] Bug#954154: Bug#954154: src:salt: Requires a package outside of Main

[Benjamin Drung]

Hi,

Am Dienstag, den 17.03.2020, 09:47 -0400 schrieb Scott Kitterman:
> Package: src:salt
> Version: 3000+dfsg1-3
> Severity: serious
> Justification: Policy 2.2.1
> 
> This package uses python pip to download and install packages from
> outside the
> Debian archive to run autopkgtests.  Main is required to be self-
> contained,
> including for tests.  See the FTP Master's reject FAQ [1] item Non-
> Main II.

I disabled all test cases that need Internet access. So no pip install
should be executed.

> ======================================================================
> ERROR: test_install_requirements_parsing (unit.states.test_pip_state.PipStateTest)
> [CPU:0.0%|MEM:15.7%] 
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/tmp/autopkgtest-lxc.hrrvw95w/downtmp/autopkgtest_tmp/tests/unit/states/test_pip_state.py", line 66, in test_install_requirements_parsing
>     ret = pip_state.installed('pep8=1.3.2')
>   File "/usr/lib/python3/dist-packages/salt/states/pip_state.py", line 794, in installed
>     out = _check_pkg_version_format(pkg)
>   File "/usr/lib/python3/dist-packages/salt/states/pip_state.py", line 211, in _check_pkg_version_format
>     install_req = _from_line(pkg)
>   File "/usr/lib/python3/dist-packages/salt/states/pip_state.py", line 147, in _from_line
>     import pip._internal.req.constructors  # pylint: disable=E0611,E0401
>   File "/usr/lib/python3/dist-packages/pip/_internal/req/__init__.py", line 11, in <module>
>     from .req_file import parse_requirements
>   File "/usr/lib/python3/dist-packages/pip/_internal/req/req_file.py", line 19, in <module>
>     from pip._internal.cli import cmdoptions
>   File "/usr/lib/python3/dist-packages/pip/_internal/cli/cmdoptions.py", line 28, in <module>
>     from pip._internal.models.target_python import TargetPython
>   File "/usr/lib/python3/dist-packages/pip/_internal/models/target_python.py", line 3, in <module>
>     from pip._internal.pep425tags import get_supported, version_info_to_nodot
>   File "/usr/lib/python3/dist-packages/pip/_internal/pep425tags.py", line 7, in <module>
>     from pip._vendor.packaging.tags import (
> ImportError: cannot import name 'compatible_tags' from 'pip._vendor.packaging.tags' (/usr/lib/python3/dist-packages/packaging/tags.py)
> 
> ----------------------------------------------------------------------

This test that you mention just tests the parsing done by pip. The
download part is mocked in this test case. I cannot reproduce this
import exception on Debian unstable with python3-pip 20.0.2-2. Also the
test cases succeed in debci. Which version of python3-pip did you use?

-- 
Benjamin Drung

DevOps Engineer and Debian & Ubuntu Developer
Platform Integration (IONOS Cloud)

1&1 IONOS SE | Greifswalder Str. 207 | 10405 Berlin | Germany
E-mail: benjamin.drung at cloud.ionos.com | Web: www.ionos.de

Hauptsitz Montabaur, Amtsgericht Montabaur, HRB 24498

Vorstand: Dr. Christian Böing, Hüseyin Dogan, Dr. Martin Endreß, Hans-
Henning Kettler, Arthur Mai, Matthias Steinberg, Achim Weiß
Aufsichtsratsvorsitzender: Markus Kadelke


Member of United Internet

Diese E-Mail kann vertrauliche und/oder gesetzlich geschützte
Informationen enthalten. Wenn Sie nicht der bestimmungsgemäße Adressat
sind oder diese E-Mail irrtümlich erhalten haben, unterrichten Sie
bitte den Absender und vernichten Sie diese E-Mail. Anderen als dem
bestimmungsgemäßen Adressaten ist untersagt, diese E-Mail zu speichern,
weiterzuleiten oder ihren Inhalt auf welche Weise auch immer zu
verwenden.

This e-mail may contain confidential and/or privileged information. If
you are not the intended recipient of this e-mail, you are hereby
notified that saving, distribution or use of the content of this e-mail 
in any way is prohibited. If you have received this e-mail in error,
please notify the sender and delete the e-mail.