[Pkg-salt-team] Bug#954154: Bug#954154: src:salt: Requires a package outside of Main

[Benjamin Drung]

Am Freitag, den 27.03.2020, 14:39 -0400 schrieb Scott Kitterman:
> On Friday, March 27, 2020 12:53:41 PM EDT Benjamin Drung wrote:
> > Hi,
> > 
> > Am Dienstag, den 17.03.2020, 09:47 -0400 schrieb Scott Kitterman:
> > > Package: src:salt
> > > Version: 3000+dfsg1-3
> > > Severity: serious
> > > Justification: Policy 2.2.1
> > > 
> > > This package uses python pip to download and install packages
> > > from
> > > outside the
> > > Debian archive to run autopkgtests.  Main is required to be self-
> > > contained,
> > > including for tests.  See the FTP Master's reject FAQ [1] item
> > > Non-
> > > Main II.
> > 
> > I disabled all test cases that need Internet access. So no pip
> > install
> > should be executed.
> 
> Great.  That's the most serious part of the bug.
> 
> > > =================================================================
> > > =====
> > > ERROR: test_install_requirements_parsing
> ...
> > > ---------------------------------------------------------------
> > > -------
> > 
> > This test that you mention just tests the parsing done by pip. The
> > download part is mocked in this test case. I cannot reproduce this
> > import exception on Debian unstable with python3-pip 20.0.2-2. Also
> > the
> > test cases succeed in debci. Which version of python3-pip did you
> > use?
> 
> It would have been 20.0.2-1, but between -1 and -2 the only changes
> were to 
> the pip autopkgtests, so it shouldn't affect things.  If you can't
> reproduce 
> it, then I wouldn't worry about it for now.  If your autopkgtest
> passes and 
> there's no downloading from outside Main, then I would be fine with
> considering 
> the issue resolved.

I figured out the reason why autopkgtests still fails on Ubuntu: My
patch skips all test that need Internet access when the environment
variable NO_INTERNET is set, but I forgot to also set NO_INTERNET in
the autopkgtest! I'll fix that.

-- 
Benjamin Drung

DevOps Engineer and Debian & Ubuntu Developer
Platform Integration (IONOS Cloud)

1&1 IONOS SE | Greifswalder Str. 207 | 10405 Berlin | Germany
E-mail: benjamin.drung at cloud.ionos.com | Web: www.ionos.de

Hauptsitz Montabaur, Amtsgericht Montabaur, HRB 24498

Vorstand: Dr. Christian Böing, Hüseyin Dogan, Dr. Martin Endreß, Hans-
Henning Kettler, Arthur Mai, Matthias Steinberg, Achim Weiß
Aufsichtsratsvorsitzender: Markus Kadelke


Member of United Internet

Diese E-Mail kann vertrauliche und/oder gesetzlich geschützte
Informationen enthalten. Wenn Sie nicht der bestimmungsgemäße Adressat
sind oder diese E-Mail irrtümlich erhalten haben, unterrichten Sie
bitte den Absender und vernichten Sie diese E-Mail. Anderen als dem
bestimmungsgemäßen Adressaten ist untersagt, diese E-Mail zu speichern,
weiterzuleiten oder ihren Inhalt auf welche Weise auch immer zu
verwenden.

This e-mail may contain confidential and/or privileged information. If
you are not the intended recipient of this e-mail, you are hereby
notified that saving, distribution or use of the content of this e-mail 
in any way is prohibited. If you have received this e-mail in error,
please notify the sender and delete the e-mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://alioth-lists.debian.net/pipermail/pkg-salt-team/attachments/20200330/a17073c9/attachment.sig>