[Pkg-salt-team] Bug#983632: Backport to buster

[Benjamin Drung]

> I am not sure if anyone else has made progress with this ? I know
> that 
> donfede had some builds working as well.  I am new to the package 
> maintainer stuff but am definitely willing to help get this all the
> way 
> done, but i will need some help as I'm a packaging noob.
> 
> I'm not really sure what to do next beyond get it so it builds
> without 
> the ^D step and to try and get as many tests working as I can.

Thanks for working on it. The test cases tend to be as broken as the
salt source code. So after fixing bugs in salt, you have to fix bugs in
the test cases.

I propose that you join the salt team as developer and push your
current work to a branch to review. I can have a look at the changes
and might find the reason for the hang.

> I am curious as to what is the policy where a security patch from 
> upstream did not include the necessary fixes for tests and breaks
> them? 

We should cherry-pick all commits that are necessary to fix the CVE and
to unbreak all test cases. That often includes more than one commit and
sometime you have the actual commit followed by fixup commits (instead
of one commit containing the correct fix).


-- 
Benjamin Drung

Senior DevOps Engineer and Debian & Ubuntu Developer
Compute Platform Operations

1&1 IONOS SE | Greifswalder Str. 207 | 10405 Berlin | Deutschland
E-Mail: benjamin.drung at ionos.com | Web: www.ionos.de

Hauptsitz Montabaur, Amtsgericht Montabaur, HRB 24498

Vorstand: Hüseyin Dogan, Dr. Martin Endreß, Claudia Frese, Henning
Kettler, Arthur Mai, Matthias Steinberg, Achim Weiß
Aufsichtsratsvorsitzender: Markus Kadelke


Member of United Internet