[Pkg-salt-team] Bug#1005053: salt FTBFS on IPV6-only buildds

[Adrian Bunk]

Source: salt
Version: 3004+dfsg1-6
Severity: serious
Tags: ftbfs

https://buildd.debian.org/status/logs.php?pkg=salt&arch=all

...
=================================== FAILURES ===================================
______________________________ test_connected_ids ______________________________

    def test_connected_ids():
        """
        test ckminion connected_ids when
        local_port_tcp returns 127.0.0.1
        """
        opts = {"publish_port": 4505, "detect_remote_minions": False}
        minion = "minion"
        ip = salt.utils.network.ip_addrs()
        mdata = {"grains": {"ipv4": ip, "ipv6": []}}
        ckminions = salt.utils.minions.CkMinions({"minion_data_cache": True})
        patch_net = patch("salt.utils.network.local_port_tcp", return_value={"127.0.0.1"})
        patch_list = patch("salt.cache.Cache.list", return_value=[minion])
        patch_fetch = patch("salt.cache.Cache.fetch", return_value=mdata)
        with patch.dict(ckminions.opts, opts):
            with patch_net, patch_list, patch_fetch:
                ret = ckminions.connected_ids()
>               assert ret == {minion}
E               AssertionError: assert set() == {'minion'}
E                 Extra items in the right set:
E                 'minion'
E                 Use -v to get the full diff

/<<PKGBUILDDIR>>/tests/pytests/unit/utils/test_minions.py:22: AssertionError
______________________ test_connected_ids_remote_minions _______________________

    def test_connected_ids_remote_minions():
        """
        test ckminion connected_ids when
        detect_remote_minions is set
        """
        opts = {
            "publish_port": 4505,
            "detect_remote_minions": True,
            "remote_minions_port": 22,
        }
        minion = "minion"
        minion2 = "minion2"
        minion2_ip = "192.168.2.10"
        ip = salt.utils.network.ip_addrs()
        mdata = {"grains": {"ipv4": ip, "ipv6": []}}
        mdata2 = {"grains": {"ipv4": [minion2_ip], "ipv6": []}}
        ckminions = salt.utils.minions.CkMinions({"minion_data_cache": True})
        patch_net = patch("salt.utils.network.local_port_tcp", return_value={"127.0.0.1"})
        patch_remote_net = patch(
            "salt.utils.network.remote_port_tcp", return_value={minion2_ip}
        )
        patch_list = patch("salt.cache.Cache.list", return_value=[minion, minion2])
        patch_fetch = patch("salt.cache.Cache.fetch", side_effect=[mdata, mdata2])
        with patch.dict(ckminions.opts, opts):
            with patch_net, patch_list, patch_fetch, patch_remote_net:
                ret = ckminions.connected_ids()
>               assert ret == {minion2, minion}
E               AssertionError: assert {'minion2'} == {'minion', 'minion2'}
E                 Extra items in the right set:
E                 'minion'
E                 Use -v to get the full diff

/<<PKGBUILDDIR>>/tests/pytests/unit/utils/test_minions.py:51: AssertionError
...
FAILED tests/pytests/unit/utils/test_minions.py::test_connected_ids - Asserti...
FAILED tests/pytests/unit/utils/test_minions.py::test_connected_ids_remote_minions
= 2 failed, 9692 passed, 1751 skipped, 5 xfailed, 4 xpassed, 552 warnings in 470.23s (0:07:50) =
Exception ignored in: <generator object IPCMessageSubscriber._read at 0x7fce22681820>
Traceback (most recent call last):
  File "/<<PKGBUILDDIR>>/salt/transport/ipc.py", line 702, in _read
TypeError: catching classes that do not inherit from BaseException is not allowed
Exception ignored in: <generator object IPCMessageSubscriber._read at 0x7fce216b9120>
Traceback (most recent call last):
  File "/<<PKGBUILDDIR>>/salt/transport/ipc.py", line 702, in _read
TypeError: catching classes that do not inherit from BaseException is not allowed
make[1]: *** [debian/rules:35: override_dh_auto_test] Error 1