[Pkg-samba-maint] 3.0.20a-0pre2 packages

Christian Perrier bubulle at debian.org
Thu Oct 13 17:06:53 UTC 2005


>     - switched init scripts (samba and winbind) to lsb-functions
>       (took patches from ubuntu)


The use of lsb-functions does not appear to really exactly follow
guidelines given in /usr/share/doc/lsb-base/README.Debian:

                log_begin_msg "Starting Samba daemons.."

                if ! start-stop-daemon --start --quiet --oknodo --exec /usr/sbin/nmbd -- -D; then
                        log_end_msg 1
                        exit 1
                fi

                if [ "$RUN_MODE" != "inetd" ]; then
                        if ! start-stop-daemon --start --quiet --oknodo --exec /usr/sbin/smbd -- -D; then
                                log_end_msg 1
                                exit 1
                        fi
                fi


should be:

                log_begin_msg "Starting Samba daemons" "smbd"

                if ! start-stop-daemon --start --quiet --oknodo --exec /usr/sbin/nmbd -- -D; then
                        log_end_msg 1
                        exit 1
                fi

                log_progress_msg "nmbd"

                if [ "$RUN_MODE" != "inetd" ]; then
                        if ! start-stop-daemon --start --quiet --oknodo --exec /usr/sbin/smbd -- -D; then
                                log_end_msg 1
                                exit 1
                        fi
                fi

etc....

Also, this doc mentions for "log_success_msg": "These functions *do
not* comply with Debian policy and should only be used by LSB
packages."






More information about the Pkg-samba-maint mailing list