[Pkg-samba-maint] About the include problem in client/mount.cifs.c

[Steve Langasek]

On Tue, May 23, 2006 at 10:22:41AM +0200, Christian Perrier wrote:
> When the 3.0.23pre1 version was announced at the end of April, Noèl
> and myself quickly discovered that we weren't able to compile it
> because of "include/version.h" not being found.

> There are indeed several solutions to this:

> -compile with "-I./"
> -replace "  #include "include/version.h"  " by
>          "  #include "../include/version.h"   "
>  in both mount.cifs.c and umount.cifs.c
> -define  MOUNT_CIFS_VENDOR_SUFFIX="Debian" which indeed seems pretty
>  logical. This is done by adding the change in our patch named
>  debian/patches/VERSION.patch

> I will certainly go for the last solution unless someone objects.

> However, it seems to me that upstream's code is not very consistent
> with other files with regards with includes....I wonder whether we
> should report this.

> Steve, do you have an advice?

Was part of the problem perhaps the fact that we were building mount.cifs
and umount.cifs by hand from debian/rules, which Peter has now fixed?

When I looked at upstream's Makefile, I couldn't find anywhere that the
appropriate CFLAGS were being set, which would've been the way to get this
bug fixed properly.  Given that we already have a workaround by setting the
vendor suffix, though, I couldn't be bothered to add new build rules to the
Makefile.in for this.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
vorlon at debian.org                                   http://www.debian.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-samba-maint/attachments/20060601/5d5a15f6/attachment.pgp