[Pkg-samba-maint] r1087 - trunk

[Peter Eisentraut]

Steve Langasek wrote:
> - Why is this init script not set -e?

LSB says

"""
Conforming scripts shall not specify the "exit on error" option (i.e. 
set -e) when sourcing this file, or calling any of the commands thus 
made available.
"""

Perhaps the Debian implementation does not have that restriction, but I 
have no information on that.

> - Why does "restart" not just call /etc/init.d/winbind stop followed
> by /etc/init.d/winbind start, which would avoid any code duplication
> without introducing tacky shell functions?

I guess there are diverging preferences on how to do that, probably 
related to whether the eventual output reads

Restarting foo ...

or

Stopping foo ...
Starting foo ...

I suppose I'm used to the former or inherited that from somewhere in 
another package but it probably makes more sense to do away with the 
shell functions and choose the simpler style.