[Pkg-samba-maint] Proposal to enhance the init script for samba

[Steve Langasek]

On Tue, Apr 17, 2007 at 08:39:00PM +0200, Christian Perrier wrote:
> Please find below a diff, as well as an entire file ; to have the
> samba init script becoming closer to the recommendations from
> /etc/init.d/skeleton, which try to suggest a common writing style for
> init scripts.

> The main enhancement here is respecting the VERBOSE variable (see a
> recent discussion in -devel:
> http://lists.debian.org/debian-devel/2007/04/msg00491.html

I object to this patch for the reasons in my follow-up to that thread.  I
see no reason at all why individual maintainer scripts should bear the
burden of handling $VERBOSE directly when we're already going to the trouble
of supporting the (very ugly and poorly designed interface of the) LSB init
script spec.  Let $VERBOSE be handled by /lib/lsb/functions, if it's
worthwhile.

Also:  yuck, more includes that don't work right under set +e.  What is this
world coming to...

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
vorlon at debian.org                                   http://www.debian.org/